Fisheye on dgfirmware/firmware/App/Services/Interrupts.c

DG-DEN-14902-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:53:35 -0800

Dara Navaei Closed DG-DEN-14902-1

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Jan 2024 14:41:57 -0800

Dara Navaei committed 4bd3bf3 on branch DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging, DEN-16499-fw-message-list-testing-issues-2 and 14 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FlowSensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

… 86 more files in changeset.

DG-DEN-4217-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:28:36 -0700

Dara Navaei Closed DG-DEN-4217-1

DG-DEN-4217-1: reviewers finished

Thu, 19 Oct 2023 08:28:27 -0700

Dara Navaei , qnguyen (deleted user) and pmontazemi (deleted user) finished reviewing DG-DEN-4217-1

DG-DEN-4217_Level and Shock Detection

DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:28:18 -0700

Dara Navaei replied to pmontazemi (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:27:53 -0700

Dara Navaei replied to pmontazemi (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-4217-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:26:45 -0700

Dara Navaei started review DG-DEN-4217-1

DG-DEN-9480-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:05:20 -0700

Dara Navaei Closed DG-DEN-9480-1

DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:05:10 -0700

Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:03:54 -0700

Dara Navaei started review DG-DEN-9480-1

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 11:23:57 -0700

Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

DG-DEN-16446-1: closed by Dara Navaei

Dara Navaei — Mon, 09 Oct 2023 11:10:29 -0700

Dara Navaei Closed DG-DEN-16446-1

DG-DEN-16446-1: reviewers finished

Mon, 09 Oct 2023 11:07:03 -0700

wbracken (deleted user) , Sean Nash and jtaylor (deleted user) finished reviewing DG-DEN-16446-1

DG-DEN-16446_DG Dev Test Clean UP

DG-DEN-16446-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH"

wbracken — Mon, 09 Oct 2023 11:06:58 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-16446-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-16446-1: comment by Dara Navaei "Done"

Dara Navaei — Mon, 09 Oct 2023 09:20:50 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-16446-1

Done

DG-DEN-16446-1: comment by wbracken "sizeof should be first in if"

wbracken — Sun, 08 Oct 2023 17:54:57 -0700

wbracken (deleted user) commented on DG-DEN-16446-1

sizeof should be first in if

DG-DEN-16446-1: comment by wbracken "Should this have a set of parenthesis around th..."

wbracken — Mon, 02 Oct 2023 00:38:20 -0700

wbracken (deleted user) commented on DG-DEN-16446-1

Should this have a set of parenthesis around the condition similar to line 437?

DG-DEN-16446-1: comment by wbracken "Resolved in code review."

wbracken — Fri, 06 Oct 2023 10:18:39 -0700

wbracken (deleted user) replied to Dara Navaei in DG-DEN-16446-1

Resolved in code review.

DG-DEN-16446-1: comment by Dara Navaei "In the condition in line 437 we do a subtractio..."

Dara Navaei — Tue, 03 Oct 2023 14:33:17 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-16446-1

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

DG-DEN-16446-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Sun, 01 Oct 2023 16:15:12 -0700

Sean Nash replied to Dara Navaei in DG-DEN-16446-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16446-1: comment by jtaylor "The question was resolved in comments for earli..."

jtaylor — Fri, 29 Sep 2023 11:15:12 -0700

jtaylor (deleted user) replied to jtaylor (deleted user) in DG-DEN-16446-1

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

DG-DEN-16446-1: comment by jtaylor "RESOLVED in CODE WALKTHROUGH. (with nausea)"

jtaylor — Fri, 29 Sep 2023 11:13:42 -0700

jtaylor (deleted user) replied to Dara Navaei in DG-DEN-16446-1

RESOLVED in CODE WALKTHROUGH. (with nausea)

DG-DEN-16446-1: comment by jtaylor "But if _VECTORCAST_ is defined there is no defa..."

jtaylor — Fri, 29 Sep 2023 11:08:02 -0700

jtaylor (deleted user) replied to Dara Navaei in DG-DEN-16446-1

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

DG-DEN-16446-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 28 Sep 2023 08:56:17 -0700

Dara Navaei replied to jtaylor (deleted user) in DG-DEN-16446-1

Done

DG-DEN-16446-1: comment by Dara Navaei "This code is the theoretical code for treatment..."

Dara Navaei — Thu, 28 Sep 2023 08:33:26 -0700

Dara Navaei replied to Sean Nash in DG-DEN-16446-1

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

DG-DEN-16446-1: comment by Dara Navaei "This default is in an if statement to make sure..."

Dara Navaei — Thu, 28 Sep 2023 08:30:16 -0700

Dara Navaei replied to jtaylor (deleted user) in DG-DEN-16446-1

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

DG-DEN-16446-1: comment by jtaylor "Our coding standard encourages always including..."

jtaylor — Wed, 27 Sep 2023 16:27:37 -0700

jtaylor (deleted user) commented on DG-DEN-16446-1

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

DG-DEN-16446-1: comment by Sean Nash "What's left? When would this code ever become ..."

Sean Nash — Wed, 27 Sep 2023 13:07:19 -0700

Sean Nash commented on DG-DEN-16446-1

What's left? When would this code ever become reachable?

DG-DEN-16446-1: comment by jtaylor "The default case should probably be present, wh..."

jtaylor — Wed, 27 Sep 2023 08:29:47 -0700

jtaylor (deleted user) commented on DG-DEN-16446-1

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code and VectorCAST tests

Dara Navaei — Sat, 23 Sep 2023 16:48:53 -0700

Dara Navaei committed d06df46 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code and VectorCAST tests

· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-1, +4)	\| History	\| Source	\| Diff