Fisheye on dgfirmware/firmware/App/Controllers/ConcentratePumps.c https://devapps.diality.us/changelog/~br%3Drelease%25402fp1b%25402fmaster/dgfirmware/firmware/App/Controllers/ConcentratePumps.c Recent activity in "dgfirmware" under directory /firmware/App/Controllers/ConcentratePumps.c dgfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 10 Apr 2025 16:45:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=a34dc520aab322e18292973aee0c663afc17fcd6 https://devapps.diality.us/changelog/dgfirmware?cs=a34dc520aab322e18292973aee0c663afc17fcd6 Dara Navaei committed a34dc52 on branch release/p1b/master in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> dgfirmware (release/p1b/master): Merged release/p1b/staging Thu, 10 Apr 2025 15:10:22 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=704415d4a27cdff6d2cdc9c3641477ee7ccde6af https://devapps.diality.us/changelog/dgfirmware?cs=704415d4a27cdff6d2cdc9c3641477ee7ccde6af Dara Navaei committed 704415d on branch release/p1b/master in dgfirmware Merged release/p1b/staging

· /firmware/App/Controllers/ConcentratePumps.c (-10, +23) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-3, +6) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c (-7, +42) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-91, +87) | History | Source | Diff
]]> DG-DENBUG-298-1: closed by Dara Navaei Thu, 10 Apr 2025 15:09:27 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Dara Navaei Closed DG-DENBUG-298-1 ]]> DG-DENBUG-298-1: reviewers finished Wed, 09 Apr 2025 16:43:33 -0700 https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Michael Garthwaite and Sean Nash finished reviewing DG-DENBUG-298-1 DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging ]]> dgfirmware (release/p1b/staging): DENBUG-298 updated the code from staging Tue, 08 Apr 2025 17:25:24 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=00b244580f01f3cbd1b7d2d5a14ee61675bf4642 https://devapps.diality.us/changelog/dgfirmware?cs=00b244580f01f3cbd1b7d2d5a14ee61675bf4642 Dara Navaei committed 00b2445 on branch DEN-17299-release_22_p1b_staging, DENBUG-298-user-unable-to-deliver-saline-P1B-STAGING and 3 more in dgfirmware DENBUG-298 updated the code from staging

· /firmware/App/Controllers/ConcentratePumps.c (-10, +23) | History | Source | Diff
· /firmware/App/Modes/ModeFill.c (-0, +6) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.c (-3, +6) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c (-7, +42) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +0) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-91, +87) | History | Source | Diff
]]> DG-DENBUG-298-1: started by Dara Navaei Tue, 08 Apr 2025 14:25:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-298-1 https://devapps.diality.us/cru/DG-DENBUG-298-1 Dara Navaei started review DG-DENBUG-298-1 ]]> DG-DENBUG-307-1: closed by Dara Navaei Fri, 04 Apr 2025 15:04:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Dara Navaei Closed DG-DENBUG-307-1 ]]> DG-DENBUG-307-1: reviewers finished Fri, 04 Apr 2025 11:00:43 -0700 https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Michael Garthwaite finished reviewing DG-DENBUG-307-1 DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging ]]> DG-DENBUG-307-1: reviewers finished Wed, 02 Apr 2025 11:14:02 -0700 https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Sean Nash finished reviewing DG-DENBUG-307-1 DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging ]]> DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 02 Apr 2025 11:13:55 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21867 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21867 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Sean Nash "Not needed, but benign. RESOLVED in CODE WALKT..." Wed, 02 Apr 2025 11:13:43 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21866 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21866 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 02 Apr 2025 11:13:11 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21865 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21865 Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DENBUG-307-1: comment by Dara Navaei "Done" Wed, 02 Apr 2025 10:28:52 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21864 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21864 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

]]> DG-DENBUG-307-1: comment by Dara Navaei "Done" Wed, 02 Apr 2025 10:27:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21863 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21863 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

]]> DG-DENBUG-307-1: comment by Dara Navaei "I used fabs so all are positive when monitoring..." Wed, 02 Apr 2025 10:26:21 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21862 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21862 Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

I used fabs so all are positive when monitoring is started.

]]> DG-DENBUG-307-1: comment by Sean Nash "This check doesn't make sense to me. Measured ..." Tue, 01 Apr 2025 09:03:02 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21861 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21861 Sean Nash commented on DG-DENBUG-307-1

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

]]> DG-DENBUG-307-1: comment by Sean Nash "Aren't speeds (commanded and measured) always p..." Tue, 01 Apr 2025 09:01:22 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21860 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21860 Sean Nash commented on DG-DENBUG-307-1

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

]]> DG-DENBUG-307-1: comment by Sean Nash "Measured speed (whether real or override) shoul..." Tue, 01 Apr 2025 08:59:42 -0700 Sean Nash https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21859 https://devapps.diality.us/cru/DG-DENBUG-307-1/#c21859 Sean Nash commented on DG-DENBUG-307-1

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

]]> DG-DENBUG-307-1: started by Dara Navaei Fri, 07 Mar 2025 11:32:56 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-307-1 https://devapps.diality.us/cru/DG-DENBUG-307-1 Dara Navaei started review DG-DENBUG-307-1 ]]> dgfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 07 Feb 2025 17:52:30 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=da0deea71ed5770d98a00943369b9c17321e139f https://devapps.diality.us/changelog/dgfirmware?cs=da0deea71ed5770d98a00943369b9c17321e139f Dara Navaei committed da0deea on branch release/p1b/master in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 86 more files in changeset.
]]> DG-DEN-17220-1: closed by Dara Navaei Fri, 07 Feb 2025 16:12:39 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei Closed DG-DEN-17220-1 ]]> DG-DEN-17220-1: reviewers finished Fri, 07 Feb 2025 10:03:27 -0800 https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 jpaguio  (deleted user) and Sean Nash finished reviewing DG-DEN-17220-1 DG-DEN-17220_Release 20 P1B Staging ]]> dgfirmware (release/p1b/staging): DEN-17220 added the code changes from staging Thu, 06 Feb 2025 17:02:55 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=368ded18d302d93a7c47192f7360bfefa5acecd8 https://devapps.diality.us/changelog/dgfirmware?cs=368ded18d302d93a7c47192f7360bfefa5acecd8 Dara Navaei committed 368ded1 on branch DEN-17220-release_20_p1b_staging, DEN-17299-release_22_p1b_staging and 4 more in dgfirmware DEN-17220 added the code changes from staging

· /firmware/App/Controllers/ConcentratePumps.c (-5, +14) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/PIControllers.c (-0, +1) | History | Source | Diff
]]> DG-DEN-17220-1: started by Dara Navaei Thu, 06 Feb 2025 14:19:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17220-1 https://devapps.diality.us/cru/DG-DEN-17220-1 Dara Navaei started review DG-DEN-17220-1 ]]> DG-DEN-17135-1: closed by Dara Navaei Fri, 31 Jan 2025 16:57:30 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Dara Navaei Closed DG-DEN-17135-1 ]]> DG-DEN-17135-1: reviewers finished Thu, 30 Jan 2025 10:39:28 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Sean Nash finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: reviewers finished Wed, 29 Jan 2025 17:32:19 -0800 https://devapps.diality.us/cru/DG-DEN-17135-1 https://devapps.diality.us/cru/DG-DEN-17135-1 Vinayakam Mani finished reviewing DG-DEN-17135-1 DG-DEN-17135_Concentrate Pump Calibration Staging ]]> DG-DEN-17135-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH" Wed, 29 Jan 2025 17:32:01 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21294 Vinayakam Mani replied to Dara Navaei in DG-DEN-17135-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-17135-1: comment by Dara Navaei "Updated the trigger condition. This is a calibr..." Wed, 29 Jan 2025 17:22:53 -0800 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21292 Dara Navaei replied to Vinayakam Mani in DG-DEN-17135-1

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

]]> DG-DEN-17135-1: comment by Vinayakam Mani "The Trigger condition is little confusing. coul..." Wed, 29 Jan 2025 17:12:35 -0800 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 https://devapps.diality.us/cru/DG-DEN-17135-1/#c21289 Vinayakam Mani commented on DG-DEN-17135-1

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

]]>