Fisheye on dgfirmware/firmware/App/Modes/ModeHeatDisinfect.h https://devapps.diality.us/changelog/~br%3Drelease%25402fp1b%25402fmaster/dgfirmware/firmware/App/Modes/ModeHeatDisinfect.h Recent activity in "dgfirmware" under directory /firmware/App/Modes/ModeHeatDisinfect.h dgfirmware (release/p1b/master): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Fri, 07 Feb 2025 17:52:30 -0800 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=da0deea71ed5770d98a00943369b9c17321e139f https://devapps.diality.us/changelog/dgfirmware?cs=da0deea71ed5770d98a00943369b9c17321e139f Dara Navaei committed da0deea on branch release/p1b/master in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/ConductivitySensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DrainPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Fans.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FlowSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/FluidLeak.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Heaters.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/LoadCell.c (-1, +1) | History | Source | Diff
… 86 more files in changeset.
]]> DG-DEN-17053-6: closed by Dara Navaei Fri, 20 Sep 2024 16:39:59 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Dara Navaei Closed DG-DEN-17053-6 ]]> DG-DEN-17053-6: reviewers finished Tue, 17 Sep 2024 10:27:48 -0700 https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Michael Garthwaite finished reviewing DG-DEN-17053-6 DG-DEN-17053_Release 17 Firmware Update ]]> DG-DEN-17053-6: reviewers finished Mon, 16 Sep 2024 11:10:23 -0700 https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Sean Nash finished reviewing DG-DEN-17053-6 DG-DEN-17053_Release 17 Firmware Update ]]> DG-DEN-17053-6: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 16 Sep 2024 11:10:15 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20214 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20214 Sean Nash replied to Dara Navaei in DG-DEN-17053-6

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17053-6: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 16 Sep 2024 11:10:01 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20213 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20213 Sean Nash replied to Dara Navaei in DG-DEN-17053-6

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-17053-6: comment by Dara Navaei "Done" Mon, 16 Sep 2024 11:07:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6/#c20212 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20212 Dara Navaei replied to Sean Nash in DG-DEN-17053-6

Done

]]> DG-DEN-17053-6: comment by Dara Navaei "Done" Mon, 16 Sep 2024 11:04:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6/#c20211 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20211 Dara Navaei replied to Sean Nash in DG-DEN-17053-6

Done

]]> DG-DEN-17053-6: comment by Sean Nash "No colon." Fri, 13 Sep 2024 12:59:49 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20209 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20209 Sean Nash commented on DG-DEN-17053-6

No colon.

]]> DG-DEN-17053-6: comment by Sean Nash "Do not put colons after params." Fri, 13 Sep 2024 12:59:26 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-17053-6/#c20208 https://devapps.diality.us/cru/DG-DEN-17053-6/#c20208 Sean Nash commented on DG-DEN-17053-6

Do not put colons after params.

]]> DG-DEN-17053-6: started by Dara Navaei Fri, 13 Sep 2024 12:24:35 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-17053-6 https://devapps.diality.us/cru/DG-DEN-17053-6 Dara Navaei started review DG-DEN-17053-6 ]]> dgfirmware (release/p1b/staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 27 Aug 2024 16:34:46 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=e6c60e07b450ec8d58e87bf13d45f96efab54d8b https://devapps.diality.us/changelog/dgfirmware?cs=e6c60e07b450ec8d58e87bf13d45f96efab54d8b Dara Navaei committed e6c60e0 on branch DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool, DEN-17047-remove-uv-reactors-from-code-bases and 17 more in dgfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeHeatDisinfect.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-1, +1) | History | Source | Diff
]]> DG-DEN-16680-1: closed by Dara Navaei Tue, 27 Aug 2024 16:09:08 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16680-1 https://devapps.diality.us/cru/DG-DEN-16680-1 Dara Navaei Closed DG-DEN-16680-1 ]]> DG-DEN-16680-1: reviewers finished Tue, 27 Aug 2024 09:52:11 -0700 https://devapps.diality.us/cru/DG-DEN-16680-1 https://devapps.diality.us/cru/DG-DEN-16680-1 Sean Nash finished reviewing DG-DEN-16680-1 DG-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> DG-DEN-16680-1: reviewers finished Mon, 26 Aug 2024 11:22:25 -0700 https://devapps.diality.us/cru/DG-DEN-16680-1 https://devapps.diality.us/cru/DG-DEN-16680-1 Vinayakam Mani finished reviewing DG-DEN-16680-1 DG-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> dgfirmware (release/p1b/staging): DEN-16680 updated the heat disinfect mode with the latest changes on the passive active cool heat disinfect Fri, 12 Jul 2024 13:29:42 -0700 Dara Navaei https://devapps.diality.us/changelog/dgfirmware?cs=ab9597daa82d8e4575a8bb1fd8438ac301b85d44 https://devapps.diality.us/changelog/dgfirmware?cs=ab9597daa82d8e4575a8bb1fd8438ac301b85d44 Dara Navaei committed ab9597d on branch DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging, DEN-16970-stuck-in-cancel-basic-path-during-heat-disinfect-passive-cool and 18 more in dgfirmware DEN-16680 updated the heat disinfect mode with the latest changes on the passive active cool heat disinfect

· /firmware/App/Modes/ModeHeatDisinfect.c (-368, +112) | History | Source | Diff
· /firmware/App/Modes/ModeHeatDisinfect.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemComm.c (-3, +3) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-8, +8) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.h (-2, +2) | History | Source | Diff
]]> DG-DEN-16680-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 03 Jul 2024 17:23:34 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16680-1/#c19811 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19811 Sean Nash replied to Dara Navaei in DG-DEN-16680-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16680-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH" Wed, 03 Jul 2024 12:13:46 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16680-1/#c19810 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19810 Sean Nash replied to Dara Navaei in DG-DEN-16680-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-16680-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Wed, 03 Jul 2024 09:50:56 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16680-1/#c19809 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19809 Sean Nash replied to Dara Navaei in DG-DEN-16680-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16680-1: comment by Dara Navaei "Added an event." Tue, 02 Jul 2024 09:02:09 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16680-1/#c19806 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19806 Dara Navaei replied to Sean Nash in DG-DEN-16680-1

Added an event.

]]> DG-DEN-16680-1: comment by Dara Navaei "Done" Tue, 02 Jul 2024 08:55:53 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16680-1/#c19804 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19804 Dara Navaei replied to Sean Nash in DG-DEN-16680-1

Done

]]> DG-DEN-16680-1: comment by Dara Navaei "Removed the one in else." Tue, 02 Jul 2024 08:51:07 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16680-1/#c19803 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19803 Dara Navaei replied to Sean Nash in DG-DEN-16680-1

Removed the one in else.

]]> DG-DEN-16680-1: comment by Sean Nash "Is this necessary in else? If so, can move abo..." Mon, 01 Jul 2024 17:05:59 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16680-1/#c19802 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19802 Sean Nash commented on DG-DEN-16680-1

Is this necessary in else? If so, can move above or below the if so you just do it once.

]]> DG-DEN-16680-1: comment by Sean Nash "This flag is really indicating drain water is n..." Mon, 01 Jul 2024 17:00:56 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16680-1/#c19801 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19801 Sean Nash commented on DG-DEN-16680-1

This flag is really indicating drain water is not too hot OR we are not doing a nocturnal heat disinfect. Flag name could be better.

]]> DG-DEN-16680-1: comment by Sean Nash "This could just be an event at start." Mon, 01 Jul 2024 16:52:25 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16680-1/#c19800 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19800 Sean Nash commented on DG-DEN-16680-1

This could just be an event at start.

]]> DG-DEN-16680-1: comment by Vinayakam Mani "RESOLVED IN CODEWALKTHROUGH." Mon, 01 Jul 2024 09:48:18 -0700 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16680-1/#c19796 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19796 Vinayakam Mani replied to Vinayakam Mani in DG-DEN-16680-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-16680-1: comment by Vinayakam Mani "RESOLVED IN CODEWALKTHROUGH." Mon, 01 Jul 2024 09:47:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16680-1/#c19795 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19795 Vinayakam Mani replied to Vinayakam Mani in DG-DEN-16680-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-16680-1: comment by Vinayakam Mani "RESOLVED IN CODEWALKTHROUGH." Mon, 01 Jul 2024 09:47:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/DG-DEN-16680-1/#c19794 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19794 Vinayakam Mani replied to Vinayakam Mani in DG-DEN-16680-1

RESOLVED IN CODEWALKTHROUGH.

]]> DG-DEN-16680-1: comment by Dara Navaei "Thanks I meant medium priority. Changed the ran..." Mon, 01 Jul 2024 09:27:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16680-1/#c19793 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19793 Dara Navaei replied to Vinayakam Mani in DG-DEN-16680-1

Thanks I meant medium priority. Changed the rank to 500.

]]> DG-DEN-16680-1: comment by Dara Navaei "If it does not come down below 60 and in the co..." Mon, 01 Jul 2024 09:21:45 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16680-1/#c19792 https://devapps.diality.us/cru/DG-DEN-16680-1/#c19792 Dara Navaei replied to Vinayakam Mani in DG-DEN-16680-1

If it does not come down below 60 and in the cool idle cycle if any issue occurs, the DG Software transitions to the cancel basic path.

]]>