Fisheye on hdfirmware/firmware/source

BOOTLOADER-DEN-14892-3: started by Dara Navaei

Dara Navaei — Sun, 11 Jan 2026 17:23:59 -0800

Dara Navaei started review BOOTLOADER-DEN-14892-3

BOOTLOADER-DEN-14892-2: started by Dara Navaei

Dara Navaei — Sun, 11 Jan 2026 17:11:25 -0800

Dara Navaei started review BOOTLOADER-DEN-14892-2

BOOTLOADER-DEN-14892-3: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:42:18 -0800

Dara Navaei Needs Fixing BOOTLOADER-DEN-14892-3

BOOTLOADER-DEN-14892-3: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:42:14 -0800

Dara Navaei Abandoned BOOTLOADER-DEN-14892-3

BOOTLOADER-DEN-14892-2: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:39:18 -0800

Dara Navaei Needs Fixing BOOTLOADER-DEN-14892-2

BOOTLOADER-DEN-14892-2: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:39:14 -0800

Dara Navaei Abandoned BOOTLOADER-DEN-14892-2

HD-DEN-16565-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:58:47 -0800

Dara Navaei Closed HD-DEN-16565-1

HD-DEN-14892-4: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:53:54 -0800

Dara Navaei Closed HD-DEN-14892-4

HD-DEN-14892-3: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:53:48 -0800

Dara Navaei Closed HD-DEN-14892-3

hdfirmware (swupdateHD): Updated the HALCoGen based on the Sunrise work

Dara Navaei — Wed, 14 Aug 2024 14:43:14 -0700

Dara Navaei committed 4d03f00 on branch swupdateHD in hdfirmware

Updated the HALCoGen based on the Sunrise work

· /firmware/App/HDCommon.h	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/HD.dil	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/source/sys_link.cmd	(-99, +99)	\| History	\| Source	\| Diff
· /firmware/source/sys_startup.c	(-44, +0)	\| History	\| Source	\| Diff

hdfirmware (swupdateHD): SW update HD test

Dara Navaei — Fri, 26 Jul 2024 13:31:44 -0700

Dara Navaei committed 1addb5d on branch swupdateHD in hdfirmware

SW update HD test

· /firmware/.cproject	(-2, +11)	\| History	\| Source	\| Diff
· /firmware/.settings/org.eclipse.cdt.codan.core.prefs	(-0, +72)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/source/sys_link.cmd	(-129, +160)	\| History	\| Source	\| Diff

HD-DEN-16565-1: comment by Sean Nash "Why is bootloader executing in a different mode..."

Sean Nash — Thu, 06 Jun 2024 10:52:13 -0700

Sean Nash replied to Vinayakam Mani in HD-DEN-16565-1

Why is bootloader executing in a different mode than app? Is that necessary? How will mode switch back to user when jumping to app?

HD-DEN-16565-1: comment by Vinayakam Mani "Bootloader seems to be executed in supervisory ..."

Vinayakam Mani — Fri, 24 May 2024 11:52:31 -0700

Vinayakam Mani commented on HD-DEN-16565-1

Bootloader seems to be executed in supervisory mode. if so, the current allocated stack for supervisory mode is 1K (if we merge into existing HD/DG firmware). we may need to watch for supervisory mode stack size, in case boot loader consumes more that 1K?

HD-DEN-16565-1: comment by Vinayakam Mani "the second value is 0x00 or 0xFFFFFFFF? Th..."

Vinayakam Mani — Fri, 24 May 2024 11:43:41 -0700

Vinayakam Mani commented on HD-DEN-16565-1

the second value is 0x00 or 0xFFFFFFFF?

The bootloader checks the value is not equal to 0xFFFFFFFF, if so, the valid application is not found, and firmware needs to be updated.

HD-DEN-16565-1: comment by Vinayakam Mani "Looks to be memory overflow to be occurred. sr..."

Vinayakam Mani — Fri, 24 May 2024 11:19:12 -0700

Vinayakam Mani commented on HD-DEN-16565-1

Looks to be memory overflow to be occurred. src-> pointing the buffer of 4 bytes length. bytes-> mentioning 16 bytes length. g_pulUpdateSuccess[] should be allocated more than the current size. Also, Do we need to typecast "(uint32_t) bytes", since the api mentioning (uint8_t)?

Fapi_StatusType Fapi_issueProgrammingCommand(
uint32_t *pu32StartAddress,
uint8_t *pu8DataBuffer,
uint8_t u8DataBufferSizeInBytes,
uint8_t *pu8EccBuffer,
uint8_t u8EccBufferSizeInBytes,
Fapi_FlashProgrammingCommandType oMode)

HD-DENBUG-249-1: closed by Dara Navaei

Dara Navaei — Mon, 13 May 2024 13:23:09 -0700

Dara Navaei Closed HD-DENBUG-249-1

HD-DENBUG-249-1: reviewers finished

Mon, 13 May 2024 10:13:27 -0700

Vinayakam Mani and Sean Nash finished reviewing HD-DENBUG-249-1

HD-DENBUG-249_Pressure Window Starting Values P1 Staging

HD-DENBUG-249-1: started by Dara Navaei

Dara Navaei — Sun, 12 May 2024 14:38:57 -0700

Dara Navaei started review HD-DENBUG-249-1

HD-DEN-16851-1: closed by Vinayakam Mani

Vinayakam Mani — Fri, 10 May 2024 11:59:08 -0700

Vinayakam Mani Closed HD-DEN-16851-1

HD-DEN-16851-1: reviewers finished

Fri, 10 May 2024 11:35:14 -0700

Dara Navaei finished reviewing HD-DEN-16851-1

HD-DEN-16851_New Alarm For Increased Occlus

HD-DEN-16851-1: reviewers finished

Thu, 09 May 2024 12:43:35 -0700

Sean Nash finished reviewing HD-DEN-16851-1

HD-DEN-16851_New Alarm For Increased Occlus

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16851- HD stack optimization

Vinayakam Mani — Thu, 02 May 2024 14:06:56 -0700

Vinayakam Mani committed 1a178ae on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 33 more in hdfirmware

DEN-16851- HD stack optimization

· /firmware/HD.dil	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/include/sys_core.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/source/sys_core.asm	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/source/sys_link.cmd	(-4, +4)	\| History	\| Source	\| Diff

HD-DEN-16851-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 02 May 2024 12:54:21 -0700