application / sources / model / settings

MBluetooth.cpp

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 29 Mar 23
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 11 Sep 2023
4:10 pm

Behrouz NematiPour

4:10 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:10 pm

Behrouz NematiPour

UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
4:08 pm

Behrouz NematiPour

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

Wednesday 06 Sep 2023
11:32 am

vduong  (deleted user)

UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
6:22 am

vduong  (deleted user)

Tuesday 05 Sep 2023
4:46 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:45 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:44 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:43 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:41 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:40 pm

msuleiman  (deleted user)

3:56 pm

vduong  (deleted user)

Done.

Done.

3:56 pm

vduong  (deleted user)

Per our call, you have agreed to leave it above in this location. No change in location

Per our call, you have agreed to leave it above in this location. No change in location

3:55 pm

vduong  (deleted user)

We clarify this thread with a call.

We clarify this thread with a call.

3:55 pm

vduong  (deleted user)

This is no longer applicable due to the changes from our conversation.

This is no longer applicable due to the changes from our conversation.

3:55 pm

vduong  (deleted user)

I made the changes based on the call we had.

I made the changes based on the call we had.

2:09 pm

Behrouz NematiPour

not clear what it means.

not clear what it means.

2:09 pm

vduong  (deleted user)

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

2:08 pm

vduong  (deleted user)

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

2:08 pm

Behrouz NematiPour

where do you use this ctor?

where do you use this ctor?

2:07 pm

Behrouz NematiPour

I remember and and can we use reconnect as a Paired State.

I remember and and can we use reconnect as a Paired State.

2:03 pm

vduong  (deleted user)

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

2:02 pm

Behrouz NematiPour

when do we know if that is paired, I think the ticket wants that one, right?

when do we know if that is paired, I think the ticket wants that one, right?

2:02 pm

vduong  (deleted user)

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

1:52 pm

Behrouz NematiPour

move these two in the same location it was, to keep the order.

move these two in the same location it was, to keep the order.

1:43 pm

Behrouz NematiPour

make them one-liner in front of the if/else and align.

make them one-liner in front of the if/else and align.

1:41 pm

Behrouz NematiPour

make it bool isPaired();

make it
bool isPaired();

1:35 pm

Behrouz NematiPour

please use the shorter constructor provided. the error needs to be initialized as well, then it becomes the simple one.

please use the shorter constructor provided.
the error needs to be initialized as well, then it becomes the simple one.

Wednesday 30 Aug 2023
2:06 pm

Dara Navaei

UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]
UI-DEN-16335_UI VD S105 Bluetooth Missing Connect Logs - [READY]