scripts / build

unittest.sh

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 23 Apr 20
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Jul 2023
2:48 pm

Behrouz NematiPour

2:48 pm

Behrouz NematiPour

this CR is to old and obsolete.

this CR is to old and obsolete.

Monday 17 Jul 2023
12:41 pm

Dara Navaei

SCRIPTS-DEN-2793_Addcommonrepositorytotheuiprojectandrefactorcurrentcodes
SCRIPTS-DEN-2793_Addcommonrepositorytotheuiprojectandrefactorcurrentcodes
Monday 27 Apr 2020
9:38 am

Behrouz NematiPour

9:34 am

plucia  (deleted user)

9:33 am

plucia  (deleted user)

RESOLVED

RESOLVED

Sunday 26 Apr 2020
9:11 pm

pmontazemi  (deleted user)

Friday 24 Apr 2020
9:06 pm

Behrouz NematiPour

Hey Peter, Thanks for the comments and all the testing . This function doesn't mean to be used the way you tested it. But anyway I came up with a better solution. def partition(vString, vPart, vRig...

Hey Peter,
Thanks for the comments and all the testing .
This function doesn't mean to be used the way you tested it.
But anyway I came up with a better solution.

def partition(vString, vPart, vRightDirection=True):
    return [vString[i: i + vPart] for i in range(0, len(vString), vPart)][::-1 if vRightDirection else 1]

Actually my first thought was not correct on how this portion of the code should work.

3:16 pm

plucia  (deleted user)

def partition_orig(vString, vPart, vRightDirection = True): if vRightDirection: list = [vString[i - vPart : i] for i in range(len(vString), 0, -vPart)] else: list = [vStrin...

def partition_orig(vString, vPart, vRightDirection = True):
    if vRightDirection:
        list = [vString[i - vPart : i] for i in range(len(vString), 0, -vPart)]
    else:
        list = [vString[i : i + vPart] for i in range(0, len(vString), vPart)]
    return list


def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]

print(partition_orig("TESTING123", 3))
print(partition_2("TESTING123", 3))


Outputs: 

['123', 'ING', 'EST', '']
['123', 'ING', 'EST', 'T']


whereas 

def partition_2(vString, vPart, vRightDirection = True):
    if vRightDirection:
        vString = vString[::-1]
    return [vString[i : i + vPart] for i in range(0, len(vString), vPart)]


outputs 

['321', 'GNI', 'TSE', 'T']


I think you're saying you want to do the second one right? I think that would be better too!

Edit: Also I don't think you need the mString because in python immutable types (e.g. string, number, tuple) behave like call by value

2:22 pm

Behrouz NematiPour

I came out with the solution below : def partition1(vString, vPart, vRightDirection=True): mString = vString if vRightDirection: mString = vString[::-1] else: mString = vString list = [mString[i: ...

I came out with the solution below :

def partition1(vString, vPart, vRightDirection=True):
mString = vString
if vRightDirection:
mString = vString[::-1]
else:
mString = vString
list = [mString[i: i + vPart] for i in range(0, len(mString), vPart)]
return list

if _name_ == "_main_":
vString = "TESTING"
vPart = 3

list = partition1(vString, vPart, True)
print(list)


list = partition1(vString, vPart, False)
print(list)

// ----- Output ----- :
['GNI', 'TSE', 'T']
['TES', 'TIN', 'G']

which is exactly what I want.
I'm gonna push changes if you agree.

1:38 pm

Behrouz NematiPour

Thank you so much Peter. This is exactly the kind of code review I really like. I looked at the code you sent and tried to test it. At a first glance I saw a misbehavior. your code is partition2. ...

Thank you so much Peter.
This is exactly the kind of code review I really like.
I looked at the code you sent and tried to test it.
At a first glance I saw a misbehavior.

your code is partition2.
list = partition2("TESTING", 2, False)
print(list)

list = partition("TESTING", 2, False)
print(list)
// —
The output is different :
['ET', 'TS', 'NI', 'G'] partition2
['TE', 'ST', 'IN', 'G'] partition

so the output is unexpected.

12:47 pm

plucia  (deleted user)

partition("TESTING123", 3) will return ['123', 'ING', 'EST', ''] which is missing a character. Also, partition("TESTING123", 12) returns ['23'] which isn't right. How about: def...
 partition("TESTING123", 3)


will return 

['123', 'ING', 'EST', '']


which is missing a character.

Also, 

 partition("TESTING123", 12)


returns 

 ['23']


which isn't right.

How about:

def partition(vString, vPart, vRightDirection = True):
	if vRightDirection:
		vString = vString[::-1]
	return [vString[i : i + vPart][::-1] for i in range(0, len(vString), vPart)]
Thursday 23 Apr 2020
1:29 am

Behrouz NematiPour

DEN-2793 : Use Common Repository

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

Options
    • -0
    • +9
    ./unittest.sh
  2. … 1 more file in changeset.
Wednesday 22 Apr 2020
1:39 pm

Behrouz NematiPour

UI-DEN-2236_UI 100% Coverage of the Application Software
UI-DEN-2236_UI 100% Coverage of the Application Software
Tuesday 21 Apr 2020
5:16 am

Behrouz NematiPour

DEN-2236_UI100%CoverageoftheApplicationSoftware

Options
    • -1
    • +1
    ./unittest.sh
  2. … 1 more file in changeset.
Thursday 09 Apr 2020
3:58 am

Behrouz NematiPour

DEN-2236_UI100%CoverageoftheApplicationSoftware

Options
    • -3
    • +3
    ./unittest.sh
Wednesday 08 Apr 2020
2:59 pm

Dara Navaei

Modified the address in the function that checks the results

Options
    • -1
    • +1
    ./unittest.sh
2:52 pm

Dara Navaei

Added code to check the results of the tests

Options
    • -5
    • +35
    ./unittest.sh
Monday 06 Apr 2020
4:38 am

Behrouz NematiPour

DEN-2236 : UI 100% Coverage of the Application Software

- Modified the unittest.sh script to read list of the unit tests from a file named :

tst_names.lst

- In this way script doesn't need to be changed and only name of the test will be added to the tst_names.lst file.

Options
    • -142
    • +272
    ./unittest.sh
  2. … 1 more file in changeset.
Wednesday 11 Mar 2020
11:24 pm

Behrouz NematiPour

Updated the unittest.sh to run the logger test first

- Moved logger test first since the other tests adding logs into the logs so the logger test will fail.

Options
    • -9
    • +10
    ./unittest.sh
Tuesday 21 Jan 2020
7:16 pm

Behrouz NematiPour

DEN-1714 : Implementation

- Added new tst_acknow unit test.

Options
    • -2
    • +10
    ./unittest.sh
Wednesday 15 Jan 2020
6:42 pm

Behrouz NematiPour

Merge branch 'master' into DEN-1396_LogHandler

Options
    • -2
    • +2
    ./unittest.sh
Thursday 09 Jan 2020
12:13 pm

Behrouz NematiPour

Changed the address of the shared drive to the newest address

- As part of the modification Dara had done on scripts this script was missing.

Options
    • -2
    • +2
    ./unittest.sh
Wednesday 08 Jan 2020
11:41 pm

Behrouz NematiPour

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added a unit test project for miscellaneous test which is not covered on feature based unit tests.

Options
    • -0
    • +8
    ./unittest.sh
3:38 am

Behrouz NematiPour

DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added tst_logging

Options
    • -5
    • +19
    ./unittest.sh
Thursday 26 Dec 2019
8:55 pm

Behrouz NematiPour

DEN-1090 : UI Message Handler / Error Handler

- updated the unit test project name

- added a can sender which reads CAN file and send it over the CAN Bus line by line.

Options
    • -1
    • +1
    ./unittest.sh
  2. … 1 more file in changeset.
Monday 25 Nov 2019
12:47 am

Behrouz NematiPour

Added error result for QtTest

Options
    • -5
    • +7
    ./unittest.sh
12:09 am

Behrouz NematiPour

Give Squish Coco g++ wrapper the first priority

Options
    • -2
    • +2
    ./unittest.sh
Sunday 24 Nov 2019
11:19 pm

Behrouz NematiPour

QtTest run fix

Options
    • -2
    • +2
    ./unittest.sh
11:08 pm

Behrouz NematiPour

Fixed the QtTest UnitTest out files path

- Also added more logging

Options
    • -4
    • +5
    ./unittest.sh