leahi-testsuites

Clone Tools

Stats

Commits this week: 10
Total Committers: 5
Last Commit: 31 Dec 69
Commits this week: 10

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
45 mins ago

Nicholas Ramirez

i agree lets use the definitions in td_defs as these are the most updated ones and use TDTreaRinsebackStates.RINSEBACK_STOP_INIT_STATE.value

i agree lets use the definitions in td_defs as these are the most updated ones and use TDTreaRinsebackStates.RINSEBACK_STOP_INIT_STATE.value

Wednesday 24 Jun
7:32 pm

Behrouz NematiPour

The states that need .value come from the td_defs that inherit from DialinEnum, and the ones that don't have .value come from the ui_defs, which are simple classes, so they don't need .value since ...

The states that need .value come from the td_defs that inherit from DialinEnum, and the ones that don't have .value come from the ui_defs, which are simple classes, so they don't need .value since those do not support metadata.
The UI_defs seem to be what I think aren't maintained anymore and last time updated was the 21 months ago.

Anything we want shall be available in the td_defs.
as an example:

# TDTreatmentStates.TREATMENT_RINSEBACK_STATE sub states
@unique
class TDTreaRinsebackStates(DialinEnum):
    RINSEBACK_STOP_INIT_STATE           = 0                     # Start state (stopped) of the rinseback sub-mode state machine
    RINSEBACK_RUN_STATE                 = 1                     # Rinseback running state of the rinseback sub-mode state machine
    RINSEBACK_PAUSED_STATE              = 2                     # Rinseback paused state of the rinseback sub-mode state machine
    RINSEBACK_STOP_STATE                = 3                     # Rinseback stopped (done) state of the rinseback sub-mode state machine
    RINSEBACK_RUN_ADDITIONAL_STATE      = 4                     # Additional rinseback volume (10 mL) state of the rinseback sub-mode state machine
    RINSEBACK_RECONNECT_PATIENT_STATE   = 5                     # Rinseback patient reconnect state of the rinseback sub-mode state machine
    NUM_OF_RINSEBACK_STATES             = 6                     # Number of rinseback sub-mode states


We should follow the same rule in the simulators and plugins.

Nicholas Ramirez I still need your feedback and correct me if I am wrong.

6:23 pm

Behrouz NematiPour

Nicholas Ramirez Please investigate the Dial-In code.

Nicholas Ramirez Please investigate the Dial-In code.

6:22 pm

Behrouz NematiPour

Oh, what is the interval of the lambda call? I have never used it this way. Not sure if that is a good or bad idea. Did we check the performance, or if it blocks the test? Nicholas Ramirez Resolve ...

Oh, what is the interval of the lambda call?
I have never used it this way.
Not sure if that is a good or bad idea.
Did we check the performance, or if it blocks the test?
Nicholas Ramirez Resolve if you are fine with the implementation.

5:08 pm

Behrouz NematiPour

RESOLVED

RESOLVED

2:19 pm

Behrouz NematiPour

Thank you for the details. I will leave this to Nicholas Ramirez to decide, and let's discuss if needed. We need to implement a Rejection reason test case and test all the reason IDs passed and the...

Thank you for the details.
I will leave this to Nicholas Ramirez to decide, and let's discuss if needed.
We need to implement a Rejection reason test case and test all the reason IDs passed and the mapped texts displayed to the user in every situation.

RESOLVED.

11:10 am

Behrouz NematiPour

same as: https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-3153-1#c29805

same as:
https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-3153-1#c29805

10:57 am

Behrouz NematiPour

remove the Path.home() and use the /home/denali/ On the device, it is not even in the home folder, so the path will be entirely different. on the VM: conf_path = "/home/denali/Public/luis/config/c...

remove the Path.home() and use the /home/denali/
On the device, it is not even in the home folder, so the path will be entirely different.

on the VM:

conf_path = "/home/denali/Public/luis/config/configurations/" + Alarms/Rejections.conf

on the device, there MAY be something like this:

conf_path = "/opt/leahi/config/configurations/" + Alarms/Rejections.conf
Monday 22 Jun
6:47 am

Vendor - TEL - Divya Sree Nidamamidi

I am allowing a tolerance of 2 seconds between the expected time and the UI-displayed time.

I am allowing a tolerance of 2 seconds between the expected time and the UI-displayed time.

12:44 am

Vendor - TEL - Divya Sree Nidamamidi

Added to suite conf

Added to suite conf

Thursday 18 Jun
11:59 pm

Vendor - TEL - Divya Sree Nidamamidi

Added the waitForObject while navigating to the pages

Added the waitForObject while navigating to the pages

11:56 pm

Vendor - TEL - Divya Sree Nidamamidi

Added 60 second snooze

Added 60 second snooze

8:42 am

Nicholas Ramirez

can we remove this and test adding a timeout to mouseClick(waitForObject(hdf)) on line 67 where we actually press the hdf option

can we remove this and test adding a timeout to mouseClick(waitForObject(hdf)) on line 67 where we actually press the hdf option

8:40 am

Nicholas Ramirez

we may just need 60 seconds to plot a line can we update to 60 and check if that works

we may just need 60 seconds to plot a line can we update to 60 and check if that works

1:09 am

Vendor - TEL - Divya Sree Nidamamidi

To genarate the graph it will take time so added wait here

To genarate the graph it will take time so added wait here

1:06 am

Vendor - TEL - Divya Sree Nidamamidi

Changing to treatement mode HDF option is not displaying in the UI so added wait

Changing to treatement mode HDF option is not displaying in the UI so added wait

12:18 am

Vendor - TEL - Divya Sree Nidamamidi

Stepnames variable is the list of objects (i.e concentrate,Installation,self tests) Standard and advanced mode differ by getting the value from the system.conf file

Stepnames variable is the list of objects (i.e concentrate,Installation,self tests)

Standard and advanced mode differ by getting the value from the system.conf file

Wednesday 17 Jun
2:45 pm

Nicholas Ramirez

we can make a function to just def rinsebackrequest_Check(): return rinsebackrequest == 8 if this works better? but well have alot more functions elsewhere. Let us know Behrouz NematiPour but the...

we can make a function to just

def rinsebackrequest_Check():
return rinsebackrequest == 8

if this works better? but well have alot more functions elsewhere. Let us know Behrouz NematiPour but the majority of the test cases do indeed use the lambda

2:43 pm

Nicholas Ramirez

we the lamba because we are using the waitFor() to wait for this condition to be true. waitFor() calls the lambda multiple times until it returns True or the timeout expires.

we the lamba because we are using the waitFor() to wait for this condition to be true.

waitFor() calls the lambda multiple times until it returns True or the timeout expires.

2:38 pm

Nicholas Ramirez

please add report to JIRA ticket

please add report to JIRA ticket

2:36 pm

Nicholas Ramirez

is this the same as o_confirmButton_ConfirmButton ?

is this the same as o_confirmButton_ConfirmButton ?

2:14 pm

Behrouz NematiPour

Thanks for providing the definition of the lambda. https://devapps.diality.us/static/s73b8n/2static/images/wiki/icons/emoticons/biggrin.gif My main question is, why lambda? What is that condition i...

Thanks for providing the definition of the lambda.
My main question is, why lambda?
What is that condition in this lambda (what is rinsebackrequest == 8)?
If that has a common use case, better to be a function?

2:10 pm

Behrouz NematiPour

Nicholas Ramirez Could you please check why that is, what the difference is between the two, and whether there are any inconveniences with Dial-In we need to take care of?

Nicholas Ramirez Could you please check why that is, what the difference is between the two, and whether there are any inconveniences with Dial-In we need to take care of?

2:07 pm

Behrouz NematiPour

Does this work? Have you tested it? It seems like while all are using equal, they should overwrite the previous one. It is just a preference; if you can't find a way, that's fine to leave it as it...

Does this work?
Have you tested it?
It seems like while all are using equal, they should overwrite the previous one.

It is just a preference; if you can't find a way, that's fine to leave it as it was.

Tuesday 16 Jun
3:02 pm

Behrouz NematiPour

What is 2? What was 1?

What is 2?
What was 1?

3:32 am

Vendor - TEL - Divya Sree Nidamamidi

Added the variable for the path

Added the variable for the path

3:17 am

Vendor - TEL - Divya Sree Nidamamidi

Getting the text from rejection.conf

Getting the text from rejection.conf

3:15 am

Vendor - TEL - Divya Sree Nidamamidi

Added for different test case for this test case it is not used

Added for different test case for this test case it is not used

3:13 am

Vendor - TEL - Divya Sree Nidamamidi

We have one parent object, and different values are defined by different ID by using findObjectByID

We have one parent object, and different values are defined by different ID by using findObjectByID

2:21 am

Vendor - TEL - Divya Sree Nidamamidi

Lambda is used here to pass a condition as a function that can be evaluated repeatedly without writing a full function definition.

Lambda is used here to pass a condition as a function that can be evaluated repeatedly without writing a full function definition.