Activity leahi-application/sources/gui/qml/pages/treatment/sections/TreatmentVitals.qml

3:47 pm

Behrouz NematiPour and Stephen Quong

More
LEAHI-APPLICATION-LDT-2264-1
finished reviewing

2:53 pm

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-2264-1
commented on review

Change totalCount to a read only property?

2:37 pm

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-2264-1
commented on review

VTreatmentAdjustmentVitals.cpp

11:38 am

Nicholas Ramirez

Updated and added part for measure vitals button on popup

11:00 am

Nicholas Ramirez

moved to TreatmentAdjustmentVitals.qml and make a placeholder component in ModalDIalog to fill when needed

9:41 am

This file does not have any accept/ reject response from FW as this only broadcasts the vitals data so it has been updated to no longer inherit VAdjustmentResponseBase. VTreatmentAdjustmentVitals.c...

This file does not have any accept/ reject response from FW as this only broadcasts the vitals data so it has been updated to no longer inherit VAdjustmentResponseBase. VTreatmentAdjustmentVitals.cpp/h was created to inherit VAdjustmentResponseBase and has all this when requesting the vitals data

7:57 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-2264-1
commented on review

Lets discuss and remove the NumPad from the ModalDialog that is the parent of many other dialogs which do not need NumPad. In this case it should be in the TreatmentAdjustmentVitals.qml

Lets discuss and remove the NumPad from the ModalDialog that is the parent of many other dialogs which do not need NumPad.
In this case it should be in the TreatmentAdjustmentVitals.qml

7:34 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-2264-1
commented on review

Use ACTION_VIEW_CONNECTION instead, to be consistent, since it is directly connected to the _GuiController.

7:23 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-2264-1
commented on review

Always keep the adjustment Trigger property for the messages you receive. The goal is to notify the UI when all the properties are set after receiving the message, which, on binding, is triggered o...

Always keep the adjustment Trigger property for the messages you receive.
The goal is to notify the UI when all the properties are set after receiving the message, which, on binding, is triggered one by one when assigned and if changed.

5:53 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-2264-1
commented on review

1) What are the actions for the: *ACT: SW =>UI *ACT: SW<= UI after the interval expiration? Do we have any notifications or updates on the UI from the SW? I think there should be only one SW->SW....

1) What are the actions for the:

ACT: SW =>UI
ACT: SW<= UI
after the interval expiration?
Do we have any notifications or updates on the UI from the SW?
I think there should be only one SW->SW.

2) Changing the expiration to "time out" makes more sense.

3) Vitals (Manujal), TCH: ... integreated (typo) ....

10:57 am