Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
BN approves

BN approves

BN approves

BN approves

BN approves

BN approves

BN approvees

BN approvees

BN approves

BN approves

Added the function for device and VM home_dir = str(Path.home()) if home_dir == "/home/denali": return "/home/denali/Public/luis/config/configurations/" else: return "/opt/leahi/config/configurati...

Added the function for device and VM

home_dir = str(Path.home())
if home_dir == "/home/denali":
return "/home/denali/Public/luis/config/configurations/"
else:
return "/opt/leahi/config/configurations/"

rejection.conf file is available in /home/denali/Public/luis/config/configurations/Alarms/Rejections.conf in this path

rejection.conf file is available in /home/denali/Public/luis/config/configurations/Alarms/Rejections.conf in this path

where is the rejection.conf? I don't see that in the CR.

where is the rejection.conf?
I don't see that in the CR.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Same as the previous comments I wrote to make it compatible with the device and the VM, the base folders are different, and it's not always on the HOME.

Same as the previous comments I wrote to make it compatible with the device and the VM, the base folders are different, and it's not always on the HOME.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Now added function that return configuration folder path def configuration_folder_path(): """ Check for Path.home() is /home/denali then return configuration folder location else return Device conf...

Now added function that return configuration folder path
def configuration_folder_path():
"""
Check for Path.home() is /home/denali then return configuration folder location
else return Device configuration folder location
"""
home_dir = str(Path.home())
if home_dir == "/home/denali":
return "/home/denali/Public/luis/config/configurations/"
else:
return "/opt/leahi/config/configurations/"

Now added function that return configuration folder path def configuration_folder_path(): """ Check for Path.home() is /home/denali then return configuration folder location else return Device conf...

Now added function that return configuration folder path
def configuration_folder_path():
"""
Check for Path.home() is /home/denali then return configuration folder location
else return Device configuration folder location
"""
home_dir = str(Path.home())
if home_dir == "/home/denali":
return "/home/denali/Public/luis/config/configurations/"
else:
return "/opt/leahi/config/configurations/"

Updated the test script with TDTreaRinsebackStates

Updated the test script with TDTreaRinsebackStates

As per suggestion using TDTreaRinsebackStates in test script

As per suggestion using TDTreaRinsebackStates in test script

I have updated the step by getting the value from rejections.conf file. For all the rejections message we will create new test script

I have updated the step by getting the value from rejections.conf file. For all the rejections message we will create new test script

i am good with the implementaiton

i am good with the implementaiton

i agree lets use the definitions in td_defs as these are the most updated ones and use TDTreaRinsebackStates.RINSEBACK_STOP_INIT_STATE.value

i agree lets use the definitions in td_defs as these are the most updated ones and use TDTreaRinsebackStates.RINSEBACK_STOP_INIT_STATE.value

The states that need .value come from the td_defs that inherit from DialinEnum, and the ones that don't have .value come from the ui_defs, which are simple classes, so they don't need .value since ...

The states that need .value come from the td_defs that inherit from DialinEnum, and the ones that don't have .value come from the ui_defs, which are simple classes, so they don't need .value since those do not support metadata.
The UI_defs seem to be what I think aren't maintained anymore and last time updated was the 21 months ago.

Anything we want shall be available in the td_defs.
as an example:

# TDTreatmentStates.TREATMENT_RINSEBACK_STATE sub states
@unique
class TDTreaRinsebackStates(DialinEnum):
    RINSEBACK_STOP_INIT_STATE           = 0                     # Start state (stopped) of the rinseback sub-mode state machine
    RINSEBACK_RUN_STATE                 = 1                     # Rinseback running state of the rinseback sub-mode state machine
    RINSEBACK_PAUSED_STATE              = 2                     # Rinseback paused state of the rinseback sub-mode state machine
    RINSEBACK_STOP_STATE                = 3                     # Rinseback stopped (done) state of the rinseback sub-mode state machine
    RINSEBACK_RUN_ADDITIONAL_STATE      = 4                     # Additional rinseback volume (10 mL) state of the rinseback sub-mode state machine
    RINSEBACK_RECONNECT_PATIENT_STATE   = 5                     # Rinseback patient reconnect state of the rinseback sub-mode state machine
    NUM_OF_RINSEBACK_STATES             = 6                     # Number of rinseback sub-mode states


We should follow the same rule in the simulators and plugins.

Nicholas Ramirez I still need your feedback and correct me if I am wrong.