Activity leahi-application/sources/gui/qml/dialogs/LockDialog.qml

10:33 am

Dara Navaei

More
LEAHI-APPLICATION-LDT-3000-1
started review

LEAHI-APPLICATION-LDT-3000_End of Treatment - SW - 01 - R&I

2:28 pm

Stephen Quong and Behrouz NematiPour

More
LEAHI-APPLICATION-LDT-1516-1
finished reviewing

2:16 pm

Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-1516-1
started review

LEAHI-APPLICATION-LDT-1516_Feature/Ldt 1516 Headerbar Component

1:11 pm

Nicholas Ramirez

i removed the comment to be more clear

11:06 am

Nicholas Ramirez

yes i agree makes more sense that way of whats going on.. I moved this to where they are being instantiated

10:58 am

Stephen Quong

Sorry, yes you are correct, it is just using the defaults. Should the commented portion be removed though?

Sorry, yes you are correct, it is just using the defaults.
Should the commented portion be removed though?

10:55 am

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-1516-1
commented on review

Generally, any anchoring/positioning properties for the top level item should be set in the parent object where this object is being instantiated since any changes to these properties in the parent...

Generally, any anchoring/positioning properties for the top level item should be set in the parent object where this object is being instantiated since any changes to these properties in the parent will be overridden here and it may not be obvious that it is happening.

10:48 am

Nicholas Ramirez

this still does the affect. I believe if you leave the property animation empty it will animate all changes of whatever Behavior is on. Refer https://doc.qt.io/archives/qt-5.15/qml-qtquick-property...

this still does the affect. I believe if you leave the property animation empty it will animate all changes of whatever Behavior is on. Refer https://doc.qt.io/archives/qt-5.15/qml-qtquick-propertyanimation.html

10:46 am