Activity leahi-application/sources/gui/qml/pages

5:02 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-3757-1
started review

LEAHI-APPLICATION-LDT-3757_Rinseback - SW - 01 - Recirculate - R&I

8:17 pm

Behrouz NematiPour and Stephen Quong

More
LEAHI-APPLICATION-LDT-3698-1
finished reviewing

8:14 pm

Behrouz NematiPour and Stephen Quong

More
LEAHI-APPLICATION-LDT-3678-1
finished reviewing

3:39 pm

Nicholas Ramirez

More
db4320d
changed 1 file
feature/LDT-3656-New-Design-CreateRx, feature/LDT-3678-sw-misc-enhc-ultrafiltration and 2 more LEAHI-APPLICATION-LDT-3678-1

LDT-3683 SW Misc & Enhc - SW - 01 - New Design - Ultrafiltration - R&I - 05: DEV - Feature Implementation

ADDRESS CR COMMENTS

- -13
- +0
./treatment/adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml
- History
- Source
- Diff
./treatment/.../TreatmentAdjustmentUltrafiltrationConfirm.qml

3:23 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-3678-1
commented on review

remove

8:33 am

Nicholas Ramirez

i see i did add a property for descriptionText to move blood return specific strings like.. qsTr("Blood return will %1 be allowed in:").arg("<b>NOT</b>") to the outside

8:32 am

Nicholas Ramirez

More
4da7908
changed 5 files
feature/LDT-3656-New-Design-CreateRx, feature/LDT-3698-sw-misc-enhc-rinseback and 2 more LEAHI-APPLICATION-LDT-3698-1

LDT-3703 SW Misc & Enhc - SW - 01 - New Design - Rinseback - R&I - 05: DEV - Feature Implementation

address cr comments

- -1
- +2
./endtreatment/EndTreatmentBase.qml
- History
- Source
- Diff
./endtreatment/EndTreatmentBase.qml
- -3
- +1
./endtreatment/EndTreatmentRinsebackStack.qml
- History
- Source
- Diff
./endtreatment/EndTreatmentRinsebackStack.qml
- -0
- +1
./endtreatment/rinseback/EndTreatmentRinsebackInit.qml
- History
- Source
- Diff
./endtreatment/.../EndTreatmentRinsebackInit.qml
… 2 more files in changeset.

8:30 am

Nicholas Ramirez

I changed the name to extra button instead since its in a common file used throughout jsut incase we get another one of these dialogs with 3 button the name is more flexible.

8:27 am

Nicholas Ramirez

this state i believe is now obsolete or combined in the main blood return page as before it went to a separate saline page but now it goes back to this page according to caryn

8:23 am

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-3698-1
commented on review

to recirculate.

5:30 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-3698-1
commented on review

If the "additional" word is used for the recirculate, please update everywhere to recirculate. The additional is for extra blood return, and recirculation is just to recirculate the blood to preven...

If the "additional" word is used for the recirculate, please update everywhere to recirculate.
The additional is for extra blood return,
and recirculation is just to recirculate the blood to prevent clogging.

Please update in other files as well.

5:27 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-3698-1
commented on review

Let's discuss the changes made in this file. Since this is the base class, I am a little concerned about the Reinseback-specific logics added here. shouldn't be in the EndRinseback.... qml. This a...

Let's discuss the changes made in this file.
Since this is the base class, I am a little concerned about the Reinseback-specific logics added here.
shouldn't be in the EndRinseback.... qml.

This also being used for the recirculate.

5:25 pm