LDT-1440 - Ultrafiltration - R&I [Application]

Activity

LEAHI-APPLICATION-LDT-1440-1 83

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 7h 8m 57 Updated.
    Reviewer - Complete 1h 18m 21 RESOLVED
    Reviewer - 0% reviewed 0m    
    Reviewer - 9% reviewed 4m    
    Reviewer - Complete 1h 54m 5 Only expose property of component, not whole component.
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   10h 26m 83  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Stephen Quong

    Update TreatmentAdjustmentUltrafiltrationItem to prevent showing subscreens i...

    Update TreatmentAdjustmentUltrafiltrationItem to prevent showing subscreens if TreatmentHome is not visible.

    Stephen Quong

    Updated.

    Updated.

    Behrouz NematiPour

    RESOLVED

    RESOLVED

    Stephen Quong

    Remove Start Treatment button from home screen.

    Remove Start Treatment button from home screen.

    Stephen Quong

    Updated.

    Updated.

    Behrouz NematiPour

    RESOLVED

    RESOLVED

    /SDDs/MainTreatmentScreen.puml Changed
    Open in IDE #permalink
    /SDDs/TreatmentAdjustmentUltrafiltration.png Added 15
    Open in IDE #permalink
    /SDDs/TreatmentAdjustmentUltrafiltration.puml Added
    Open in IDE #permalink
    /SDDs/TreatmentAdjustmentUltrafiltrationLayout.png Added
    Open in IDE #permalink
    /SDDs/TreatmentAdjustmentUltrafiltrationLayout.puml Added
    Open in IDE #permalink
    /sources/canbus/MessageDispatcher.cpp Changed
    Open in IDE #permalink
    /sources/canbus/MessageGlobals.h Changed
    Open in IDE #permalink
    /sources/gui/qml/components/BackButton.qml Changed
    Open in IDE #permalink
    /sources/gui/.../components/CloseButton.qml Changed
    Open in IDE #permalink
    /sources/.../components/NotificationBarSmall.qml Changed 3
    Open in IDE #permalink
    /sources/gui/.../components/ProgressBar.qml Changed 3
    Open in IDE #permalink
    /sources/gui/.../components/ProgressBarEx.qml Changed 3
    Open in IDE #permalink
    /sources/gui/.../components/RangeMarker.qml Changed 3
    Open in IDE #permalink
    /sources/gui/qml/components/Slider.qml Changed 2
    Open in IDE #permalink
    /sources/.../components/SliderUfAdjustment.qml Deleted
    Open in IDE #permalink
    /sources/gui/.../components/StoppedSlider.qml Deleted 6
    Open in IDE #permalink
    /sources/gui/qml/components/TouchRect.qml Changed
    Open in IDE #permalink
    /sources/.../compounds/LabelUnitContainer.qml Deleted 3
    Open in IDE #permalink
    /sources/gui/.../compounds/StoppedSlider.qml Added
    Open in IDE #permalink
    /sources/.../compounds/TreatmentAdjustmentUltrafiltrationMetrics.qml Added
    Open in IDE #permalink
    /sources/gui/qml/globals/Colors.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/globals/Fonts.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/globals/Variables.qml Changed
    Open in IDE #permalink
    /sources/.../adjustments/TreatmentAdjustmentBase.qml Changed 3
    Open in IDE #permalink
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml Changed 3
    Open in IDE #permalink
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml Changed 6
    Open in IDE #permalink
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationMetrics.qml Deleted 3
    Open in IDE #permalink
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationPaused.qml Deleted
    Open in IDE #permalink
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationStart.qml Changed 3
    Open in IDE #permalink
    /sources/gui/.../sections/TreatmentSaline.qml Changed
    Open in IDE #permalink
    /sources/.../sections/TreatmentUltrafiltration.qml Changed
    Open in IDE #permalink
    /sources/gui/.../treatment/TreatmentStack.qml Changed
    Open in IDE #permalink
    /sources/.../treatment/TreatmentUltrafiltrationItem.qml Changed 9
    Open in IDE #permalink
    /sources/gui/qml/pages/MainHome.qml Changed
    Open in IDE #permalink
    /sources/gui/GuiGlobals.h Changed
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustRequests.h Changed 3
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.cpp Deleted
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h Deleted
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationEditResponse.cpp Deleted
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationEditResponse.h Deleted
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationStateResponse.cpp Deleted
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationStateResponse.h Deleted
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.cpp Added
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h Added
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationEditResponse.cpp Added
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationEditResponse.h Added
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationStateResponse.cpp Added
    Open in IDE #permalink
    /sources/.../treatment/MTreatmentAdjustUltrafiltrationStateResponse.h Added
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationConfirm.cpp Deleted
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationConfirm.h Deleted
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationEdit.cpp Deleted
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationEdit.h Deleted
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationState.cpp Deleted
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationState.h Deleted
    Open in IDE #permalink
    /sources/view/hd/data/VTreatmentRanges.cpp Changed 3
    Open in IDE #permalink
    /sources/view/hd/data/VTreatmentRanges.h Changed 3
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationConfirm.cpp Added
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationConfirm.h Added
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationEdit.cpp Added
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationEdit.h Added
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationState.cpp Added
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentAdjustmentUltrafiltrationState.h Added
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentUltrafiltrationData.cpp Changed
    Open in IDE #permalink
    /sources/.../treatment/VTreatmentUltrafiltrationData.h Changed
    Open in IDE #permalink
    /leahi.pro Changed
    Open in IDE #permalink
    /leahi.qrc Changed 3
    Open in IDE #permalink
    /images/Back.png Deleted
    Open in IDE #permalink
    /images/PauseDarkBlue.png Deleted
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time