LEAHI-APPLICATION-LDT-2666-1 LEAHI-APPLICATION-LDT-2666_Ultrafiltration - SW - 01 - Enhancement - No pause adjustment - R&I

open for 7 weeks

Author

Moderator

Reviewers

LEAHI-APPLICATION-LDT-2666_Ultrafiltration - SW - 01 - Enhancement - No pause...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 18

leahi-application 0
- Folder SDDs 0
  - File TreatmentAdjustmentUltrafiltrationLayout.png 0 Remove
  - File TreatmentAdjustmentUltrafiltrationLayout.puml 0 Remove
- Folder sources/gui/qml 0
  - Folder compounds 0
    - File LabelUnitContainer.qml 6 Remove
    - File StoppedSlider.qml 0 Remove
    - File TreatmentAdjustmentUltrafiltrationMetrics.qml 3 Remove
    - File ValueAdjuster.qml 0 Remove
  - Folder globals 0
    - File Fonts.qml 0 Remove
    - File Variables.qml 0 Remove
  - Folder pages 0
    - Folder pretreatment/create 0
      - File PreTreatmentCreateContent.qml 0 Remove
    - Folder treatment 0
      - Folder adjustments 0
        
        File TreatmentAdjustmentBase.qml 2 Remove
        
        File TreatmentAdjustmentUltrafiltration.qml 14 Remove
        
        File TreatmentAdjustmentUltrafiltrationConfirm.qml 4 Remove
        
        File TreatmentAdjustmentUltrafiltrationEdit.qml 6 Remove
        
        File TreatmentAdjustmentUltrafiltrationStart.qml 2 Remove
      - Folder sections 0
        
        File TreatmentUltrafiltration.qml 0 Remove
      - File TreatmentStack.qml 0 Remove
      - File TreatmentUltrafiltrationItem.qml 0 Remove
- File leahi.qrc 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Stephen Quong	Author & Moderator	1h 33m	36	Updated to use common height from Variables.qml
Nicholas Ramirez	Reviewer - Complete	38m
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 18% reviewed	0m
Behrouz NematiPour	Reviewer - Complete	42m	1	line 144 should have been removed as we discussed.
Dara Navaei	Reviewer - 0% reviewed	5m
Daniel Ho	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed
Total		3h	37

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/gui/.../compounds/StoppedSlider.qml Deleted

Click to load diff

/sources/.../treatment/TreatmentUltrafiltrationItem.qml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-2666-1

LEAHI-APPLICATION-LDT-2666_Ultrafiltration - SW - 01 - Enhancement - No pause...

LEAHI-APPLICATION-LDT-2666-1 37

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-APPLICATION-LDT-2666_Ultrafiltration - SW - 01 - Enhancement - No pause...

LEAHI-APPLICATION-LDT-2666-1 37

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time