LEAHI-APPLICATION-LDT-4747-1 LDT-4747: SW Integration - FP Diagnostics - Application

closed on 01 Jul

Author

Moderator

Reviewers

LDT-4747: SW Integration - FP Diagnostics - Application

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 18

leahi-application 0
- Folder sources 0
  - Folder canbus 0
    - File MessageGlobals.h 0 Remove
  - Folder gui 0
    - Folder qml/dialogs/diagnostics 0
      - File DiagnosticsDD.qml 3 Remove
      - File DiagnosticsFP.qml 3 Remove
      - File DiagnosticsTD.qml 0 Remove
    - File GuiGlobals.h 2 Remove
  - Folder model 0
    - Folder dg/data 0
      - File MDGAccelerometerData.h 0 Remove
    - Folder fp/data 0
      - File MFPFlowData.cpp 0 Remove
      - File MFPFlowData.h 0 Remove
      - File MFPPressuresData.cpp 0 Remove
      - File MFPPressuresData.h 0 Remove
      - File MFPTemperatureData.cpp 0 Remove
      - File MFPTemperatureData.h 0 Remove
  - Folder view/fp/data 0
    - File VFPFlowData.cpp 0 Remove
    - File VFPFlowData.h 0 Remove
    - File VFPPressuresData.cpp 0 Remove
    - File VFPPressuresData.h 0 Remove
    - File VFPTemperatureData.cpp 0 Remove
    - File VFPTemperatureData.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nicholas Ramirez	Author & Moderator	10m	7	BN Approves
Dara Navaei	Reviewer - 0% reviewed
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 0% reviewed
Stephen Quong	Reviewer - Complete	1m
Behrouz NematiPour	Reviewer - Complete	3m	1	Are all these valve messages the same message ID [0x1B]?
Tiffany Mejia	Reviewer - 0% reviewed	0m
Total		16m	8

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-4747-1

LDT-4747: SW Integration - FP Diagnostics - Application

LEAHI-APPLICATION-LDT-4747-1 8

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LDT-4747: SW Integration - FP Diagnostics - Application

LEAHI-APPLICATION-LDT-4747-1 8

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time