LEAHI-APPLICATION-LDT-4852-1 LEAHI-APPLICATION-LDT-4852_SW Misc & Enhc - SW - 01 - Remove Old Messaging Logic [PowerOff].sh - R&I

closed on 10 Jul

Author

Moderator

Reviewers

LEAHI-APPLICATION-LDT-4852_SW Misc & Enhc - SW - 01 - Remove Old Messaging...

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 21

leahi-application 0
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
    - File MessageInterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder dialogs/diagnostics 0
        
        File DiagnosticsDD.qml 0 Remove
        
        File DiagnosticsFP.qml 0 Remove
        
        File DiagnosticsTD.qml 3 Remove
      - Folder pages/settings 0
        
        File SettingsStack.qml 0 Remove
      - File PowerItem.qml 0 Remove
    - File GuiController.cpp 6 Remove
    - File GuiController.h 0 Remove
    - File GuiGlobals.h 0 Remove
    - File GuiView.cpp 0 Remove
    - File GuiView.h 0 Remove
  - Folder model 0
    - Folder hd 0
      - Folder adjustment/treatment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
      - Folder alarm 0
        
        File MAlarmTriggered.cpp 0 Remove
        
        File MAlarmTriggered.h 0 Remove
    - File MModel.h 0 Remove
  - File ApplicationController.cpp 5 Remove
  - File ApplicationController.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nicholas Ramirez	Author & Moderator	1h 26m	17	BN approves
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 0% reviewed
Stephen Quong	Reviewer - 100% reviewed	1m
Behrouz NematiPour	Reviewer - Complete	0m
Dara Navaei	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed	0m
Total		1h 28m	17

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Nicholas Ramirez

add plugin for reading the checkin from UI/TD 1. Show SW -> FW checkin in som...

add plugin for reading the checkin from UI/TD
1. Show SW -> FW checkin in some list appending or count

make the checkin enabled manually in CAN.py handle_messages()

2. Show on SIM when SW is not running - SW/FW Commincaiton failure

On application
1. When SIM is killed app shows alarm 100

30 Jun

Nicholas Ramirez

Resolved

02 Jul

Nicholas Ramirez

will do in later branch

02 Jul

Nicholas Ramirez

BN approves

02 Jul

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-4852-1

LEAHI-APPLICATION-LDT-4852_SW Misc & Enhc - SW - 01 - Remove Old Messaging...

LEAHI-APPLICATION-LDT-4852-1 17

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Nicholas Ramirez

Nicholas Ramirez

Nicholas Ramirez

Log time

LEAHI-APPLICATION-LDT-4852_SW Misc & Enhc - SW - 01 - Remove Old Messaging...

LEAHI-APPLICATION-LDT-4852-1 17

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Nicholas Ramirez

Nicholas Ramirez

Nicholas Ramirez

Log time