UI-DEN-1434-1 UI-DEN-1434_InTreatment

closed on 13 Mar 20

Author

Moderator

Reviewers

UI-DEN-1434_InTreatment

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 106

application 0
- Folder scripts 0
  - File autostart 0 Remove
  - File copy.sh 0 Remove
  - File run.sh 6 Remove
  - File setup.sh 0 Remove
  - File setupSD.sh 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File caninterface.cpp 3 Remove
    - File caninterface.h 3 Remove
    - File frameinterface.cpp 0 Remove
    - File frameinterface.h 5 Remove
    - File messagebuilder.cpp 0 Remove
    - File messagedispatcher.cpp 6 Remove
    - File messagedispatcher.h 0 Remove
    - File messageglobals.h 0 Remove
    - File messageinterpreter.cpp 33 Remove
    - File messageinterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File Background.qml 0 Remove
        
        File Circle.qml 0 Remove
        
        File MainMenu.qml 0 Remove
        
        File ModalDialog.qml 0 Remove
        
        File ProgressBar.qml 0 Remove
        
        File ProgressCircle.qml 0 Remove
        
        File ProgressMarker.qml 0 Remove
        
        File ProgressRect.qml 0 Remove
        
        File RangeBar.qml 0 Remove
        
        File RangeMarker.qml 0 Remove
        
        File RangeRect.qml 0 Remove
        
        File TimeText.qml 0 Remove
        
        File TouchRect.qml 0 Remove
      - Folder dialogs 0
        
        File AutoHideInfo.qml 0 Remove
        
        File PowerOff.qml 0 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Fonts.qml 0 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        Folder sections 0
        
        File TreatmentFlows.qml 0 Remove
        
        File TreatmentFluid.qml 0 Remove
        
        File TreatmentInfusion.qml 0 Remove
        
        File TreatmentPressure.qml 0 Remove
        
        File TreatmentTime.qml 0 Remove
        
        File TreatmentUltrafiltration.qml 0 Remove
        
        File TreatmentVitals.qml 0 Remove
        
        File TreatmentCreate.qml 0 Remove
        
        File TreatmentHome.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentStart.qml 0 Remove
        
        File SettingsHome.qml 0 Remove
        
        File TreatmentCreate.qml 0 Remove
        
        File TreatmentHome.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentStart (test).qml 0 Remove
        
        File TreatmentStart.qml 0 Remove
      - File main.qml 0 Remove
    - Folder view 0
      - File valarmstatus.cpp 0 Remove
      - File valarmstatus.h 0 Remove
      - File vtreatmentflows.cpp 0 Remove
      - File vtreatmentflows.h 0 Remove
      - File vtreatmenttime.cpp 0 Remove
      - File vtreatmenttime.h 0 Remove
      - File vtreatmentultrafiltration.cpp 0 Remove
      - File vtreatmentultrafiltration.h 0 Remove
    - File guicontroller.cpp 0 Remove
    - File guicontroller.h 0 Remove
    - File guiglobals.cpp 0 Remove
    - File guiglobals.h 0 Remove
    - File guiview.cpp 0 Remove
    - File guiview.h 0 Remove
  - Folder model 0
    - File malarmstatus.cpp 0 Remove
    - File malarmstatus.h 0 Remove
    - File mmodel.h 0 Remove
    - File model.cpp 0 Remove
    - File model.h 0 Remove
    - File mpoweroff.cpp 0 Remove
    - File mpoweroff.h 0 Remove
    - File mtreatmentflows.cpp 0 Remove
    - File mtreatmentflows.h 0 Remove
    - File mtreatmentoutletflow.cpp 0 Remove
    - File mtreatmentoutletflow.h 0 Remove
    - File mtreatmenttime.cpp 0 Remove
    - File mtreatmenttime.h 0 Remove
  - Folder storage 0
    - File logger.cpp 0 Remove
    - File logger.h 0 Remove
    - File usbwatcher.cpp 0 Remove
  - Folder utility 0
    - File format.cpp 0 Remove
    - File types.h 5 Remove
  - Folder view 0
    - File valarmstatus.cpp 0 Remove
    - File valarmstatus.h 0 Remove
    - File vpoweroff.cpp 3 Remove
    - File vpoweroff.h 0 Remove
    - File vtreatmentbloodflow.cpp 0 Remove
    - File vtreatmentbloodflow.h 0 Remove
    - File vtreatmentdialysateflow.cpp 0 Remove
    - File vtreatmentdialysateflow.h 0 Remove
    - File vtreatmenttime.cpp 0 Remove
    - File vtreatmenttime.h 0 Remove
    - File vtreatmentultrafiltration.cpp 0 Remove
    - File vtreatmentultrafiltration.h 0 Remove
    - File vview.h 0 Remove
  - File applicationcontroller.cpp 12 Remove
  - File applicationcontroller.h 0 Remove
  - File main.h 0 Remove
  - File maintimer.cpp 0 Remove
- Folder unittests 0
  - File tst_logging.h 0 Remove
- File cpplint.py 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File main.cpp 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	3h 22m	38	RESOLVED
Dara Navaei	Reviewer - 37% reviewed	12m
pmontazemi (deleted user)	Reviewer - Complete	29m	35	RESOLVED.
plucia (deleted user)	Reviewer - Complete	1h 27m	3	RESOLVED
Total		5h 31m	76

Linked issues
- DEN-1434

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/gui/.../components/ProgressMarker.qml Deleted

Click to load diff

/sources/gui/qml/pages/TreatmentCreate.qml Deleted

Click to load diff

/sources/gui/qml/pages/TreatmentHome.qml Deleted

Click to load diff

/sources/gui/qml/pages/TreatmentStack.qml Deleted

Click to load diff

/sources/.../pages/TreatmentStart (test).qml Deleted

Click to load diff

/sources/gui/qml/pages/TreatmentStart.qml Deleted

Click to load diff

/sources/.../view/vtreatmentultrafiltration.cpp Deleted

Click to load diff

/sources/.../view/vtreatmentultrafiltration.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-1434-1

UI-DEN-1434_InTreatment

UI-DEN-1434-1 76

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-1434_InTreatment

UI-DEN-1434-1 76

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time