1. UI-DEN-3605

UI-DEN-3605-4

Tools
closed on 19 Oct 23
Author
Moderator
Reviewers

UI Create Treatment

Activity

UI-DEN-3605-4 383

Keyboard shortcuts  
    • Summarize the review outcomes (optional)
    Preview wiki syntax help
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    plucia  (deleted user)
    		Author & Moderator 12h 43m 133 I've updated it so the signal will only be called when th...
    Behrouz NematiPour
    Reviewer completed
    		Reviewer - Complete 13h 37m 156 RESOLVED. As we talked it should be changed to released(v...
    pmontazemi  (deleted user)
    Reviewer completed
    		Reviewer - Complete 1h 56m 91 RESOLVED.
    Total   28h 18m 383  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Behrouz NematiPour

    I see duplicate files names which should not be if the correct change sets ha...

    I see duplicate files names which should not be if the correct change sets have been chosen.
    I don't believe this code review is valid.
    Seems like Jira can't handle this correctly.

    plucia  (deleted user)

    Yes to remove the merged code from Logging2of3 I had to create a new review. ...

    Yes to remove the merged code from Logging2of3 I had to create a new review. I looked into removing the your merged code from the old review and Crucible doesn't really let you if you create the review from a branch.
    So, the duplication of files does appear to be a bug in Crucible. The process isn't perfect in either case, but I think I addressed and committed changes for all of your comments from the previous review. If I missed anything please let me know

    plucia  (deleted user)

    Here is a link to the crucible bug: https://jira.atlassian.com/browse/CRUC-68...

    Here is a link to the crucible bug: https://jira.atlassian.com/browse/CRUC-6806. Looking over it, it seems they are not planning on fixing it

    plucia  (deleted user)

    This code review was created on August 25. The design changes with MAbstract ...

    This code review was created on August 25.
    The design changes with MAbstract and MModel were merged to master on August 31st.
    Our process now discourages merging code between development branches, so the create treatment implementation doesn't incorporate the design changes that were first merged to master on August 31st.
    As per Behrouz's and my conversation yesterday, the work to subclass MAbstract and MModel is going to be tracked in this ticket next sprint. http://dvm-linux02:8080/browse/DEN-4981

    Behrouz NematiPour

    Please add the testsuites repository in this code review. It's always part of...

    Please add the testsuites repository in this code review.
    It's always part of the Code Review.

    plucia  (deleted user)

    Dara has created the review, it's available here: http://dvm-linux02:8060/cru...

    Dara has created the review, it's available here: http://dvm-linux02:8060/cru/TESTSUITES-DEN-3724-1
    and is linked to this review (see "Linked Reviews" above)

    Behrouz NematiPour

    RESOLVED.

    RESOLVED.

    Behrouz NematiPour

    Please put "done" when the code is pushed. When an email is sent to the revie...

    Please put "done" when the code is pushed.
    When an email is sent to the reviewer it is assumed that there is something to review but putting a "done" and "will be updated" is not something that can be reviewed.

    plucia  (deleted user)

    I don't know why, but crucible creates duplicate files sometimes. Please chec...

    I don't know why, but crucible creates duplicate files sometimes. Please check on the left hand pane and see the change(s) in the duplicate files.

    /resources/images/alarm.png Added
    Open in IDE #permalink
    /resources/images/bell-off.png Added
    Open in IDE #permalink
    /resources/images/bell.png Added
    Open in IDE #permalink
    /scripts/copy.sh Changed
    /sources/canbus/messageglobals.h Changed 3
    /sources/canbus/messageglobals.h Changed 3
    /sources/canbus/messageinterpreter.cpp Changed 29
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.h Changed 3
    /sources/canbus/messageinterpreter.h Changed 6
    /sources/gui/.../components/CircleWithText.qml Added 3
    /sources/.../components/NotificationBar.qml Changed
    /sources/gui/qml/components/RangeRect.qml Changed
    /sources/.../components/RectSelectCreateTreatment.qml Added 3
    /sources/gui/qml/components/Slider.qml Changed 5
    /sources/.../components/SliderCreateTreatment.qml Added 3
    /sources/.../components/SliderDoubleCreateTreatment.qml Added 3
    /sources/.../components/TopMenuBarCreateTreatment.qml Added 2
    /sources/gui/qml/components/TouchRect.qml Changed
    /sources/.../dialogs/NotificationDialog.qml Changed 3
    /sources/gui/qml/globals/Colors.qml Changed 6
    /sources/gui/qml/globals/Fonts.qml Changed
    /sources/gui/qml/globals/Variables.qml Changed
    /sources/gui/qml/globals/Variables.qml Changed 9
    /sources/gui/.../treatment/TreatmentBegin.qml Added 5
    /sources/.../treatment/TreatmentConfirm.qml Added 5
    /sources/gui/.../treatment/TreatmentCreate.qml Changed 38
    /sources/gui/.../treatment/TreatmentPrime.qml Added 30
    /sources/gui/.../treatment/TreatmentStack.qml Changed 3
    /sources/gui/.../treatment/TreatmentStack.qml Changed
    /sources/gui/qml/main.qml Changed 12
    /sources/gui/qml/main.qml Changed 3
    /sources/gui/guicontroller.cpp Changed
    /sources/gui/guicontroller.cpp Changed
    /sources/gui/guicontroller.h Changed 6
    /sources/gui/guicontroller.h Changed 6
    /sources/gui/guiglobals.cpp Changed
    /sources/gui/guiglobals.cpp Changed
    /sources/gui/guiglobals.h Changed
    Open in IDE #permalink
    /sources/gui/guiglobals.h Changed 6
    /sources/model/MModel.h Added
    /sources/model/MTreatmentParameters.cpp Added 11
    /sources/model/MTreatmentParameters.h Added 23
    /sources/model/MTreatmentParametersResp.cpp Added 4
    /sources/model/MTreatmentParametersResp.h Added 5
    /sources/model/mmodel.h Changed
    Open in IDE #permalink
    /sources/model/mtreatmentparameters.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentparameters.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentparametersresp.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentparametersresp.h Deleted 6
    Open in IDE #permalink
    /sources/storage/filehandler.cpp Changed
    Open in IDE #permalink
    /sources/storage/filehandler.h Changed 6
    Open in IDE #permalink
    /sources/storage/filehandler.h Changed 3
    /sources/storage/filesaver.cpp Added
    /sources/storage/filesaver.h Added 5
    /sources/storage/storageglobals.cpp Changed
    Open in IDE #permalink
    /sources/storage/storageglobals.cpp Changed 10
    /sources/storage/storageglobals.h Changed 3
    /sources/storage/storageglobals.h Changed
    /sources/view/VCreateTreatment.cpp Added 21
    /sources/view/VCreateTreatment.h Added 11
    /sources/view/vview.h Changed 3
    /sources/view/vview.h Changed 3
    /sources/applicationcontroller.cpp Changed 3
    Open in IDE #permalink
    /sources/applicationcontroller.cpp Changed
    /sources/applicationcontroller.h Changed 6
    Open in IDE #permalink
    /sources/applicationcontroller.h Changed 3
    /sources/main.h Changed 6
    /sources/main.h Changed
    /unittests/tst_messaging.cpp Changed
    /unittests/tst_messaging.h Changed 3
    /unittests/tst_models.cpp Changed 6
    /unittests/tst_models.h Changed
    /unittests/tst_views.cpp Changed 18
    /unittests/tst_views.h Changed 8
    /denali.pro Changed
    /denali.pro Changed 6
    /denali.pro.user Changed
    /denali.pro.user Changed
    /denali.qrc Changed 3
    /denali.qrc Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time