UI-DEN-4438-1 UI-DEN-4438_Saline Bolus

closed on 28 Aug 20

Author

Reviewers

UI-DEN-4438_Saline Bolus

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 85

application 0
- Folder resources/images 0
  - File microsd.png 0 Remove
- Folder scripts 0
  - File run.sh 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File caninterface.cpp 7 Remove
    - File frameinterface.cpp 4 Remove
    - File messagedispatcher.cpp 4 Remove
    - File messageglobals.h 4 Remove
    - File messageinterpreter.cpp 4 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File DebugDataColumn.qml 0 Remove
        
        File NotificationBarSmall.qml 0 Remove
      - Folder globals 0
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        Folder sections 0
        
        File TreatmentFluid.qml 0 Remove
        
        File TreatmentSaline.qml 0 Remove
        
        File TreatmentTime.qml 0 Remove
        
        File TreatmentUltrafiltration.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentStart.qml 0 Remove
        
        File ManagerHome.qml 0 Remove
        
        File SettingsHome.qml 0 Remove
      - File main.qml 0 Remove
    - File guicontroller.cpp 4 Remove
    - File guicontroller.h 10 Remove
    - File guiglobals.cpp 4 Remove
    - File guiglobals.h 7 Remove
    - File guiview.cpp 4 Remove
    - File guiview.h 8 Remove
  - Folder model 0
    - Folder hd 0
      - Folder adjustment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
        
        File MTreatmentAdjustSalineResponse.cpp 0 Remove
        
        File MTreatmentAdjustSalineResponse.h 3 Remove
        
        File MTreatmentAdjustUltrafiltrationStateResponse.h 0 Remove
      - Folder data 0
        
        File MTreatmentSalineData.cpp 0 Remove
        
        File MTreatmentSalineData.h 0 Remove
    - File MAbstract.cpp 3 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File DriveWatcher.cpp 0 Remove
    - File DriveWatcher.h 4 Remove
    - File filehandler.cpp 4 Remove
    - File filehandler.h 7 Remove
  - Folder view 0
    - Folder hd 0
      - Folder adjustment 0
        
        File VTreatmentAdjustmentSaline.cpp 0 Remove
        
        File VTreatmentAdjustmentSaline.h 5 Remove
      - Folder data 0
        
        File VHDOperationModeData.cpp 0 Remove
        
        File VHDOperationModeData.h 3 Remove
        
        File VHDTreatmentStatesData.cpp 0 Remove
        
        File VHDTreatmentStatesData.h 3 Remove
        
        File VTreatmentSalineData.cpp 0 Remove
        
        File VTreatmentSalineData.h 3 Remove
    - File VEventSpy.cpp 0 Remove
    - File VEventSpy.h 3 Remove
    - File VHDOperationModeData.cpp 0 Remove
    - File VHDOperationModeData.h 0 Remove
    - File VTreatmentAdjustmentSaline.cpp 0 Remove
    - File VTreatmentAdjustmentSaline.h 0 Remove
    - File VTreatmentSalineData.cpp 0 Remove
    - File VTreatmentSalineData.h 0 Remove
    - File valarmstatus.cpp 4 Remove
    - File vtreatmentadjustmentresponsebase.h 7 Remove
    - File vtreatmentadjustmentultrafiltrationconfirm.h 7 Remove
    - File vview.h 0 Remove
  - File applicationcontroller.cpp 4 Remove
  - File applicationcontroller.h 7 Remove
- Folder unittests 0
  - File tst_messaging.cpp 3 Remove
  - File tst_messaging.h 6 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.h 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 3 Remove
- Folder simulator 0
  - File SalineBolusSimulator.ui 0 Remove
  - File run.py 0 Remove
  - File run.sh 0 Remove
- Folder tst_AlarmStatusData 0
  - File test.py 0 Remove
- Folder tst_CANBusFaultCount 0
  - File test.py 0 Remove
- Folder tst_HDBloodFlowData 0
  - File test.py 0 Remove
- Folder tst_HDInletFlowData 0
  - File test.py 0 Remove
- Folder tst_HDOperationModeData 0
  - File test.py 0 Remove
- Folder tst_HDOutletFlowData 0
  - File test.py 0 Remove
- Folder tst_HDPressureOcclusionData 0
  - File test.py 0 Remove
- Folder tst_Internals 0
  - File test.py 0 Remove
- Folder tst_TreatmentSalineData 0
  - File test.py 0 Remove
- Folder tst_TreatmentScreen 0
  - File test.py 0 Remove
- Folder tst_TreatmentStatesData 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Saline 0
  - File test.py 0 Remove
- File suite.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	1h 50m	43	done
plucia (deleted user)	Reviewer - Complete	41m	2	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	49m	97	RESOLVED.
Total		3h 21m	142

Linked issues
- DEN-4438

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

plucia (deleted user)

Non-production code has been added to the manager home and settings screens. ...

Non-production code has been added to the manager home and settings screens. Should this reside on the production master branch?
Also, why is non-production code being unit tested?

25 Aug 20

plucia

(deleted user)

Resolved

27 Aug 20

plucia (deleted user)

RESOLVED

27 Aug 20

Behrouz NematiPour

The representation of the data is not the way it's going to be on production ...

The representation of the data is not the way it's going to be on production but the code that is being code reviewed and doing code coverage on it, is.
All those codes will be logged, in the production code.

25 Aug 20

Click to load diff

/sources/view/VTreatmentAdjustmentSaline.cpp Deleted

Click to load diff

/sources/view/VTreatmentAdjustmentSaline.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-4438-1

UI-DEN-4438_Saline Bolus

UI-DEN-4438-1 142

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

plucia (deleted user)

Behrouz NematiPour

Log time

UI-DEN-4438_Saline Bolus

UI-DEN-4438-1 142

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

plucia (deleted user)

Behrouz NematiPour

Log time