UI-DEN-8514-2 UI-DEN-8514_UI DEV Alarms Active List Merge Setting

closed on 02 Jul 21

Author

Reviewers

UI-DEN-8514_UI DEV Alarms Active List Merge Setting

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 151

application 0
- Folder scripts 0
  - File brightness_get.sh 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File CanInterface.cpp 0 Remove
    - File FrameInterface.cpp 0 Remove
    - File MessageBuilder.cpp 0 Remove
    - File MessageBuilder.h 0 Remove
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
    - File DeviceController.h 0 Remove
    - File DeviceError.cpp 0 Remove
    - File DeviceError.h 0 Remove
    - File DeviceGlobals.h 0 Remove
    - File DeviceModels.cpp 0 Remove
    - File DeviceModels.h 0 Remove
    - File DeviceView.cpp 0 Remove
    - File DeviceView.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File Slider.qml 0 Remove
        
        File UpDownButton.qml 0 Remove
      - Folder compounds 0
        
        File TouchGrid.qml 0 Remove
      - Folder dialogs 0
        
        File AlarmListDialog.qml 0 Remove
        
        File NotificationDialog.qml 0 Remove
      - Folder pages 0
        
        Folder disinfect 0
        
        File DisinfectStack.qml 0 Remove
        
        Folder posttreatment 0
        
        File PostTreatmentReview.qml 0 Remove
        
        Folder settings 0
        
        File SettingsStack.qml 0 Remove
        
        File SettingsVolumeBrightness.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File SDItem.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 0 Remove
    - File GuiController.h 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
    - File GuiView.cpp 0 Remove
    - File GuiView.h 0 Remove
  - Folder model 0
    - Folder dg/adjustment/settings 0
      - File MAdjustDGRequests.h 0 Remove
      - File MAdjustDGSerialNumberResponse.cpp 0 Remove
      - File MAdjustDGSerialNumberResponse.h 0 Remove
      - File MAdjustDGServiceResponse.cpp 0 Remove
      - File MAdjustDGServiceResponse.h 0 Remove
      - File MAdjustDGVersionsResponse.cpp 0 Remove
      - File MAdjustDGVersionsResponse.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder settings 0
        
        File MAdjustHDRequests.h 0 Remove
        
        File MAdjustHDSerialNumberResponse.cpp 0 Remove
        
        File MAdjustHDSerialNumberResponse.h 0 Remove
        
        File MAdjustHDServiceResponse.cpp 0 Remove
        
        File MAdjustHDServiceResponse.h 0 Remove
        
        File MAdjustHDVersionsResponse.cpp 0 Remove
        
        File MAdjustHDVersionsResponse.h 0 Remove
        
        Folder treatment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
      - Folder alarm 0
        
        File MAlarmActiveList.cpp 0 Remove
        
        File MAlarmMapping.cpp 0 Remove
    - File MAbstract.cpp 0 Remove
    - File MAbstract.h 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File DriveWatcher.cpp 0 Remove
    - File DriveWatcher.h 0 Remove
    - File FileSaver.cpp 0 Remove
    - File FileSaver.h 0 Remove
    - File Logger.cpp 0 Remove
    - File Logger.h 0 Remove
    - File Settings.cpp 0 Remove
    - File Settings.h 0 Remove
    - File StorageGlobals.cpp 0 Remove
    - File StorageGlobals.h 0 Remove
    - File TreatmentLog.cpp 0 Remove
    - File TreatmentLog.h 0 Remove
  - Folder utility 0
    - File format.cpp 0 Remove
    - File format.h 0 Remove
  - Folder view 0
    - Folder dg/data/disinfect 0
      - File VDisinfectStatesData.cpp 0 Remove
      - File VDisinfectStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment/disinfect 0
        
        File VDisinfectAdjustDisinfect.cpp 0 Remove
      - Folder alarm 0
        
        File VAlarmStatus.cpp 0 Remove
        
        File VAlarmStatus.h 0 Remove
    - Folder settings 0
      - File VAdjustmentAlarmVolume.cpp 0 Remove
      - File VAdjustmentAlarmVolume.h 0 Remove
      - File VAdjustmentService.cpp 0 Remove
      - File VAdjustmentService.h 0 Remove
      - File VAdjustmentVersions.cpp 0 Remove
      - File VAdjustmentVersions.h 0 Remove
    - File VEventSpy.cpp 0 Remove
    - File VEventSpy.h 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VView.h 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File Threads.cpp 0 Remove
  - File Threads.h 0 Remove
  - File main.h 0 Remove
- Folder unittests 0
  - File tst_initializations.cpp 0 Remove
  - File tst_initializations.h 0 Remove
  - File tst_threads.cpp 0 Remove
- File alarmMapping 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File en_US.udic 0 Remove
- File main.cpp 0 Remove
testsuites 0
- Folder simulator 0
  - Folder plugins 0
    - Folder GeneralProgressMessage 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder GeneralResponseMessage 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder HDOpMode 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder PostTreatment 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder __poweroff 0
      - File loader.py 0 Remove
    - Folder accelerometer 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder alarms 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder bloodPrime 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder createtreatment 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder disinfection 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder disinfectionstates 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder disposablesPrime 0
      - File loader.py 0 Remove
    - Folder filterFlush 0
      - File loader.py 0 Remove
    - Folder generalProgressMessage 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder generalResponseMessage 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder hdOpMode 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder heparin 0
      - File loader.py 0 Remove
    - Folder inlinebloodpressures 0
      - File loader.py 0 Remove
    - Folder postTreatment 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder pretreatmentstates 0
      - File loader.py 0 Remove
    - Folder recirculate 0
      - File loader.py 0 Remove
    - Folder rinseback 0
      - File loader.py 0 Remove
    - Folder salinebolus 0
      - File loader.py 0 Remove
    - Folder selftestDry 0
      - File loader.py 0 Remove
    - Folder selftestNoCartridge 0
      - File loader.py 0 Remove
    - Folder treatmentend 0
      - File loader.py 0 Remove
    - Folder treatmentranges 0
      - File loader.py 0 Remove
    - Folder treatmentstates 0
      - File loader.py 0 Remove
    - Folder ultrafiltration 0
      - File loader.py 0 Remove
    - Folder version 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
  - Folder simulator 0
    - File dynamicloader.py 0 Remove
    - File interface.py 0 Remove
    - File loader.py 0 Remove
    - File simulator.py 0 Remove
  - File run.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Behrouz NematiPour	Author	1m
plucia (deleted user)	Reviewer - Complete	20m
pmontazemi (deleted user)	Reviewer - Complete	32m
Total		54m	0

Linked issues
- DEN-8523
- DEN-8533
- DEN-8693
- DEN-8910

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/simulator/.../GeneralProgressMessage/interface.ui Deleted

Click to load diff

/simulator/.../GeneralProgressMessage/loader.py Deleted

Click to load diff

/simulator/.../GeneralResponseMessage/interface.ui Deleted

Click to load diff

/simulator/.../GeneralResponseMessage/loader.py Deleted

Click to load diff

/simulator/plugins/HDOpMode/interface.ui Deleted

Click to load diff

/simulator/.../PostTreatment/interface.ui Deleted

Click to load diff

/simulator/plugins/PostTreatment/loader.py Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-8514-2

UI-DEN-8514_UI DEV Alarms Active List Merge Setting

UI-DEN-8514-2 0

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-8514_UI DEV Alarms Active List Merge Setting

UI-DEN-8514-2 0

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time