CLOUDSYNC-DEN-16690

RESOLVED on behalf of Behrouz NematiPour

RESOLVED on behalf of Behrouz NematiPour

CLOUDSYNC-DEN-16690_UI MG S117
CLOUDSYNC-DEN-16690_UI MG S117
RESOLVED

RESOLVED

Merge branch 'DEN-16690-UI-MG-S117' into DEN-16839-UI-BN-Whitney-1B1 c88f546ad09c2d6c0222d8e694a9814e37a424ea The follow up CR would be http://devapps.diality.us:8060/cru/CLOUDSYNC-DEN-16839-1 Will...

Merge branch 'DEN-16690-UI-MG-S117' into DEN-16839-UI-BN-Whitney-1B1
c88f546ad09c2d6c0222d8e694a9814e37a424ea
The follow up CR would be http://devapps.diality.us:8060/cru/CLOUDSYNC-DEN-16839-1
Will be closed.

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function. Please consider for later improvements. RESOLVED.

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function.
Please consider for later improvements.

RESOLVED.

a catchall exception is not a good idea, please separate the split() and [0], and first check the index exists, the use it. it is good to keep it if the process fails, but incorrect/unexpected resu...

a catchall exception is not a good idea, please separate the split() and [0], and first check the index exists, the use it.
it is good to keep it if the process fails, but incorrect/unexpected result is not being caught.

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function. Please consider for later improvements. RESILVED.

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function.
Please consider for later improvements.

RESILVED.

The exception handling was redundant since the message handler will catch it in ui_cs_request_handler.py and log it as CS_LOG_ROTATION_ERROR. Added check for split() length and if it fails, it'll ...

The exception handling was redundant since the message handler will catch it in ui_cs_request_handler.py and log it as CS_LOG_ROTATION_ERROR.

Added check for split() length and if it fails, it'll write to the gutils logger that the subprocess call failed in the chance that subprocess.check_output succeeds but doesn't not contain any data.

RESOLVED

RESOLVED

line 507 has the reassignment if we find that sd_used_bytes is 0

line 507 has the reassignment if we find that sd_used_bytes is 0

RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

added exception handling for when the subprocess call fails. thanks

added exception handling for when the subprocess call fails. thanks

added exception handling for when the subprocess call fails. thanks

added exception handling for when the subprocess call fails. thanks

that is the point. what if the du command is not successful? there could be cases that the du call is fine from the python perspective but the result is not a successful or expected result. therefo...

that is the point. what if the du command is not successful?
there could be cases that the du call is fine from the python perspective but the result is not a successful or expected result.
therefore avoid getting the indexes from array unless you definitely know there is the index.

does split() always have index 0 ? [index out of bounds]

does split() always have index 0 ?
[index out of bounds]

same here for split? [index out of bounds]

same here for split?
[index out of bounds]

please push the code to resolve

please push the code to resolve

Please push the fix so it can be resolved.

Please push the fix so it can be resolved.

fixed. thanks!

fixed. thanks!

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

fixed. thanks!

fixed. thanks!

Not that i found that wasnt third party. shutil helps us find the sd card size, but it cant do directory sizes

Not that i found that wasnt third party. shutil helps us find the sd card size, but it cant do directory sizes

where checked if the sd_used_bytes is zero or not? [Divide by zero]

where checked if the sd_used_bytes is zero or not?
[Divide by zero]