CLOUDSYNC-DEN-16690

CLOUDSYNC-DEN-16690

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,303
Last Commit: 20 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 05 Aug 2024
4:06 pm

Dara Navaei

4:06 pm

Dara Navaei

RESOLVED on behalf of Behrouz NematiPour

RESOLVED on behalf of Behrouz NematiPour

4:05 pm

Dara Navaei

CLOUDSYNC-DEN-16690_UI MG S117
CLOUDSYNC-DEN-16690_UI MG S117
Friday 02 Aug 2024
2:01 pm

Behrouz NematiPour

RESOLVED

RESOLVED

2:01 pm

Dara Navaei

Monday 15 Jul 2024
8:58 pm

Behrouz NematiPour

8:57 pm

Behrouz NematiPour

8:57 pm

Behrouz NematiPour

Merge branch 'DEN-16690-UI-MG-S117' into DEN-16839-UI-BN-Whitney-1B1 c88f546ad09c2d6c0222d8e694a9814e37a424ea The follow up CR would be http://devapps.diality.us:8060/cru/CLOUDSYNC-DEN-16839-1 Will...

Merge branch 'DEN-16690-UI-MG-S117' into DEN-16839-UI-BN-Whitney-1B1
c88f546ad09c2d6c0222d8e694a9814e37a424ea
The follow up CR would be http://devapps.diality.us:8060/cru/CLOUDSYNC-DEN-16839-1
Will be closed.

Tuesday 23 Apr 2024
1:40 pm

Tiffany Mejia

Wednesday 10 Apr 2024
1:16 pm

Behrouz NematiPour

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function. Please consider for later improvements. RESOLVED.

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function.
Please consider for later improvements.

RESOLVED.

1:16 pm

Behrouz NematiPour

a catchall exception is not a good idea, please separate the split() and [0], and first check the index exists, the use it. it is good to keep it if the process fails, but incorrect/unexpected resu...

a catchall exception is not a good idea, please separate the split() and [0], and first check the index exists, the use it.
it is good to keep it if the process fails, but incorrect/unexpected result is not being caught.

Tuesday 09 Apr 2024
3:50 pm

Behrouz NematiPour

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function. Please consider for later improvements. RESILVED.

It is fine for now, but as a comment, the part that calls the du command and checks the length and gets the size value should be a function.
Please consider for later improvements.

RESILVED.

2:15 pm

Michael Garthwaite

The exception handling was redundant since the message handler will catch it in ui_cs_request_handler.py and log it as CS_LOG_ROTATION_ERROR. Added check for split() length and if it fails, it'll ...

The exception handling was redundant since the message handler will catch it in ui_cs_request_handler.py and log it as CS_LOG_ROTATION_ERROR.

Added check for split() length and if it fails, it'll write to the gutils logger that the subprocess call failed in the chance that subprocess.check_output succeeds but doesn't not contain any data.

2:03 pm

Behrouz NematiPour

RESOLVED

RESOLVED

2:00 pm

Michael Garthwaite

line 507 has the reassignment if we find that sd_used_bytes is 0

line 507 has the reassignment if we find that sd_used_bytes is 0

1:49 pm

Behrouz NematiPour

RESOLVED

RESOLVED

1:48 pm

Behrouz NematiPour

RESOLVED.

RESOLVED.

11:06 am

Michael Garthwaite

added exception handling for when the subprocess call fails. thanks

added exception handling for when the subprocess call fails. thanks

11:06 am

Michael Garthwaite

added exception handling for when the subprocess call fails. thanks

added exception handling for when the subprocess call fails. thanks

10:21 am

Behrouz NematiPour

that is the point. what if the du command is not successful? there could be cases that the du call is fine from the python perspective but the result is not a successful or expected result. therefo...

that is the point. what if the du command is not successful?
there could be cases that the du call is fine from the python perspective but the result is not a successful or expected result.
therefore avoid getting the indexes from array unless you definitely know there is the index.

10:21 am

Behrouz NematiPour

does split() always have index 0 ? [index out of bounds]

does split() always have index 0 ?
[index out of bounds]

10:21 am

Behrouz NematiPour

same here for split? [index out of bounds]

same here for split?
[index out of bounds]

10:16 am

Behrouz NematiPour

please push the code to resolve

please push the code to resolve

10:15 am

Behrouz NematiPour

Please push the fix so it can be resolved.

Please push the fix so it can be resolved.

9:47 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:47 am

Michael Garthwaite

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

9:47 am

Michael Garthwaite

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

9:45 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

9:45 am

Michael Garthwaite

Not that i found that wasnt third party. shutil helps us find the sd card size, but it cant do directory sizes

Not that i found that wasnt third party. shutil helps us find the sd card size, but it cant do directory sizes

Thursday 28 Mar 2024
10:56 pm

Behrouz NematiPour

where checked if the sd_used_bytes is zero or not? [Divide by zero]

where checked if the sd_used_bytes is zero or not?
[Divide by zero]