DIALIN-DEN-4690

DIALIN-DEN-4690

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 2,952
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 15 Oct 2020
10:15 am

Behrouz NematiPour

Wednesday 14 Oct 2020
11:11 pm

pmontazemi  (deleted user) and plucia  (deleted user)

10:27 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:26 am

plucia  (deleted user)

RESOLVED. Fair, not part of story

RESOLVED.

Fair, not part of story

10:26 am

plucia  (deleted user)

Fair, not part of story. RESOLVED

Fair, not part of story.

RESOLVED

10:26 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:25 am

plucia  (deleted user)

RESOLVED. Fair, not part of story.

RESOLVED.

Fair, not part of story.

10:25 am

plucia  (deleted user)

RESOLVED. Fair, not part of story.

RESOLVED.

Fair, not part of story.

10:24 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:23 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:23 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:22 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:21 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:21 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:21 am

plucia  (deleted user)

Will be tracked in DIAL-41 RESOLVED.

Will be tracked in DIAL-41
RESOLVED.

10:18 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:17 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:17 am

plucia  (deleted user)

RESOLVED

RESOLVED

Wednesday 07 Oct 2020
11:09 pm

Behrouz NematiPour

"*** Off the subject ***" Thanks for reminding that. This is exactly what I've told and mentioned while ago at the beginning of adding these methods as part of Dialin, that was the main reason we d...

"*** Off the subject ***"
Thanks for reminding that.
This is exactly what I've told and mentioned while ago at the beginning of adding these methods as part of Dialin, that was the main reason we did it.
As we talked while ago and you're the Dialin owner, please create a story for yourself and cooperate with our manager to define the priority/plan for the story.
From that moment on, all the newly added methods shall follow that design and implementation.

11:08 pm

Behrouz NematiPour

"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.

"*** Off the subject ***"
This code review is about the documentation, not the code change.
There is no implementation and unit testing associated with this story.

11:08 pm

Behrouz NematiPour

"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.

"*** Off the subject ***"
This code review is about the documentation, not the code change.
There is no implementation and unit testing associated with this story.

11:08 pm

Behrouz NematiPour

"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.

"*** Off the subject ***"
This code review is about the documentation, not the code change.
There is no implementation and unit testing associated with this story.

11:07 pm

Behrouz NematiPour

"*** Almost off the subject ***" the function is doing partitioning the string. added description.

"*** Almost off the subject ***"
the function is doing partitioning the string.
added description.

11:07 pm

Behrouz NematiPour

"*** almost off the subject ***" it makes the parameter to be identified as a value, not a type. there is no preference for function argument naming in python coding style.

"*** almost off the subject ***"
it makes the parameter to be identified as a value, not a type.
there is no preference for function argument naming in python coding style.

11:06 pm

Behrouz NematiPour

"*** Off the subject ***" This code review is about the documentation, not the code change. There is no implementation and unit testing associated with this story.

"*** Off the subject ***"
This code review is about the documentation, not the code change.
There is no implementation and unit testing associated with this story.

10:42 pm

Behrouz NematiPour

"*** Please don't check "Needs Resolution" for each comment you made ***" Added

"*** Please don't check "Needs Resolution" for each comment you made ***"
Added

10:40 pm

Behrouz NematiPour

Thanks Peman for clarification. As discussed with Peter, updated the docstrings.

Thanks Peman for clarification.
As discussed with Peter, updated the docstrings.

5:03 pm

Behrouz NematiPour

Added

Added

5:03 pm

Behrouz NematiPour

Added

Added

4:33 pm

Behrouz NematiPour

added

added