DIALIN-DEN-8308

DIALIN-DEN-8308

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 2,952
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 01 Jun 2021
10:48 am

Behrouz NematiPour

10:46 am

plucia  (deleted user)

10:46 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:45 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:45 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:44 am

plucia  (deleted user)

RESOLVED

RESOLVED

Friday 28 May 2021
6:04 pm

Behrouz NematiPour

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

6:03 pm

Behrouz NematiPour

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

6:03 pm

Behrouz NematiPour

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

6:02 pm

Behrouz NematiPour

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

Has been addressed in http://dvm-linux02:8060/cru/DIALIN-DEN-8514-1

5:17 pm

plucia  (deleted user)

Should indicate the return type: instead of ): it should be ) -> None:

Should indicate the return type:
instead of 

):

it should be

) -> None:
5:16 pm

plucia  (deleted user)

Missing the cmd_ prefix in the function name

Missing the cmd_ prefix in the function name

5:15 pm

plucia  (deleted user)

Missing the cmd_ prefix in the function name

Missing the cmd_ prefix in the function name

5:15 pm

plucia  (deleted user)

The typing information is missing for accepted and reason here

The typing information is missing for accepted and reason here

5:15 pm

plucia  (deleted user)

RESOLVED

RESOLVED

5:15 pm

plucia  (deleted user)

RESOLVED

RESOLVED

Tuesday 25 May 2021
9:27 am

pmontazemi  (deleted user)

Monday 24 May 2021
11:45 pm

Behrouz NematiPour

Updated regarding our conversation.

Updated regarding our conversation.

8:11 am

plucia  (deleted user)

I see a couple of issues here: The message response logic has been moved out of dialin and into your UI simulator in the testsuites respository. This creates a couple of problems: First, it upends ...

I see a couple of issues here:
The message response logic has been moved out of dialin and into your UI simulator in the testsuites respository. This creates a couple of problems: First, it upends the entire design of the HD / DG simulator. Second, it splits the responsibility for simulating an HD and DG into both dialin and your UI simulator program. This means that the caller of the dialin command must know how to construct a response. If I want to use your functions to simulate a response, I can't because they don't exist here. The logic for simulating an HD and DG must be fully contained inside the HD and DG simulators so other users of the API can call it, not dispersed to outside scripts. Also, your changes appear to be on an extremely old version of dialin. These changes are incompatible with the latest changes on staging. Please merge staging into your branch.

  • A message ID must not be passed to a simulator command. This ensures there is a one to one mapping between dialin commands and messages and that dialin can do its job of abstracting messages. This is how dialin works everywhere else and should not be changed.
  • Parameters should not be pre-converted to bytearrays before being sent to dialin.
  • If you have one, two, or five parameters in a denali message, your dialin function should accept one, two, or five parameters. This ensures the payload is clearly defined and described by the number of parameters passed to the function and that the function can do its job of abstracting the denali message.
Wednesday 19 May 2021
3:20 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

3:20 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Tuesday 18 May 2021
9:16 pm

Behrouz NematiPour

I'm not aware of this function usage, but in general, some of these fields provided by HD for later use, and UI is not using them and some other has recently been used.

I'm not aware of this function usage, but in general, some of these fields provided by HD for later use, and UI is not using them and some other has recently been used.

9:14 pm

Behrouz NematiPour

Updated

Updated

9:14 pm

Behrouz NematiPour

Updated

Updated

4:14 pm

plucia  (deleted user)

Please use snake_case for all variables Typing information is missing for parameters Typing information is missing for the return type

Please use snake_case for all variables
Typing information is missing for parameters
Typing information is missing for the return type

Monday 17 May 2021
9:19 am

pmontazemi  (deleted user)

Add space after comma right before hasParameters.

Add space after comma right before hasParameters.

Friday 07 May 2021
10:23 am

pmontazemi  (deleted user)

What information is needed to replace these TBDs?

What information is needed to replace these TBDs?

Tuesday 04 May 2021
10:13 pm

Dara Navaei

DIALIN-DEN-8308_UI DEV Treatment Log
DIALIN-DEN-8308_UI DEV Treatment Log