LEAHI-APPLICATION-LDT-1021 LEAHI-APPLICATION-LDT-1021

Please consider defining a variable for functions that are used multiple times, like fields.size(), and then use that value afterwards. But for now, RESOLVED.

Please consider defining a variable for functions that are used multiple times, like fields.size(), and then use that value afterwards.
But for now,
RESOLVED.

11:29 am

Nicholas Ramirez

updated and removed for now

10:43 am

Nicholas Ramirez

Added notification to user

10:43 am

Nicholas Ramirez

fixed indent

10:41 am

Nicholas Ramirez

fixed string

10:41 am

Nicholas Ramirez

updated and organized

7:30 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-1021-1
commented on review

If the script is not passing enough parameters, we need to notify the user. Use the status (tr ("The WiFi info response error")); LOG_DEBUG(QString("The WiFi info response length is not corre...

If the script is not passing enough parameters, we need to notify the user.
Use the

status   (tr     ("The WiFi info response error"));
LOG_DEBUG(QString("The WiFi info response length is not correct [%1 of %2]").arg(len).arg(eCount))

to notify user.

Please test my suggested code/s

6:51 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-1021-1
commented on review

Please keep the attributes close together and add an empty line between those and the rest of the normal PROPERTY/READONLY properties. ATTRIBUTE ( QStringList , wifiList , {} ...

Please keep the attributes close together and add an empty line between those and the rest of the normal PROPERTY/READONLY properties.

    ATTRIBUTE   ( QStringList   , wifiList            , {}   , WifiList          )
    ATTRIBUTE   ( QStringList   , wifiInfo            , {}   , WifiInfo          )
    ATTRIBUTE   ( bool          , wifiConnect         , false, WifiConnect       )
    READONLY    ( bool          , wifiListEnabled     , true                     )
    READONLY    ( QString       , ssid                , ""                       )
    READONLY    ( QString       , ipAddress           , ""                       )
    READONLY    ( QString       , gateway             , ""                       )
    READONLY    ( QString       , subnetMask          , ""                       )
    READONLY    ( QString       , dns                 , ""                       )

6:18 pm