LEAHI-DD-FIRMWARE-LDT-1925

LEAHI-DD-FIRMWARE-LDT-1925

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,308
Last Commit: 05 Jan
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 21 Jan
10:10 am

Raghu Kallala

9:46 am

Michael Garthwaite

Tuesday 20 Jan
2:19 pm

Sean Nash

2:14 pm

Raghu Kallala

Updated

Updated

2:14 pm

Raghu Kallala

Added

Added

2:14 pm

Raghu Kallala

Updated

Updated

2:14 pm

Raghu Kallala

Fixed

Fixed

2:12 pm

Sean Nash

TRUE if low flow alarm is exempt, FALSE if not.

TRUE if low flow alarm is exempt, FALSE if not.

2:08 pm

Sean Nash

timeSinceP12Started?

timeSinceP12Started?

2:07 pm

Sean Nash

Should we have a comment for this one too?

Should we have a comment for this one too?

2:07 pm

Sean Nash

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

1:43 pm

Raghu Kallala

Updated to use isPersistentAlarmTriggered

Updated to use isPersistentAlarmTriggered

1:43 pm

Raghu Kallala

Fixed

Fixed

1:43 pm

Raghu Kallala

Updated

Updated

1:42 pm

Raghu Kallala

Updated

Updated

1:42 pm

Raghu Kallala

Changed the implementation

Changed the implementation

1:42 pm

Raghu Kallala

Fixed

Fixed

9:58 am

Sean Nash

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control? And why aren't we resetting exempt flag in same place as timer?

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control?
And why aren't we resetting exempt flag in same place as timer?

9:57 am

Sean Nash

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

9:56 am

Sean Nash

I think timer should be internal (private) to this unit.

I think timer should be internal (private) to this unit.

9:55 am

Sean Nash

We need to be calling the isPersistentAlarm function regardless of exemption, but only triggering the alarm if persistent alarm function returns TRUE and exemption is FALSE.

We need to be calling the isPersistentAlarm function regardless of exemption, but only triggering the alarm if persistent alarm function returns TRUE and exemption is FALSE.

9:52 am

Sean Nash

I think timeout should be handled inside ROPump unit. From here, we should just call one function that tells us whether alarm should be exempt or not.

I think timeout should be handled inside ROPump unit. From here, we should just call one function that tells us whether alarm should be exempt or not.

9:46 am

Sean Nash

For init functions, I think it's ok (and cleaner) to just say we initialize ALL unit variables.

For init functions, I think it's ok (and cleaner) to just say we initialize ALL unit variables.

9:13 am

Raghu Kallala

9:13 am

Raghu Kallala

7:04 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup
LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup
Monday 05 Jan
4:15 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -0
    • +14
    /sources/model/settings/MWifiNetwork.h
4:14 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -14
    • +0
    /sources/model/settings/MWifiNetwork.h
3:15 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -0
    • +14
    /sources/model/dg/data/MDGGeneralEvent.h
3:12 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /alarmMapping.sh
    • -1
    • +1
    /cho.sh
    • -1
    • +1
    /cppcheck.sh
    • -1
    • +1
    /cr_objectives.sh
    • -1
    • +1
    /imake.sh
    • -1
    • +1
    /main.cpp
    • -1
    • +1
    /remove-exra-emptylines.sh
    • -1
    • +1
    /sources/AlarmGenerator.cpp
    • -1
    • +1
    /sources/AlarmGenerator.h
    • -1
    • +1
    /sources/ApplicationController.cpp
    • -1
    • +1
    /sources/ApplicationController.h
    • -1
    • +1
    /sources/ApplicationPost.cpp
    • -1
    • +1
    /sources/ApplicationPost.h
    • -1
    • +1
    /sources/MainTimer.cpp
    • -1
    • +1
    /sources/MainTimer.h
  16. … 607 more files in changeset.