LEAHI-TESTSUITES-LDT-2278

BN approvees

BN approvees

BN approves

BN approves

Added the function for device and VM home_dir = str(Path.home()) if home_dir == "/home/denali": return "/home/denali/Public/luis/config/configurations/" else: return "/opt/leahi/config/configurati...

Added the function for device and VM

home_dir = str(Path.home())
if home_dir == "/home/denali":
return "/home/denali/Public/luis/config/configurations/"
else:
return "/opt/leahi/config/configurations/"

rejection.conf file is available in /home/denali/Public/luis/config/configurations/Alarms/Rejections.conf in this path

rejection.conf file is available in /home/denali/Public/luis/config/configurations/Alarms/Rejections.conf in this path

where is the rejection.conf? I don't see that in the CR.

where is the rejection.conf?
I don't see that in the CR.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Same as the previous comments I wrote to make it compatible with the device and the VM, the base folders are different, and it's not always on the HOME.

Same as the previous comments I wrote to make it compatible with the device and the VM, the base folders are different, and it's not always on the HOME.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

I am allowing a tolerance of 2 seconds between the expected time and the UI-displayed time.

I am allowing a tolerance of 2 seconds between the expected time and the UI-displayed time.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Stepnames variable is the list of objects (i.e concentrate,Installation,self tests) Standard and advanced mode differ by getting the value from the system.conf file

Stepnames variable is the list of objects (i.e concentrate,Installation,self tests)

Standard and advanced mode differ by getting the value from the system.conf file

What is 2? What was 1?

What is 2?
What was 1?

Added the variable for the path

Added the variable for the path

Getting the text from rejection.conf

Getting the text from rejection.conf

Added for different test case for this test case it is not used

Added for different test case for this test case it is not used

We have one parent object, and different values are defined by different ID by using findObjectByID

We have one parent object, and different values are defined by different ID by using findObjectByID

In another CR, this is a variable ([1] Request is ....). After the comment is addressed there, maybe it can be used here.

In another CR, this is a variable ([1] Request is ....).
After the comment is addressed there, maybe it can be used here.

Please provide an example of what the stepnames variable contains. How do you ensure that the requested index is always available and that the code does not fail?

Please provide an example of what the stepnames variable contains.
How do you ensure that the requested index is always available and that the code does not fail?

Why do we use findObjectByID and do not define it in then names.py?

Why do we use findObjectByID and do not define it in then names.py?

Make this a variable, and it will also differ on the device or the DevTest VM.

Make this a variable, and it will also differ on the device or the DevTest VM.

Too general. What is the usecase?

Too general.
What is the usecase?

Bamboo Commit: Updated MAlarmMapping.cpp

    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Merged release/p1b/staging and resolved the conflicts

    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp