UI-DEN-14838

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Can you check on the latest commit if this space was already removed? I can't tell which line this comment is in regards to. Thanks!

Can you check on the latest commit if this space was already removed? I can't tell which line this comment is in regards to. Thanks!

I think we wanted the alias and not the bool. I vaguely remember suggesting the change to alias. This could've been a revert change. I am not sure. I will change it back to alias

I think we wanted the alias and not the bool. I vaguely remember suggesting the change to alias. This could've been a revert change. I am not sure. I will change it back to alias

This is after the text property. I removed the newline between them as a change

This is after the text property. I removed the newline between them as a change

Moved onTextChanged line and removed extra newline

Moved onTextChanged line and removed extra newline

Will make note. Changed comment to reflect.

Will make note. Changed comment to reflect.

Updated.

Updated.

It will display two same values with one tick. I have removed the check.

It will display two same values with one tick.

I have removed the check.

Updated, thank you

Updated, thank you

please remove an extra empty line which is not necessary.

please remove an extra empty line which is not necessary.

Didn't we find an issue with changing this to bool instead of alias while were testing?

Didn't we find an issue with changing this to bool instead of alias while were testing?

in general, if the comment is for the entire if block put it in front of the if block. also for the else at line 66.

in general, if the comment is for the entire if block put it in front of the if block.
also for the else at line 66.

please move after the text property and remove the extra empty line.

please move after the text property and remove the extra empty line.

please move after the text property.

please move after the text property.

Please let the following calculation of the overlap do the separation. Otherwise will completely overlap and eventually displays one value which would be confusing. And also creates a position jump.

Please let the following calculation of the overlap do the separation.
Otherwise will completely overlap and eventually displays one value which would be confusing.
And also creates a position jump.

typo: ajust => adjust

typo: ajust => adjust

Please change the minimum gap to 4. I think when tested, 4 was sufficient.

Please change the minimum gap to 4.
I think when tested, 4 was sufficient.

UI-DEN-14838_UI VD S91 [ Sliders ]
UI-DEN-14838_UI VD S91 [ Sliders ]