UI-DEN-2086

UI-DEN-2086

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 31 Jan 2023
11:31 pm

Behrouz NematiPour

Monday 09 Jan 2023
7:03 am

Dara Navaei

UI-DEN-2086_Denalicommunication
UI-DEN-2086_Denalicommunication
Tuesday 10 Mar 2020
5:16 pm

Dara Navaei

5:10 pm

pmontazemi  (deleted user)

5:03 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

5:03 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

1:12 am

Behrouz NematiPour

Has been removed in the current working branch fro the Treatment last implementation.

Has been removed in the current working branch fro the Treatment last implementation.

1:12 am

Behrouz NematiPour

Has been removed in the current working branch fro the Treatment last implementation.

Has been removed in the current working branch fro the Treatment last implementation.

Friday 06 Mar 2020
9:59 am

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

9:58 am

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

Monday 02 Mar 2020
4:34 pm

plucia  (deleted user)

3:54 pm

plucia  (deleted user)

Okay, makes sense, RESOLVED

Okay, makes sense, RESOLVED

3:54 pm

plucia  (deleted user)

RESOLVED

RESOLVED

3:54 pm

plucia  (deleted user)

RESOLVED

RESOLVED

3:45 pm

Behrouz NematiPour

For the first one, sure For the second, We are not going to support extended CAN. At least we don't have any plan and if we want to do it, it needs the architecture (SWA,SDD,...) to be modified.

For the first one, sure
For the second, We are not going to support extended CAN. At least we don't have any plan and if we want to do it, it needs the architecture (SWA,SDD,...) to be modified.

3:44 pm

Behrouz NematiPour

uint QVariant::toUInt(bool *ok = nullptr) const Returns the variant as an unsigned int if the variant has userType() QMetaType::UInt, QMetaType::Bool, QMetaType::QByteArray, QMetaType::QChar, QMeta...

uint QVariant::toUInt(bool *ok = nullptr) const
Returns the variant as an unsigned int if the variant has userType() QMetaType::UInt, QMetaType::Bool, QMetaType::QByteArray, QMetaType::QChar, QMetaType::Double, QMetaType::Int, QMetaType::LongLong, QMetaType::QString, or QMetaType::ULongLong; otherwise returns 0.

0 is fine with me.

3:33 pm

plucia  (deleted user)

Just as a suggestion, for future it would be helpful to replace the magic numbers with descriptive variables to improve readability here. Will it need to change to support both Standard and Extende...

Just as a suggestion, for future it would be helpful to replace the magic numbers with descriptive variables to improve readability here. Will it need to change to support both Standard and Extended CAN?

3:26 pm

Behrouz NematiPour

Yes, I used channel Id 0 as none, but since it has a highest priority it's not good to have the highest priority channel id for something kind of unknown, so I changed it to the lowest. Also the Lo...

Yes,
I used channel Id 0 as none, but since it has a highest priority it's not good to have the highest priority channel id for something kind of unknown, so I changed it to the lowest.
Also the Lowest is used for keepAwake message.
And both have the same value.

3:21 pm

plucia  (deleted user)

Maybe need a check if (vData.type() == QVariant::Int) here before incrementing mData?

Maybe need a check if (vData.type() == QVariant::Int) here before incrementing mData?

3:17 pm

plucia  (deleted user)

Should these be equal?

Should these be equal?

2:56 pm

Behrouz NematiPour

DEN-UI-2086_Denali Communications
DEN-UI-2086_Denali Communications