UI-DEN-2086

UI-DEN-2086_Denalicommunication
UI-DEN-2086_Denalicommunication
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Has been removed in the current working branch fro the Treatment last implementation.

Has been removed in the current working branch fro the Treatment last implementation.

Has been removed in the current working branch fro the Treatment last implementation.

Has been removed in the current working branch fro the Treatment last implementation.

Remove extra line.

Remove extra line.

Remove extra line.

Remove extra line.

Okay, makes sense, RESOLVED

Okay, makes sense, RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

For the first one, sure For the second, We are not going to support extended CAN. At least we don't have any plan and if we want to do it, it needs the architecture (SWA,SDD,...) to be modified.

For the first one, sure
For the second, We are not going to support extended CAN. At least we don't have any plan and if we want to do it, it needs the architecture (SWA,SDD,...) to be modified.

uint QVariant::toUInt(bool *ok = nullptr) const Returns the variant as an unsigned int if the variant has userType() QMetaType::UInt, QMetaType::Bool, QMetaType::QByteArray, QMetaType::QChar, QMeta...

uint QVariant::toUInt(bool *ok = nullptr) const
Returns the variant as an unsigned int if the variant has userType() QMetaType::UInt, QMetaType::Bool, QMetaType::QByteArray, QMetaType::QChar, QMetaType::Double, QMetaType::Int, QMetaType::LongLong, QMetaType::QString, or QMetaType::ULongLong; otherwise returns 0.

0 is fine with me.

Just as a suggestion, for future it would be helpful to replace the magic numbers with descriptive variables to improve readability here. Will it need to change to support both Standard and Extende...

Just as a suggestion, for future it would be helpful to replace the magic numbers with descriptive variables to improve readability here. Will it need to change to support both Standard and Extended CAN?

Yes, I used channel Id 0 as none, but since it has a highest priority it's not good to have the highest priority channel id for something kind of unknown, so I changed it to the lowest. Also the Lo...

Yes,
I used channel Id 0 as none, but since it has a highest priority it's not good to have the highest priority channel id for something kind of unknown, so I changed it to the lowest.
Also the Lowest is used for keepAwake message.
And both have the same value.

Maybe need a check if (vData.type() == QVariant::Int) here before incrementing mData?

Maybe need a check if (vData.type() == QVariant::Int) here before incrementing mData?

Should these be equal?

Should these be equal?

DEN-UI-2086_Denali Communications
DEN-UI-2086_Denali Communications