UI-DEN-4690-2

UI-DEN-4690-2

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 15 Oct 2020
10:16 am

Behrouz NematiPour

Wednesday 14 Oct 2020
11:07 pm

pmontazemi  (deleted user) and plucia  (deleted user)

10:44 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:44 am

plucia  (deleted user)

RESOLVED. Fair, not related to story

RESOLVED.

Fair, not related to story

10:43 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:43 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:42 am

plucia  (deleted user)

Fair, not related to story. RESOLVED.

Fair, not related to story.

RESOLVED.

Tuesday 13 Oct 2020
6:07 pm

Behrouz NematiPour

did

did

6:04 pm

Behrouz NematiPour

It is all documentations and Doxygenization. If you see otherwise is because of the some file name change and the code review take it as a new file and mark all the file content as to be reviewed. ...

It is all documentations and Doxygenization.
If you see otherwise is because of the some file name change and the code review take it as a new file and mark all the file content as to be reviewed.
Let me know if otherwise.

Wednesday 07 Oct 2020
11:06 pm

Behrouz NematiPour

"*** Off the subject ***" I don't have any plans for that. It was an effort to feel the gap of not having the corresponding FW code at that moment. If it happens again will consider improving the c...

"*** Off the subject ***"
I don't have any plans for that.
It was an effort to feel the gap of not having the corresponding FW code at that moment.
If it happens again will consider improving the code otherwise we need to consolidate with our manager for priorities/planning.

11:05 pm

Behrouz NematiPour

"*** Off the subject ***" AGAIN, I don't understand what is the relevance of the comment to the Story and which part of the code this comment is referring to?

"*** Off the subject ***"
AGAIN,
I don't understand what is the relevance of the comment to the Story and which part of the code this comment is referring to?

Tuesday 06 Oct 2020
12:42 pm

Behrouz NematiPour

This is the test code. Not the API, not the production code. And not even being used in documentation. I don't think we need to put comments for these functions as long as the name is self-descript...

This is the test code.
Not the API, not the production code.
And not even being used in documentation.
I don't think we need to put comments for these functions as long as the name is self-descriptive within context.
As I never asked you to comment on your test functions.

9:44 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:44 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:44 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:44 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:43 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:43 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Monday 05 Oct 2020
11:09 am

Behrouz NematiPour

Good point, I don't know. This is the way Crucible shows them.

Good point, I don't know.
This is the way Crucible shows them.

11:09 am

Behrouz NematiPour

Good point, I don't know. This is the way Crucible shows them.

Good point, I don't know.
This is the way Crucible shows them.

11:08 am

Behrouz NematiPour

Good point, I don't know. This is the way Crucible shows them.

Good point, I don't know.
This is the way Crucible shows them.

11:07 am

Behrouz NematiPour

I kept these files noncapital since they have short one word only files and no need to be PascalCase.

I kept these files noncapital since they have short one word only files and no need to be PascalCase.

11:04 am

Behrouz NematiPour

This file and all the view file has been renamed to CamelCase but seems Crucible still insist to get a review on them.

This file and all the view file has been renamed to CamelCase but seems Crucible still insist to get a review on them.

11:02 am

Behrouz NematiPour

Good point, but I don't know. Seems like it's the way Crucible prefers to show the files. It has been removed and even the git log shows that. This commit is the last commit no the ApplicationContr...

Good point, but I don't know.
Seems like it's the way Crucible prefers to show the files.
It has been removed and even the git log shows that.
This commit is the last commit no the ApplicationController and there is no applicationcontroler on that commit anymore.
http://192.168.10.132:8060/changelog/application/?cs=bb74da05f81b82dad3ec844c1feb1135b949f1c2

Wednesday 30 Sep 2020
3:51 pm

plucia  (deleted user)

Better to fix it now then never

Better to fix it now then never

3:46 pm

plucia  (deleted user)

Which of these classes will need to be in the production code? VDGROPump VDGDrainPump VDGPressures VDGReservoir VDGHeaters VDGLoadCellReadings VDGTemperatures VDGValveStates VDGOperationMode VTrea...

Which of these classes will need to be in the production code? 

VDGROPump
VDGDrainPump
VDGPressures
VDGReservoir
VDGHeaters
VDGLoadCellReadings
VDGTemperatures
VDGValveStates
VDGOperationMode
VTreatmentBloodFlow
VTreatmentDialysateFlow
VTreatmentUltrafiltration
VTreatmentPressureOcclusion


Are any only for in-development testing / convenience for systems?

3:35 pm

plucia  (deleted user)

The functions are missing docstrings. Function descriptions and parameter types and descriptions, as well as the return type are needed

The functions are missing docstrings.

Function descriptions and parameter types and descriptions, as well as the return type are needed

3:33 pm

plucia  (deleted user)

Please indicate the return type as "None" if a function doesn't return anything

Please indicate the return type as "None" if a function doesn't return anything

3:18 pm

pmontazemi  (deleted user)

How come these files have been renamed but they have not been deleted to show in red?

How come these files have been renamed but they have not been deleted to show in red?

3:17 pm

pmontazemi  (deleted user)

Should these files be renamed following our convention?

Should these files be renamed following our convention?