UI-DEN-704

UI-DEN-704

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,303
Last Commit: 20 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 19 Oct 2023
3:02 pm

Dara Navaei

10:57 am

Dara Navaei

RESOLVED

RESOLVED

10:57 am

Dara Navaei

RESOLVED

RESOLVED

10:57 am

Dara Navaei

10:56 am

Dara Navaei

UI-DEN-704_HomeScreen
UI-DEN-704_HomeScreen
Friday 20 Dec 2019
8:24 am

lbaloa  (deleted user)

8:23 am

lbaloa  (deleted user)

RESOLVED

RESOLVED

8:22 am

lbaloa  (deleted user)

RESOLVED

RESOLVED

8:22 am

lbaloa  (deleted user)

RESOLVED

RESOLVED

8:22 am

lbaloa  (deleted user)

RESOLVED

RESOLVED

8:20 am

lbaloa  (deleted user)

RESOLVED

RESOLVED

Thursday 19 Dec 2019
9:02 am

Behrouz NematiPour

I meant : "Can Interface has been setup" like that I have as : "candump launched"

I meant :
"Can Interface has been setup"

like that I have as :
"candump launched"

8:57 am

Behrouz NematiPour

For the two eChlid_UI and eChlid_HD which are for UI in UI I prefer to keep them simple to use and read.

For the two eChlid_UI and eChlid_HD which are for UI in UI I prefer to keep them simple to use and read.

8:55 am

Behrouz NematiPour

it has been addresses : *http://dvm-linux02:8060/project/UI-DEN-1090

it has been addresses :

8:47 am

lbaloa  (deleted user)

Behrouz 0x20 is a channel ID that is from UI to HD. This identifier does not reflect that. Please reconsider renaming.

Behrouz 0x20 is a channel ID that is from UI to HD. This identifier does not reflect that. Please reconsider renaming.

Thursday 05 Dec 2019
1:53 pm

lbaloa  (deleted user)

Same comment as before. Verb.

Same comment as before. Verb.

1:53 pm

lbaloa  (deleted user)

Recommend using a more descriptive naming. 0x020 is an input channel to UI, i.e., HD2UI. Similar is 0x100, it is an output channel.From UI to HD.

Recommend using a more descriptive naming. 0x020 is an input channel to UI, i.e., HD2UI. Similar is 0x100, it is an output channel.From UI to HD.

1:52 pm

Behrouz NematiPour

Oh I changed it to initConnections() in new pushes as part of DEN-1090 : DEN-1090-1 when I saw your comment.

Oh I changed it to initConnections() in new pushes as part of DEN-1090 : DEN-1090-1 when I saw your comment.

1:51 pm

Behrouz NematiPour

It has been done in new codes for DEN-1090 : DEN-1090-1. But as a general comment its my preferred coding style for readability and its not our rule or requirement.

It has been done in new codes for DEN-1090 : DEN-1090-1.
But as a general comment its my preferred coding style for readability and its not our rule or requirement.

1:47 pm

Behrouz NematiPour

Can Interface has its own error information. What I added here is an extra information.

Can Interface has its own error information.
What I added here is an extra information.

1:46 pm

Behrouz NematiPour

I was going to use connect but the parent has one then it will override it which is wrong. So I changed it to connection.

I was going to use connect but the parent has one then it will override it which is wrong.
So I changed it to connection.

1:40 pm

lbaloa  (deleted user)

Line up onRead() slot with frameReceived()... e.g. onCANFrameReceived()

Line up onRead() slot with frameReceived()... e.g. onCANFrameReceived()

1:39 pm

lbaloa  (deleted user)

Device creation is too generic, make it more specific "Can interface cannot be initialize"

Device creation is too generic, make it more specific "Can interface cannot be initialize"

1:39 pm

lbaloa  (deleted user)

Same as before. Methods must be verbs.

Same as before. Methods must be verbs.

1:37 pm

lbaloa  (deleted user)

Add commented line with the name of the script. Don't we need headers for these scripts?

Add commented line with the name of the script. Don't we need headers for these scripts?

1:35 pm

lbaloa  (deleted user)

The message should be more along the lines that CAN interface is running...

The message should be more along the lines that CAN interface is running...

10:11 am

pmontazemi  (deleted user)

Tuesday 03 Dec 2019
10:41 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

10:41 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Tuesday 26 Nov 2019
12:55 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.