Behrouz NematiPour

About
  • First commit 24 September 2019
  • Latest commit 04 April 2026
Last Week All Time
Commits: 10 2,962

Reviews

50 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Behrouz NematiPour is mapped to 32 committers over 24 repositories
Username bnematipour is mapped to:
Monday 16 Mar
5:31 pm

Behrouz NematiPour

to recirculate.

to recirculate.

5:30 pm

Behrouz NematiPour

If the "additional" word is used for the recirculate, please update everywhere to recirculate. The additional is for extra blood return, and recirculation is just to recirculate the blood to preven...

If the "additional" word is used for the recirculate, please update everywhere to recirculate.
The additional is for extra blood return,
and recirculation is just to recirculate the blood to prevent clogging.

Please update in other files as well.

5:27 pm

Behrouz NematiPour

Let's discuss the changes made in this file. Since this is the base class, I am a little concerned about the Reinseback-specific logics added here. shouldn't be in the EndRinseback.... qml. This a...

Let's discuss the changes made in this file.
Since this is the base class, I am a little concerned about the Reinseback-specific logics added here.
shouldn't be in the EndRinseback.... qml.

This also being used for the recirculate.

Friday 13 Mar
3:25 pm

Behrouz NematiPour

BN APPROVES.

BN APPROVES.

3:25 pm

Behrouz NematiPour

BN APPROVES.

BN APPROVES.

3:25 pm

Behrouz NematiPour

Nicholas Ramirez Could you please recheck, I don't see the updated change.

Nicholas Ramirez
Could you please recheck, I don't see the updated change.

3:24 pm

Behrouz NematiPour

BN APPROVES.

BN APPROVES.

3:23 pm

Behrouz NematiPour

BN APPROVES.

BN APPROVES.

3:20 pm

Behrouz NematiPour

BN APPROVES.

BN APPROVES.

3:18 pm

Behrouz NematiPour

BN APPROVES.

BN APPROVES.

3:17 pm

Behrouz NematiPour

BN APPROVES.

BN APPROVES.

Thursday 12 Mar
4:09 pm

Behrouz NematiPour

Monday 02 Mar
10:24 am

Behrouz NematiPour

10:23 am

Behrouz NematiPour

10:23 am

Behrouz NematiPour

Monday 23 Feb
3:36 pm

Behrouz NematiPour

3:28 pm

Behrouz NematiPour

Friday 20 Feb
4:01 pm

Behrouz NematiPour

Friday 13 Feb
11:41 am

Behrouz NematiPour

if it is not in the if block add an empty line.

if it is not in the if block add an empty line.

11:40 am

Behrouz NematiPour

If all timeouts are set to 3000, please set it as the default for the function parameter to avoid passing it everywhere.

If all timeouts are set to 3000, please set it as the default for the function parameter to avoid passing it everywhere.

11:38 am

Behrouz NematiPour

should this file be removed?

should this file be removed?

11:36 am

Behrouz NematiPour

That was a great idea to make it a function. *I would also use different (4) parameters and give them a relevant, short name, so users in the code can set them as false or true without knowing th...

That was a great idea to make it a function.

  • I would also use different (4) parameters and give them a relevant, short name, so users in the code can set them as false or true without knowing the -q meaning.
  • It also gives the application flexibility to change the CLI switches without affecting the rest of the test, and only this function would need to be changed.


How should be developed:

def aut(vDisableTimeout, vDisableCheckIn, vDisableAcknow, vDisableSDFail)


How users use it:

aut(vDisableTimeout = True)

FYI the entire CLI switches:

* Options:
 *   -h, --help                           Displays help on commandline options.
 *   --help-all                           Displays help including Qt specific
 *                                        options.
 *   -v, --version                        Displays version information.
 *   -c, --canOut                         Show the Can Frame Output
 *   -m, --msgOut                         Show the Message Output
 *   -l, --logOut                         Show the Logs Output
 *   -0, --enable-keep-awake              Enable send low priority, empty message
 *                                        on the CANBus just to keep UI board CAN
 *                                        driver awake
 *   -i, --fake-interval <interval>       Test fake message interval(ms)
 *   -f, --fake-message <data>            Test fake message data
 *                                        will use default sequenced long fake
 *                                        message if set to 00(default)
 *                                        will used only if correct integer value
 *                                        assigned for interval option
 *   -b, --fake-message-seq-at-begin      Test fake message sequence at the
 *                                        beginning of the frame
 *   -u, --disable-unhandled-report       Disable unhandled messages report as an
 *                                        error in the log
 *   -d, --disable-dialin-unhandled       Disable the Dialin messages logged as
 *                                        unhandled
 *   -q, --disable-timeout                Disables communication timeout
 *   -a, --disable-alarm-no-minimize      Disables alarm no minimize
 *   -S, --disable-sd-card-fail-log-stop  disable-sd-card-fail-log-stop
 *   -C, --disable-cloudsync-fail-stop    disable-cloudsync-fail-stop
 *   -k, --disable-check-in-log           Disables Check-In Log
 *   -K, --disable-acknow-log             Disables Acknowledgment Log
 *   -D, --enable-dry-demo                Enables Dry-Demo Mode
 *   -A, --active-can-bus <CANBus>        Sets the Active CANBus [Shall start with
 *                                        'can' or 'vcan]
 *   -E, --enable-manufacturing           Enables the manufacturing mode to
 *                                        configure the system for the first time.
 *   -R, --use-root-home                  In case the application is not in
 *                                        Manufacturing Setup but needs to use root
 *                                        home folder for configurations.
 *   -U, --enable-update-mode             Enables the update mode to update only
 *                                        necessary files during the update and
 *                                        keep the rest.
 *   -x, --use-log-long-name              Use the log long file name format
 *                                        <date>_<time>_<serial>_<mode>
 *   -y, --use-log-cloud-upload           Use the log cloud upload
 *   -z, --use-log-compression            Use the log compression
 *   -L, --use-log-unhandled-only         Use the unhandled messages only to log
11:22 am

Behrouz NematiPour

I don't think anything other than the container, and [ id or objectName ] should be in the object definition dictionary. If, as an example, the passwordCharacter is changed to #, the object cannot ...

I don't think anything other than the container, and [ id or objectName ] should be in the object definition dictionary.
If, as an example, the passwordCharacter is changed to #, the object cannot be found. same for echoMode.

11:18 am

Behrouz NematiPour

Isn't it better to name it like "findAllChildrenById"? Children instead of Objects? *And why do we add the parent, too? *That could be because you are using a recursive function, and I am not s...
  • Isn't it better to name it like "findAllChildrenById"? Children instead of Objects?
  • And why do we add the parent, too?
    • That could be because you are using a recursive function, and I am not sure that is necessary.
  • Any object in QML has "id", do we need to check that, since it is not like the "objectName"
  • How could all id of the children be the same since there is no RegEx here?
10:53 am

Behrouz NematiPour

translatable. I won't repeat the same comment, but I see the same pattern elsewhere.

translatable.
I won't repeat the same comment, but I see the same pattern elsewhere.

10:51 am

Behrouz NematiPour

Multiple lines of the texts here are translatable. I think we need to create a separate Python file for text-only content, so we can load different versions of it depending on the language we set b...

Multiple lines of the texts here are translatable.
I think we need to create a separate Python file for text-only content, so we can load different versions of it depending on the language we set before each test.
Additionally, another idea is to separate any text verification into a translation test case for the entire application using the Python file I mentioned above.
Nicholas Ramirez What are your thoughts on that?

Friday 06 Feb
1:19 pm

Behrouz NematiPour

1:15 pm

Behrouz NematiPour

1:14 pm

Behrouz NematiPour

Thursday 05 Feb
3:35 pm

Behrouz NematiPour