Sean Nash

About
  • First commit 24 September 2019
  • Latest commit 09 December 2025
Last Week All Time
Commits: 1 4,041

Reviews

45 active reviews

Counts may include data that you cannot access.

Line History

Line history chart not available

Line history chart not available

 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sean Nash is mapped to 36 committers over 12 repositories
Username snash is mapped to:
Thursday 11 Dec
2:00 pm

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

1:46 pm

Sean Nash

11:32 am

Sean Nash

Add space before ).

Add space before ).

11:32 am

Sean Nash

Add space between if and (.

Add space between if and (.

11:31 am

Sean Nash

Be consistent on whether you have a blank line between break and next case.

Be consistent on whether you have a blank line between break and next case.

11:30 am

Sean Nash

Keep blank line here.

Keep blank line here.

11:12 am

Sean Nash

What are these coefficients for? At least describe in comments, if not the names.

What are these coefficients for? At least describe in comments, if not the names.

11:10 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:09 am

Sean Nash

11:09 am

Sean Nash

11:08 am

Sean Nash

9:56 am

Sean Nash

6:56 am

Sean Nash

Tuesday 09 Dec
4:13 pm

Sean Nash

4:13 pm

Sean Nash

3:14 pm

Sean Nash

LDT-2932: Fixed TMP calculation.

Options
    • -2
    • +2
    /firmware/App/Monitors/Pressures.c
2:27 pm

Sean Nash

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

2:18 pm

Sean Nash

Isn't timestamp typically first (or last) in publish list?

Isn't timestamp typically first (or last) in publish list?

2:11 pm

Sean Nash

2:04 pm

Sean Nash

11:20 am

Sean Nash

10:43 am

Sean Nash

10:39 am

Sean Nash

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

10:27 am

Sean Nash

Shouldn't EVERY state set ALL valves?

Shouldn't EVERY state set ALL valves?

10:16 am

Sean Nash

Change comment from 3 to 5 minutes to match code.

Change comment from 3 to 5 minutes to match code.

10:14 am

Sean Nash

I don't see fix

I don't see fix

9:58 am

Sean Nash

I didn't see this in header file.

I didn't see this in header file.