Vendor - TEL - Arpita Srivastava

LDT-3735: Added state machine to send institutional record through scheduler

    • -250
    • +315
    /firmware/App/Services/NVMessagingDD.c
    • -14
    • +192
    /firmware/App/Services/NVRecordsDD.c
please add message id.

please add message id.

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

please remove extra line

please remove extra line

Output is none

Output is none

Please add message id.

Please add message id.

Output is none

Output is none

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

uiVersion is an input

uiVersion is an input

Should we update the comment as well to remove occlusion?

Should we update the comment as well to remove occlusion?

add a blank else block

add a blank else block

add comment

add comment

add a blank line above this comment.

add a blank line above this comment.

LDT-3735: Added receive message handlers without paging

    • -232
    • +186
    /firmware/App/Services/NVMessagingDD.c
    • -1
    • +9
    /firmware/App/Services/NVMessagingDD.h
    • -173
    • +627
    /firmware/App/Services/NVRecordsDD.c
add airTrapLowerEventCount to input

add airTrapLowerEventCount to input

add airTrapLowerEventStartTime and airTrapLowerEventCount to Output

add airTrapLowerEventStartTime and airTrapLowerEventCount to Output

Add to input and output: airTrapLowerEventCount, airTrapLowerEventStartTime

Add to input and output: airTrapLowerEventCount, airTrapLowerEventStartTime

Add alarm : ALARM_ID_TD_REPEATED_AIR_TRAP_LOWER_EVENTS

Add alarm : ALARM_ID_TD_REPEATED_AIR_TRAP_LOWER_EVENTS

break it into two lines

break it into two lines

remove flag from the comments

remove flag from the comments

can we create a variable minPayloadLen for the calculation?

can we create a variable minPayloadLen for the calculation?

Output should be none.

Output should be none.

Move this after the switch, if possible.

Move this after the switch, if possible.

Can we break the comment in 2-3 lines?

Can we break the comment in 2-3 lines?

mesage payload is not an input. We correctly mentioned it in the param. Input should be none as we are not reading any global or static variable declared at file level.

mesage payload is not an input. We correctly mentioned it in the param.
Input should be none as we are not reading any global or static variable declared at file level.

Output should be none as we are not updating any global or static variable declared at file level.

Output should be none as we are not updating any global or static variable declared at file level.

Please convert the function to have only single point of return. You can assign result = FALSE here. Also check for whitespace characters. Use 4 spaces instead of tab.

Please convert the function to have only single point of return.
You can assign result = FALSE here.

Also check for whitespace characters. Use 4 spaces instead of tab.

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

Why are we adding this header here?

Why are we adding this header here?