Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

This code review contains known issues, and it is not yet ready for a detailed review.

This code review contains known issues, and it is not yet ready for a detailed review.

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Minor: There is a typo with Inputs

Minor: There is a typo with Inputs

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function. Should we add bloodLeakEmbModeCmdQ to the list?

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

Please change bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE to BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Please change

bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE
to
BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

Please remove extra line

Please remove extra line

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Minor: Need space between parentheses

Minor: Need space between parentheses

Minor: Need space between parentheses

Minor: Need space between parentheses

Minor: Please add space in [cmd].

Minor: Please add space in [cmd].

Should it be bloodLeakEmbModeCmd?

Should it be bloodLeakEmbModeCmd?

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE...

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

We can update this function as part of another Jira ticket.

We can update this function as part of another Jira ticket.