Vinayakam Mani

4 bytes reg.

4 bytes reg.

4 byte reg.

4 byte reg.

Remove typecast.

Remove typecast.

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

Done.

Done.

Done.

Done.

Add comments

Add comments

Align indent

Align indent

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

are we using this variable, if not, can we remove across the file?

are we using this variable, if not, can we remove across the file?

Add comment

Add comment

Remove the unused macros.

Remove the unused macros.

Mask value seems wrong. please update per HDD.

Mask value seems wrong. please update per HDD.

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

Can we check some persistence before declaring alarm?

Can we check some persistence before declaring alarm?

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.