Vinayakam Mani

align the indent.

align the indent.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

Use the get Acid mix control interval?

Use the get Acid mix control interval?

Updates the comments for all new variables.

Updates the comments for all new variables.

Remove this flag.

Remove this flag.

Remove this code.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change? Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let ...

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

Do we have a return confirmation that the command is accepted by DD?

Do we have a return confirmation that the command is accepted by DD?

Is the UF rate unit in ml/min (instead of hr.)?

Is the UF rate unit in ml/min (instead of hr.)?

Are we assuming the sub mode return is pre-gen sub mode always?

Are we assuming the sub mode return is pre-gen sub mode always?