application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 11 Jan 2021
10:37 pm

Behrouz NematiPour

DEN-5754: Implementation

- Code clean up

Options
    • -5
    • +5
    /denali.pro.user
    • -1
    • +2
    /denali.qrc
    • -71
    • +0
    /sources/gui/qml/components/CircleWithText.qml
    • -35
    • +23
    /sources/gui/qml/components/ConfirmTreatmentSubTable.qml
    • -2
    • +1
    /sources/gui/qml/components/GridSelection.qml
    • -0
    • +66
    /sources/gui/qml/components/StepBullet.qml
    • -0
    • +86
    /sources/gui/qml/components/StepIndicator.qml
    • -147
    • +22
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -1
    • +1
    /sources/gui/qml/globals/Colors.qml
    • -0
    • +5
    /sources/gui/qml/globals/Variables.qml
    • -5
    • +5
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -10
    • +10
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -8
    • +9
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -9
    • +9
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -10
    • +10
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
4:45 pm

plucia  (deleted user)

Thanks, these links are helpful

Thanks, these links are helpful

3:56 pm

Behrouz NematiPour

Thanks, only a Numeric keyboard in this case. Please also take a look at the KDAB training about the QtQuick keyboard handling, in https://www.youtube.com/watch?v=ilCekEOpNYM @ 5:40 using the Keys ...

Thanks, only a Numeric keyboard in this case.
Please also take a look at the KDAB training about the QtQuick keyboard handling, in https://www.youtube.com/watch?v=ilCekEOpNYM @ 5:40 using the Keys API to be able to navigate on 'enter' pressed.
that might be helpful.
I think it should be "enterPressed", "returnPressed", or both.

Please also take a look at the UX desing in the link : https://app.zeplin.io/project/5db0c175acfeac55e3cb879e/screen/5dbc8461bab7462c152cb34e

3:36 pm

plucia  (deleted user)

Okay, sure no problem. Do you want the full qwerty keyboard then or numeric-only for this screen?

Okay, sure no problem. Do you want the full qwerty keyboard then or numeric-only for this screen?

3:33 pm

Behrouz NematiPour

Thanks for providing the screenshots to compare. I would vote for the default style which covers half the screen since it is more standard and would be the same all over the application instead of ...

Thanks for providing the screenshots to compare.
I would vote for the default style which covers half the screen since it is more standard and would be the same all over the application instead of having different keyboard combinations and locations in different situations and prefer to relocate screen components and labeling to fit in the screen.
It can be like :

                                  Vitals Entry
                                ------------------
   systolic [   ___    ]        diastolic [   ___    ]        BPM [   ___    ]

(or labels at top)


and hide the keyboard on last entry BPM, 'enter' touch.
Also, please on the user 'enter' touch go to the next entry.

3:30 pm

plucia  (deleted user)

You can't adjust the size of the keyboard, change what buttons are available, or adjust the opaque black background that's blocking half the screen without adjusting the styling. In here you will ...

You can't adjust the size of the keyboard, change what buttons are available, or adjust the opaque black background that's blocking half the screen without adjusting the styling.

In here you will find a couple of screenshots for comparison:

Default numeric styling:
X:\Users\PeterL\ForBehrouz\Vitals_Entry_Default_Numeric_Keyboard.png

Custom numeric styling:
X:\Users\PeterL\ForBehrouz\Vitals_Numeric_Keyboard.png

Full Qwerty Keyboard with default styling:
X:\Users\PeterL\ForBehrouz\Full_Qwerty_Keyboard.png

10:21 am

Behrouz NematiPour

Very dangerous use of pointers please consider using none pointer variables. as an example why _lastSelectedDevice has been defined as a pointer? Please keep that in mind there is no guaranty that ...

Very dangerous use of pointers please consider using none pointer variables.
as an example why _lastSelectedDevice has been defined as a pointer?
Please keep that in mind there is no guaranty that your code will reach the pointer release, and exceptions can happen anytime.

Friday 08 Jan 2021
11:10 pm

Behrouz NematiPour

Why a simple name, address value set has been converted to a Jason Document by that complicated dereferencing and casting of pointers and passed over all the stacks of signal/slots instead of a sim...

Why a simple name, address value set has been converted to a Jason Document by that complicated dereferencing and casting of pointers and passed over all the stacks of signal/slots instead of a simple struct?

11:02 pm

Behrouz NematiPour

why 9999 used for default value instead of zero?

why 9999 used for default value instead of zero?

11:01 pm

Behrouz NematiPour

please use #pragma once

please use #pragma once

11:01 pm

Behrouz NematiPour

please move all the private member variables to the default private section of the class.

please move all the private member variables to the default private section of the class.

11:00 pm

Behrouz NematiPour

please use (const &) for all the slots down here.

please use (const &) for all the slots down here.

10:59 pm

Behrouz NematiPour

please a complete argument (const TYPE &vArgument)

please a complete argument (const TYPE &vArgument)

10:58 pm

Behrouz NematiPour

same here for arguments name

same here for arguments name

10:58 pm

Behrouz NematiPour

please use the 'v' for the argument name beginning.

please use the 'v' for the argument name beginning.

10:55 pm

Behrouz NematiPour

please use nullptr instead of the NULL.

please use nullptr instead of the NULL.

10:51 pm

Behrouz NematiPour

Please look at the zeplin, 3.3 Name New Treatment Screen for the text entry UX design.

Please look at the zeplin, 3.3 Name New Treatment Screen for the text entry UX design.

10:49 pm

Behrouz NematiPour

Where the color has been picked from? If it is from UX design from zeplin, keep that in mind it wasn't a final design and has been put there to imply that the page requires a keyboard. what is the ...

Where the color has been picked from?
If it is from UX design from zeplin, keep that in mind it wasn't a final design and has been put there to imply that the page requires a keyboard.
what is the default color?

10:42 pm

Behrouz NematiPour

Where these values come from and please define them in the Variables file under the PRS section if applicable?

Where these values come from and please define them in the Variables file under the PRS section if applicable?

10:40 pm

Behrouz NematiPour

same here.

same here.

10:40 pm

Behrouz NematiPour

same here.

same here.

10:40 pm

Behrouz NematiPour

same here.

same here.

10:39 pm

Behrouz NematiPour

Please don't forget the translation for all the translatable strings.

Please don't forget the translation for all the translatable strings.

10:37 pm

Behrouz NematiPour

Please change the file name to TextEntry or TextEdit to make it more general (but not TextInput which conflicts with QtQuick). Field most of the time refers to a database field which is not the cas...

Please change the file name to TextEntry or TextEdit to make it more general (but not TextInput which conflicts with QtQuick).
Field most of the time refers to a database field which is not the case all the time for this component.

10:31 pm

Behrouz NematiPour

why QtQuick.Controls imported?

why QtQuick.Controls imported?

10:29 pm

Behrouz NematiPour

Please don't use ";" until it's absolutely necessary, especially in qml codes.

Please don't use ";" until it's absolutely necessary, especially in qml codes.

10:26 pm

Behrouz NematiPour

please use "Item" instead of "Rectangle" with color as transparent when possible.

please use "Item" instead of "Rectangle" with color as transparent when possible.

10:25 pm

Behrouz NematiPour

please use "Item" instead of "Rectangle" with color as transparent when possible.

please use "Item" instead of "Rectangle" with color as transparent when possible.

10:24 pm

Behrouz NematiPour

please whenever possible use the QtQuick versions instead of the QtQuick.controls. So in this case TextInput can be used instead of TextField. And then please remove the "import QtQuick.Controls 2.12"

please whenever possible use the QtQuick versions instead of the QtQuick.controls.
So in this case TextInput can be used instead of TextField.
And then please remove the "import QtQuick.Controls 2.12"

10:20 pm

Behrouz NematiPour

Why does it even need styling? Couldn't we use the keyboard default styling? Please provide two of the default and styled screenshot versions of the keyboard for comparison.

Why does it even need styling?
Couldn't we use the keyboard default styling?
Please provide two of the default and styled screenshot versions of the keyboard for comparison.