UI-DEN-5751-1 UI-DEN-5751_Pre Treatment Ultrafiltration

closed on 01 Feb 21

Author

Reviewers

UI-DEN-5751_Pre Treatment Ultrafiltration

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 94

application 0
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
    - File MessageInterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File CircleWithText.qml 0 Remove
        
        File ConfirmTreatmentSubTable.qml 3 Remove
        
        File ConfirmTreatmentTable.qml 0 Remove
        
        File GridSelection.qml 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File ProgressCircle.qml 0 Remove
        
        File RangeSlider.qml 0 Remove
        
        File Slider.qml 0 Remove
        
        File SliderCreateTreatment.qml 0 Remove
        
        File SliderDoubleCreateTreatment.qml 0 Remove
        
        File StepBullet.qml 0 Remove
        
        File StepIndicator.qml 0 Remove
        
        File TickMarks.qml 0 Remove
        
        File TitleBarCreateTreatment.qml 0 Remove
        
        File TopMenuBarCreateTreatment.qml 0 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Fonts.qml 0 Remove
        
        File Variables.qml 8 Remove
      - Folder pages 0
        
        Folder pretreatment/create 0
        
        File PreTreatmentBase.qml 3 Remove
        
        File PreTreatmentConfirm.qml 0 Remove
        
        File PreTreatmentCreate.qml 6 Remove
        
        File PreTreatmentPrime.qml 0 Remove
        
        File PreTreatmentUltrafiltration.qml 0 Remove
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentUltrafiltrationConfirm.qml 3 Remove
        
        File TreatmentAdjustmentUltrafiltrationEdit.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationPaused.qml 0 Remove
        
        File TreatmentAdjustmentUltrafiltrationStart.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentUltrafiltration.qml 0 Remove
        
        File TreatmentBegin.qml 0 Remove
        
        File TreatmentConfirm.qml 0 Remove
        
        File TreatmentCreate.qml 0 Remove
        
        File TreatmentPrime.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder hd 0
      - Folder adjustment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
        
        File MTreatmentAdjustUltrafiltrationInitResponse.cpp 0 Remove
        
        File MTreatmentAdjustUltrafiltrationInitResponse.h 0 Remove
      - Folder alarm 0
        
        File MAlarmCleared.cpp 0 Remove
        
        File MAlarmCleared.h 0 Remove
        
        File MAlarmStatusData.cpp 6 Remove
        
        File MAlarmStatusData.h 0 Remove
        
        File MAlarmTriggered.cpp 6 Remove
        
        File MAlarmTriggered.h 0 Remove
    - File MModel.h 0 Remove
  - Folder view 0
    - Folder hd 0
      - Folder adjustment 0
        
        File VTreatmentAdjustmentUltrafiltrationInit.cpp 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationInit.h 0 Remove
      - Folder alarm 0
        
        File VAlarmStatus.cpp 0 Remove
      - Folder data 0
        
        File VTreatmentUltrafiltration.h 0 Remove
    - File VTreatmentBegin.h 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentEnd.cpp 0 Remove
    - File VView.h 0 Remove
- Folder unittests 0
  - File tst_messaging.cpp 3 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.h 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File en_US.udic 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 3 Remove
- Folder simulator 0
  - Folder plugins 0
    - Folder alarms 0
      - File interface.ui 0 Remove
      - File loader.py 12 Remove
    - Folder createtreatment 0
      - File interface.ui 0 Remove
      - File loader.py 6 Remove
    - Folder heparin 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder inlinebloodpressures 0
      - File interface.ui 0 Remove
      - File loader.py 3 Remove
    - Folder salinebolus 0
      - File interface.ui 0 Remove
      - File loader.py 3 Remove
    - Folder treatmentranges 0
      - File interface.ui 0 Remove
      - File loader.py 3 Remove
    - Folder treatmentstates 0
      - File interface.ui 0 Remove
      - File loader.py 3 Remove
    - Folder ultrafiltration 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - File __init__.py 0 Remove
  - Folder simulator 0
    - File dynamicloader.py 0 Remove
    - File interface.ui 0 Remove
    - File loader.py 0 Remove
    - File runtimewidget.py 0 Remove
  - File run.py 0 Remove
  - File runtimewidget.py 0 Remove
  - File simulator.ui 0 Remove
- Folder tst_CreateTreatment 0
  - File test.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	3h 57m	24	created a sub-task for this as DoubleSlider doesn't have ...
plucia (deleted user)	Reviewer - Complete	1h 36m	37	will be addressed later, RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	1h 5m	10	RESOLVED.
Total		6h 38m	71

Linked issues
- DEN-5751
- DEN-5754
- DEN-5830
- DEN-5833
- DEN-6022

#permalink

Objectives

Application :

Fixed comments in some files of the Pre-Treatment Create.
Removed not used SliderDoubleCreateTreatment.qml component.
A lot of code clean up and refactoring
cherry picked a fix from DEN-5830_AlarmDesign@51accb for the Treatment End message which has no payload.
Also made the interpretMessage() for received messages to be more identical to the DEN-5830_AlarmDesign to hopefully help merging easier.
Had a conversation with Syseng(Nic) and Fweng(Sean) and decided to have the fix somehow more understandable but there is no actual fix
and if that happens it would be the FW bug.
The modification is that the main progress bar will always have VTreatmentUltratiltration.minimum as minimum (current;y always zero) and
VTreatmentUltratiltration.maximum as maximum.
The UI always expects to get the vTreatmentRanges.treatmentRanges_Ultrafiltration_Volume_Min (adjustable min and slider min) greater than
vTreatmentUltrafiltration.ultrafiltration_RefUFVol (current uf volume delivered and current value on the progress bar) and so close to each other.
Removed the precision from VTreatmentUltrafiltration and moved into the Variables.
linked the pre-treatment ultrafiltration adjustment with the in-treatment ultrafiltration section and the adjustment flow.
added the rejection reason text to the pTx uf adj screen.
Fixed the message id of the ID_ConfirmTreatmentReq from 58 to 59
Enabled the priming button for now since there is no FW implementation.
Removed the unused flag of ALARM_ID_TEMPERATURE_SENSORS_INCONSISTENT
Removed the semi-colon at the end of the imports.
Added the new MVC for initial UF Volume adjustment messages (79/80).
reviewed the pre-treatment screens and modified
added the double range slider for Arterial and Venous
modified the treatmentBegin(ultrafiltration)
so many other tweaks.
reformat and commented out the message id debug log.

TestSuits:

Reverted back the end treatment button click to cover that message.
Fixed ConfirmPrimingBegin
Fixed Create Treatment
added the message id 80 for pTx uf adj rsp.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/gui/.../components/CircleWithText.qml Deleted

Click to load diff

/sources/.../components/SliderDoubleCreateTreatment.qml Deleted

Click to load diff

/sources/.../components/TopMenuBarCreateTreatment.qml Deleted

Click to load diff

/sources/gui/.../treatment/TreatmentBegin.qml Deleted

Click to load diff

/sources/.../treatment/TreatmentConfirm.qml Deleted

Click to load diff

/sources/gui/.../treatment/TreatmentCreate.qml Deleted

Click to load diff

/sources/gui/.../treatment/TreatmentPrime.qml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-5751-1

UI-DEN-5751_Pre Treatment Ultrafiltration

UI-DEN-5751-1 71

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-5751_Pre Treatment Ultrafiltration

UI-DEN-5751-1 71

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time