application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Aug 2021
2:30 pm

Behrouz NematiPour

DEN-9418: Code Review 0

Options
    • -8
    • +23
    /AlarmMapping.csv
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /en_US.udic
    • -2
    • +2
    /scripts/run.sh
    • -14
    • +29
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -9
    • +17
    /sources/view/settings/VNetworkModel.cpp
    • -1
    • +2
    /sources/view/settings/VNetworkModel.h
2:30 pm

Sean Nash

RESOLVED.

RESOLVED.

2:30 pm

Sean Nash

RESOLVED.

RESOLVED.

2:29 pm

Sean Nash

RESOLVED.

RESOLVED.

2:29 pm

Sean Nash

RESOLVED.

RESOLVED.

2:24 pm

Sean Nash

Missing brief for these methods.

Missing brief for these methods.

2:23 pm

Sean Nash

Missing brief.

Missing brief.

2:22 pm

Sean Nash

Missing brief.

Missing brief.

2:13 pm

Sean Nash

Missing brief.

Missing brief.

2:13 pm

Sean Nash

Missing brief.

Missing brief.

1:53 pm

Behrouz NematiPour

Updated.

Updated.

1:52 pm

Behrouz NematiPour

Updated.

Updated.

1:52 pm

Behrouz NematiPour

Updated.

Updated.

1:52 pm

Behrouz NematiPour

Updated.

Updated.

1:52 pm

Behrouz NematiPour

Updated.

Updated.

1:52 pm

Behrouz NematiPour

Updated.

Updated.

1:52 pm

Behrouz NematiPour

Updated.

Updated.

1:51 pm

Behrouz NematiPour

Updated.

Updated.

1:51 pm

Behrouz NematiPour

Updated.

Updated.

1:50 pm

Behrouz NematiPour

Updated. In UI Software we also have different TODO flags like TEST, DEBUG, FIXME, and so on. In this case, I used TEST.

Updated.
In UI Software we also have different TODO flags like TEST, DEBUG, FIXME, and so on.
In this case, I used TEST.

1:50 pm

Behrouz NematiPour

Removed.

Removed.

1:48 pm

Behrouz NematiPour

DEN-9418: Code Review 0

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +2
    /sources/canbus/MessageDispatcher.cpp
    • -18
    • +18
    /sources/canbus/MessageGlobals.h
    • -1
    • +0
    /sources/gui/qml/components/DebugDataColumn.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
1:35 pm

Behrouz NematiPour

It has only one parameter and is 15 bytes long. By definition, it is different than the others. 0x9900 153 0x020 Rsp Y HD UI HD serial number ASCII text - 15 bytes, not null term 0x8800 136 0x070...

It has only one parameter and is 15 bytes long.
By definition, it is different than the others.

0x9900 153 0x020 Rsp Y HD UI HD serial number ASCII text - 15 bytes, not null term
0x8800 136 0x070 Rsp Y DG UI DG serial number ASCII text - 15 bytes, not null term
1:32 pm

Behrouz NematiPour

It is a red line and has already been removed.

It is a red line and has already been removed.

1:21 pm

Sean Nash

If this is test code, add TODO to remove later.

If this is test code, add TODO to remove later.

1:20 pm

Sean Nash

Why not - 40? Can we remove?

Why not - 40? Can we remove?

1:19 pm

Sean Nash

Why commented out? Can we remove?

Why commented out? Can we remove?

1:14 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.

1:09 pm

Sean Nash

Should this be 1 * 15 for consistency?

Should this be 1 * 15 for consistency?

1:08 pm

Sean Nash

Comment doesn't match code.

Comment doesn't match code.