application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 01 Feb 2022
3:05 pm

Behrouz NematiPour

UI-BUG-S62: UI-BUG-S62-1

Addressed code reviews.

Options
    • -1
    • +1
    /denali.pro.user
    • binary
    /resources/images/Logo d-Qt-mod1.png
    • -1
    • +1
    /sources/bluetooth/BluetoothInterface.cpp
    • -3
    • +3
    /sources/bluetooth/BluetoothInterface.h
    • -12
    • +0
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
2:53 pm

Behrouz NematiPour

Couldn't find time to investigate more on this, So created a task for later code cleanup and refactoring. http://dvm-linux02:8080/browse/DEN-12031

Couldn't find time to investigate more on this,
So created a task for later code cleanup and refactoring.
http://dvm-linux02:8080/browse/DEN-12031

2:39 pm

Behrouz NematiPour

It's just code clean-up notes, ToDos with low priority and will be addressed when gets priority.

It's just code clean-up notes, ToDos with low priority and will be addressed when gets priority.

Friday 28 Jan 2022
11:09 am

Behrouz NematiPour

Merge branch 'UI_BUG_S63' into develop

Options
    • -1
    • +1
    /sources/gui/qml/pages/MainStack.qml
11:08 am

Behrouz NematiPour

DEN-11814: Heparin Minimum Dispensing Parameters Should Be 0.2

- Reverted back the Heparin min to 0.0 due to the slider's issue which disables the OFF feature, since the value 0.0 becomes an invalid.

- A minor update on the POST progress display to start when 0 to max of complete enum -1.

- An idea of fixing the slider touch issue. [Is DISABLED for now, for more test]

Options
    • -91
    • +1
    /cppcheck.err
    • -962
    • +0
    /cppcheck.log
    • -2
    • +2
    /denali.pro.user
    • -1
    • +1
    /sources/gui/qml/components/BackButton.qml
    • -2
    • +0
    /sources/gui/qml/components/Circle.qml
    • -1
    • +18
    /sources/gui/qml/components/Slider.qml
    • -1
    • +1
    /sources/gui/qml/pages/MainStack.qml
    • -1
    • +1
    /sources/gui/qml/pages/disinfect/DisinfectBase.qml
    • -2
    • +3
    /sources/gui/qml/pages/disinfect/DisinfectStack.qml
    • -3
    • +3
    /sources/gui/qml/pages/pretreatment/PreTreatmentWaterSampleStack.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -2
    • +2
    /sources/view/VTreatmentCreate.h
    • -1
    • +5
    /sources/view/hd/data/post/VHDPOSTData.h
Wednesday 26 Jan 2022
2:14 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

2:14 pm

Michael Garthwaite

Disregard. Found where it is used.

Disregard. Found where it is used.

2:13 pm

Michael Garthwaite

What is the purpose of this alias?

What is the purpose of this alias?

2:05 pm

Sean Nash

Why commented out?

Why commented out?

2:04 pm

Sean Nash

Why commented out?

Why commented out?

2:03 pm

Sean Nash

Why is this commented out?

Why is this commented out?

2:02 pm

Sean Nash

When will we do this?

When will we do this?

1:53 pm

Sean Nash

File name does not appear to match image.

File name does not appear to match image.

1:36 pm

Michael Garthwaite

The declaration in the header file has const for all 3 parameters.

The declaration in the header file has const for all 3 parameters.

Monday 24 Jan 2022
12:55 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Thursday 20 Jan 2022
9:13 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
Wednesday 19 Jan 2022
8:55 pm

Behrouz NematiPour

Merge branch 'UI_BUG_S63' into develop

Options
8:55 pm

Behrouz NematiPour

DEN-9704: Missing acknowledgement confirmation message/alarm when leaving BP/HR blank

- A typo caused the BP/HR entry timer disabled.

Options
    • -1
    • +1
    /denali.pro.user
    • -4
    • +4
    /sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp
10:39 am

Behrouz NematiPour

Merge branch 'UI_BUG_S62' into develop

Options
    • -0
    • +1
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
10:38 am

Behrouz NematiPour

DEN-11825: BP/HR screen has no instruction for user to read from bluetooth cuff or enter information

- Center aligned the notification

Options
    • -0
    • +1
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
9:35 am

Behrouz NematiPour

That is a very good point. No one ever mentioned that. Let me investigate, why I had all these repeated else. Could be for performance not to check next, but there is another way for that too. If ...

That is a very good point.
No one ever mentioned that.

Let me investigate, why I had all these repeated else.
Could be for performance not to check next, but there is another way for that too.
If I can't find a quick answer for that let me create a case for that since it is everywhere.

9:32 am

Dara Navaei

RESOLVED.

RESOLVED.

9:29 am

Behrouz NematiPour

There has to be and there is. It is just a long line and those little ones are at the end.

There has to be and there is.
It is just a long line and those little ones are at the end.

Tuesday 18 Jan 2022
9:00 pm

Dara Navaei

It seems you have multiple else statements that do the same, is that right? If yes, why multiple elses?

It seems you have multiple else statements that do the same, is that right? If yes, why multiple elses?

8:57 pm

Dara Navaei

Isn't is safer to have a break at the end of each case?

Isn't is safer to have a break at the end of each case?

7:49 pm

Behrouz NematiPour

Merge branch 'UI_BUG_S62' into develop

Options
7:49 pm

Behrouz NematiPour

DEN-11814: Heparin Minimum Dispensing Parameters Should Be 0.2

- updated the min range regarding the recent PRS-347, PRS-348

- Fixed the minimum precision of the heparin.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +1
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -0
    • +3
    /sources/gui/qml/globals/Variables.qml
    • -0
    • +2
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -2
    • +2
    /sources/view/VTreatmentCreate.h
7:27 pm

Behrouz NematiPour

Merge branch 'UI_BUG_S62' into develop

Options
    • -0
    • +9
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
7:26 pm

Behrouz NematiPour

DEN-10422: Dialysate Flow Rate maximum rate selectable in Treatment does not meet PRS resolution

Options
    • -62
    • +61
    /sources/view/VTreatmentCreate.h
    • -4
    • +5
    /sources/view/hd/data/VTreatmentRanges.cpp
6:47 pm

Behrouz NematiPour

DEN-8145: Issues with UI Create Treatment screen

Remainder items (summary):

- 3) Discuss whether to keep the manufacturing default on the slider since the user needs to confirm each parameter: Agreed to set to the minimum value

- 7) Arterial Pressure and Venous Pressure should be consistent with other parameters, the unit should be shown at the end: will be updated to have the units located in the title of the slider.

- Also fixed the title coloring when the slider has not been adjusted yet.

Options
    • -1
    • +1
    /denali.pro.user
    • -4
    • +4
    /sources/gui/qml/components/RangeSlider.qml
    • -5
    • +6
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
    • -14
    • +66
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -14
    • +14
    /sources/view/VTreatmentCreate.h