Activity application/

8:56 am

Dara Navaei

More
24a7133
changed 1 file
DEN-13226_UI_Unit_Testing

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

6:48 pm

Dara Navaei

More
dc43f66
changed 1 file
master, @Environement_Swith and 199 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -2
- +2
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

6:47 pm

Behrouz NematiPour

More
e501990
changed 0 files
master, @Environement_Swith and 199 more

Merge branch 'UI_BUG_S63' into develop

12:49 pm

Dara Navaei , Michael Garthwaite and Sean Nash

More
UI-BUG-S63-2
finished reviewing

10:35 am

Behrouz NematiPour

More
Re: UI-BUG-S63-2
replied to Dara Navaei

Actually, this is correct. And it should not have parenthesis like you said, otherwise it becomes incorrect. if I write it like : ( ( x * ( maximum - minimum ) ) / width ) + minimum then too man...

Actually, this is correct.
And it should not have parenthesis like you said, otherwise it becomes incorrect.
if I write it like :

 ( ( x * ( maximum - minimum ) ) / width ) + minimum

then too many /redundant parentheses make it confusing.

10:24 am

Dara Navaei

More
Re: UI-BUG-S63-2
commented on review

To make sure the addition is done first, should you put ( width + minimum ) ?

10:16 am

Dara Navaei

More
6b32e13
changed 1 file
master, @Environement_Swith and 199 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

12:30 pm

Behrouz NematiPour

More
Re: UI-BUG-S63-2
replied to Sean Nash

Thanks, Updated.

Thanks,
Updated.

12:30 pm

Behrouz NematiPour

More
Re: UI-BUG-S63-2
replied to Sean Nash

Thanks, Aligned.

Thanks,
Aligned.

12:29 pm

Behrouz NematiPour

More
Re: UI-BUG-S63-2
replied to Sean Nash

This is part of an ongoing investigation on how to fix the slider touch margin issue. I am still working on it. It worked somehow for the slider with lower resolution but for sliders, with a high r...

This is part of an ongoing investigation on how to fix the slider touch margin issue.
I am still working on it.
It worked somehow for the slider with lower resolution but for sliders, with a high resolution, it causes a handler jump which makes it less user-friendly.
Added clarifying comment.

12:28 pm

Behrouz NematiPour

More
38cb7a4
changed 1 file
master, @Environement_Swith and 200 more UI-BUG-S63-2

UI-BUG-S63: UI-BUG-S63-2: Addressed the code review comments.

- -6
- +7
/sources/gui/qml/components/Slider.qml
- History
- Source
- Diff
/sources/gui/qml/components/Slider.qml

11:41 am

Behrouz NematiPour

More
Re: UI-BUG-S63-2
replied to Sean Nash

This is the Trends screen. It is needed since it has not been implemented yet has been commented out.

This is the Trends screen.
It is needed since it has not been implemented yet has been commented out.

9:19 pm

Dara Navaei

More
eaae7a9
changed 1 file
master, @Environement_Swith and 199 more

Bamboo Commit: Updated MAlarmMapping.cpp

- -1
- +1
/sources/model/hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
/sources/model/hd/alarm/MAlarmMapping.cpp

5:16 pm

Michael Garthwaite

More
10f39b6
changed 14 files
master, @Environement_Swith and 199 more UI-DEN-11980-1

DEN-11980: Split Flows Data Model to Blood Flow data and Inlet Data Models. Updated Views to reflect new message protocol for Blood Flow and Inlet Flow. Updated Diagnostic Dialog to reflect new message values.