application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 09 Mar 2023
9:41 am

vduong  (deleted user)

I think we wanted the alias and not the bool. I vaguely remember suggesting the change to alias. This could've been a revert change. I am not sure. I will change it back to alias

I think we wanted the alias and not the bool. I vaguely remember suggesting the change to alias. This could've been a revert change. I am not sure. I will change it back to alias

9:39 am

vduong  (deleted user)

This is after the text property. I removed the newline between them as a change

This is after the text property. I removed the newline between them as a change

9:39 am

vduong  (deleted user)

Moved onTextChanged line and removed extra newline

Moved onTextChanged line and removed extra newline

9:37 am

vduong  (deleted user)

Will make note. Changed comment to reflect.

Will make note. Changed comment to reflect.

9:35 am

vduong  (deleted user)

Updated.

Updated.

9:35 am

vduong  (deleted user)

It will display two same values with one tick. I have removed the check.

It will display two same values with one tick.

I have removed the check.

9:34 am

vduong  (deleted user)

Updated, thank you

Updated, thank you

Tuesday 07 Mar 2023
6:47 pm

Behrouz NematiPour

please remove an extra empty line which is not necessary.

please remove an extra empty line which is not necessary.

6:45 pm

Behrouz NematiPour

Didn't we find an issue with changing this to bool instead of alias while were testing?

Didn't we find an issue with changing this to bool instead of alias while were testing?

6:33 pm

Behrouz NematiPour

in general, if the comment is for the entire if block put it in front of the if block. also for the else at line 66.

in general, if the comment is for the entire if block put it in front of the if block.
also for the else at line 66.

6:30 pm

Behrouz NematiPour

please move after the text property and remove the extra empty line.

please move after the text property and remove the extra empty line.

6:30 pm

Behrouz NematiPour

please move after the text property.

please move after the text property.

6:29 pm

Behrouz NematiPour

Please let the following calculation of the overlap do the separation. Otherwise will completely overlap and eventually displays one value which would be confusing. And also creates a position jump.

Please let the following calculation of the overlap do the separation.
Otherwise will completely overlap and eventually displays one value which would be confusing.
And also creates a position jump.

6:28 pm

Behrouz NematiPour

typo: ajust => adjust

typo: ajust => adjust

6:25 pm

Behrouz NematiPour

Please change the minimum gap to 4. I think when tested, 4 was sufficient.

Please change the minimum gap to 4.
I think when tested, 4 was sufficient.

Sunday 05 Mar 2023
7:46 pm

Behrouz NematiPour

7:45 pm

vduong  (deleted user)

RESOLVED

RESOLVED

7:39 pm

vduong  (deleted user)

RESOLVED

RESOLVED

7:39 pm

vduong  (deleted user)

RESOLVED

RESOLVED

7:38 pm

Behrouz NematiPour

The reason is separation and keeping the logic of the Slider and its ON/OFF switch clear and non-confusing, and independent. Like right now that I had a wrong fix and I easily just changed the conn...

The reason is separation and keeping the logic of the Slider and its ON/OFF switch clear and non-confusing, and independent.
Like right now that I had a wrong fix and I easily just changed the connection related to the fix I had not changed the Slider implementation itself.

Saturday 04 Mar 2023
9:09 am

vduong  (deleted user)

Friday 03 Mar 2023
5:57 pm

vduong  (deleted user)

I disagree. If we bind the value here to the "active" property, the value it takes is whatever "active" has when the component gets created.

I disagree. If we bind the value here to the "active" property, the value it takes is whatever "active" has when the component gets created.

4:36 pm

Behrouz NematiPour

Unfortunately, we can't and it created a binding loop. I tried it.

Unfortunately, we can't and it created a binding loop.
I tried it.

4:35 pm

Behrouz NematiPour

This is the default value of the heparinStopTime. If you bind to the active of the dispensing switch nothing will happen, since the switch by default is active=false and if active is not changed, n...

This is the default value of the heparinStopTime.
If you bind to the active of the dispensing switch nothing will happen, since the switch by default is active=false and if active is not changed, no signal, therefore no property change will happen, and the enable remains unchanged, as true.

3:59 pm

vduong  (deleted user)

Binding here for instance, enabled: _heparinDispensingRateSwitch.active

Binding here for instance, enabled: _heparinDispensingRateSwitch.active

3:58 pm

vduong  (deleted user)

I believe we can bind the active state of _heparinDispensingRateSwitch and _heparinStopTime together.

I believe we can bind the active state of _heparinDispensingRateSwitch and _heparinStopTime together.

3:57 pm

vduong  (deleted user)

Is there a specific reason to why we are opting to use a connection here instead of handling the signal in the component body? (ie: line 181 further down?)

Is there a specific reason to why we are opting to use a connection here instead of handling the signal in the component body? (ie: line 181 further down?)

3:06 pm

jishii  (deleted user) , Sean Nash and Michael Garthwaite

2:01 pm

Dara Navaei

UI-DEN-14866_UI BN S92
UI-DEN-14866_UI BN S92
12:09 pm

Behrouz NematiPour