application

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Mar 2023
1:10 am

Behrouz NematiPour

Merge branch 'DEN-14937-UI-VD-S93-ServicePass' into staging

Options
1:07 am

Behrouz NematiPour

Fixed too.

Fixed too.

1:07 am

Behrouz NematiPour

Great catch, Thank a lot Sean for catching that. It is fixed.

Great catch,
Thank a lot Sean for catching that.
It is fixed.

1:06 am

Behrouz NematiPour

CR: Addressing Code Review comment UI-DEN-14936-1#c16983

http://devapps.diality.us:8060/cru/UI-DEN-14936-1#c16983

Options
    • -40
    • +40
    /sources/model/dg/data/MDGConductivityData.cpp
    • -1
    • +1
    /sources/model/dg/data/MDGConductivityData.h
1:04 am

Behrouz NematiPour

Not clear what you want me to do here?

Not clear what you want me to do here?

12:37 am

Vy <vduong@sunriselabs.com>

DEN-14955 Tx Create Rejection - Include the type buttons' reject reason - Modify to make gridSelection title color changeable

Options
    • -0
    • +1
    /sources/gui/qml/components/GridSelection.qml
    • -0
    • +10
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -0
    • +6
    /sources/view/VTreatmentCreate.cpp
    • -0
    • +6
    /sources/view/VTreatmentCreate.h
12:11 am

Behrouz NematiPour

DEN-15017 Ultrafiltration Volume Cannot Be Set to 0 L

revert back the commit e454ad

Options
    • -0
    • +2
    /sources/gui/qml/globals/Variables.qml
    • -1
    • +1
    /sources/gui/qml/pages/pretreatment/connection/PreTreatmentUltrafiltration.qml
Wednesday 29 Mar 2023
11:38 pm

vduong  (deleted user)

4:57 pm

jreaume  (deleted user)

FIXMEs in /sources/view/settings/VSettings.cpp will be addressed in future revision.

FIXMEs in /sources/view/settings/VSettings.cpp will be addressed in future revision.

4:51 pm

jreaume  (deleted user) , jishii  (deleted user) and Behrouz NematiPour

3:50 pm

Sean Nash

In post-treatment, there are a few states to work through to ensure reservoirs get drained: /* Post-Treatment drain reservoirs state machine. */ typedef enum Drain_States { DRAIN_DG_DEPRIME_STATE ...

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

3:29 pm

Sean Nash

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

3:27 pm

Sean Nash

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

12:52 pm

Vy <vduong@sunriselabs.com>

DEN-14955 Slider - Update the other sliders with switches in the preTx Create screen to also handle properly the on/off-inactive/active state

Options
    • -15
    • +20
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
12:01 pm

Vy <vduong@sunriselabs.com>

DEN-14955 Sliders - Update code to properly handle the ON/OFF inactive/active visual state - Remove active setting of Heparin Stop slider in pre Tx create

Options
    • -18
    • +34
    /sources/gui/qml/components/Slider.qml
    • -2
    • +13
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -32
    • +53
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
7:40 am

Vy <vduong@sunriselabs.com>

DEN-14955 Slider - add missing }

Options
    • -0
    • +1
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
7:27 am

Behrouz NematiPour

DEN-11539: Service password initial setup

- removed the console log debug line

Options
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsStack.qml
7:05 am

Behrouz NematiPour

DEN-11539: Service password initial setup

- added hashing for the service password and did some clean up.

- improved the navigation

- made the service password mandatory to navigate to the service menu, so HD message can't navigate the UI to service screen without user entering the password.

Options
    • -10
    • +9
    /sources/gui/qml/pages/UserConfirmation.qml
    • -36
    • +24
    /sources/gui/qml/pages/settings/SettingsStack.qml
    • -20
    • +56
    /sources/view/settings/VSettings.cpp
    • -5
    • +8
    /sources/view/settings/VSettings.h
Tuesday 28 Mar 2023
4:55 pm

Vy <vduong@sunriselabs.com>

DEN-14955 ServicePassword - Add secondary password line input to userConfirmation - Add logic for checking password entry - Add a mock encrypt function to signify needing encryption

Options
    • -4
    • +48
    /sources/gui/qml/pages/UserConfirmation.qml
    • -10
    • +28
    /sources/gui/qml/pages/settings/SettingsStack.qml
    • -0
    • +5
    /sources/view/settings/VSettings.cpp
    • -4
    • +5
    /sources/view/settings/VSettings.h
3:49 pm

vduong  (deleted user)

Resolved.

Resolved.

3:47 pm

Vy <vduong@sunriselabs.com>

DEN-14955 Tx Create Rejection - Update code base on feedback from Behrouz on CR

Options
    • -1
    • +1
    /sources/gui/qml/globals/Variables.qml
    • -57
    • +56
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
2:29 pm

Vy <vduong@sunriselabs.com>

DEN-14955 Slider Bug fix - DEN-15026 Correct handling for slider and switch on/off

Options
    • -7
    • +2
    /sources/gui/qml/components/Slider.qml
    • -6
    • +5
    /sources/gui/qml/components/SliderCreateTreatment.qml
12:49 pm

Behrouz NematiPour

Please use Changed and align

Please use Changed
and align

11:48 am

Vy <vduong@sunriselabs.com>

DEN-14955 - Slider fix DEN-15028 - Related the heparin stop time slider active state to the heparin dispensing active state

Options
    • -4
    • +6
    /sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
6:47 am

Vy <vduong@sunriselabs.com>

DEN-14955 Service Password - Add a validation CPP function for QML to call to check entry conforms to rules

Options
    • -0
    • +7
    /sources/gui/qml/pages/settings/SettingsStack.qml
    • -0
    • +27
    /sources/view/settings/VSettings.cpp
    • -0
    • +3
    /sources/view/settings/VSettings.h
6:18 am

Behrouz NematiPour

DEN-14853 UI Out Of Sync With Firmware On Handled Messages

Options
    • -16
    • +27
    /main.cpp
    • -1
    • +1
    /sources/canbus/MessageDispatcher.h
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -3
    • +9
    /sources/gui/qml/components/DebugDataColumn.qml
    • -23
    • +22
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -0
    • +6
    /sources/gui/qml/globals/Fonts.qml
    • -5
    • +57
    /sources/model/dg/data/MDGValvesStatesData.cpp
    • -6
    • +46
    /sources/model/dg/data/MDGValvesStatesData.h
    • -2
    • +3
    /sources/utility/types.cpp
    • -21
    • +15
    /sources/view/dg/data/VDGValvesStatesData.cpp
    • -7
    • +14
    /sources/view/dg/data/VDGValvesStatesData.h
Monday 27 Mar 2023
7:28 pm

Behrouz NematiPour

DEN-14853 UI Out Of Sync With Firmware On Handled Messages

Options
    • -1
    • +2
    /sources/canbus/MessageDispatcher.h
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -13
    • +21
    /sources/model/dg/data/MDGROPumpData.cpp
    • -12
    • +18
    /sources/model/dg/data/MDGROPumpData.h
    • -5
    • +7
    /sources/view/dg/data/VDGROPumpData.cpp
    • -4
    • +6
    /sources/view/dg/data/VDGROPumpData.h
4:02 pm

Dara Navaei

UI-DEN-14937-UI-VD-S93 [ServicePass]
UI-DEN-14937-UI-VD-S93 [ServicePass]
10:02 am

Vy <vduong@sunriselabs.com>

DEN-14955 : DEN-13152 bug fix - Fix slider to correctly accept value changes outside of slider-action induced changes

Options
    • -1
    • +28
    /sources/gui/qml/components/Slider.qml
8:27 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp