application

Clone Tools

Stats

Commits this week: 4
Total Committers: 14
Last Commit: 27 Mar
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 Sep 2023
3:52 pm

Vy <vduong@sunriselabs.com>

DEN-16319: Updated - UI log does not record blood pressure cuff bluetooth pairing

Modify the logged message to better indicate the bluetooth connection and paired status

Options
    • -1
    • +1
    /sources/bluetooth/BluetoothInterface.cpp
    • -3
    • +4
    /sources/view/settings/VBluetooth.cpp
3:08 pm

Vy <vduong@sunriselabs.com>

DEN-16319: Updated - UI log does not record blood pressure cuff bluetooth pairing

Remove unused bt model constructors in MBluetooth

Make use of the devicePair member variable, removing added isPaired

Remove pairing getter function

Options
    • -19
    • +4
    /sources/bluetooth/BluetoothInterface.cpp
    • -1
    • +0
    /sources/bluetooth/BluetoothInterface.h
    • -24
    • +0
    /sources/model/settings/MBluetooth.cpp
    • -17
    • +0
    /sources/model/settings/MBluetooth.h
    • -6
    • +2
    /sources/view/settings/VBluetooth.cpp
2:09 pm

Behrouz NematiPour

not clear what it means.

not clear what it means.

2:09 pm

vduong  (deleted user)

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

In bluetoothInterface.cpp, there's a set of macros towards the top. NOTIFY_DEVICE_CONNECT and NOTIFY_DEVICE_DISCONNECT

2:08 pm

vduong  (deleted user)

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

I think actually, we should connected as paired state. As the re-connection is truly a re-connection after a connection/pairing has been established

2:08 pm

Behrouz NematiPour

where do you use this ctor?

where do you use this ctor?

2:07 pm

Behrouz NematiPour

I remember and and can we use reconnect as a Paired State.

I remember and and can we use reconnect as a Paired State.

2:03 pm

vduong  (deleted user)

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

2:02 pm

Behrouz NematiPour

when do we know if that is paired, I think the ticket wants that one, right?

when do we know if that is paired, I think the ticket wants that one, right?

2:02 pm

vduong  (deleted user)

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

The shorter constructor is setting the local* values, I am saving the device name and address. Also, the error member variable is defaulted to 0 in the .h file.

1:52 pm

Behrouz NematiPour

move these two in the same location it was, to keep the order.

move these two in the same location it was, to keep the order.

1:43 pm

Behrouz NematiPour

make them one-liner in front of the if/else and align.

make them one-liner in front of the if/else and align.

1:41 pm

Behrouz NematiPour

make it bool isPaired();

make it
bool isPaired();

1:35 pm

Behrouz NematiPour

please use the shorter constructor provided. the error needs to be initialized as well, then it becomes the simple one.

please use the shorter constructor provided.
the error needs to be initialized as well, then it becomes the simple one.

11:05 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
11:04 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Friday 01 Sep 2023
3:41 pm

Behrouz NematiPour

DEN-16326: UI: Add the OS Version in the information screen

ApplicationPOST: added the functions

Options
    • -5
    • +50
    /sources/ApplicationPost.cpp
    • -22
    • +27
    /sources/ApplicationPost.h
    • -0
    • +6
    /sources/storage/StorageGlobals.cpp
    • -0
    • +6
    /sources/storage/StorageGlobals.h
3:07 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
3:06 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
12:05 pm

Dara Navaei

UI-DEN-16335_UI VD S105 Disable confirm device config - [READY]
UI-DEN-16335_UI VD S105 Disable confirm device config - [READY]
10:17 am

Vy <vduong@sunriselabs.com>

DEN-16235: Fixed - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed more than once

Add logic to properly handle disabling the confirm button when the device configuration is complete

Add a command to compare two directories for sameness

Add correct displaying of the completion of the device configurations

Options
    • -0
    • +3
    /sources/device/DeviceController.cpp
    • -0
    • +1
    /sources/device/DeviceModels.h
    • -1
    • +2
    /sources/device/DeviceView.cpp
    • -0
    • +1
    /sources/device/DeviceView.h
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsManufacturingSetup.qml
    • -0
    • +30
    /sources/storage/FileHandler.cpp
    • -0
    • +1
    /sources/storage/FileHandler.h
    • -0
    • +1
    /sources/storage/Settings.cpp
Thursday 31 Aug 2023
8:16 pm

Behrouz NematiPour

DEN-16132: Check Marks Do Not Appear during Consumables Self Test

Options
    • -3
    • +3
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
8:09 pm

Behrouz NematiPour

DEN-16132: Check Marks Do Not Appear during Consumables Self Test

Options
    • -4
    • +4
    /sources/gui/qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
    • -12
    • +12
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
    • -3
    • +3
    /sources/gui/qml/pages/settings/SettingsDeviceRegistration.qml
4:54 pm

vduong  (deleted user)

RESOLVED

RESOLVED

4:46 pm

Vy <vduong@sunriselabs.com>

DEN-16319: Fixed - UI log does not record blood pressure cuff bluetooth pairing

Add bool status to the MBluetooth for paired state

Update the notifyStateChanged for the Connect/disconnect state to properly log

Add pairing check function in the bluetooth interface to allow querying of paired state

Options
    • -2
    • +19
    /sources/bluetooth/BluetoothInterface.cpp
    • -1
    • +1
    /sources/bluetooth/BluetoothInterface.h
    • -0
    • +11
    /sources/model/settings/MBluetooth.cpp
    • -0
    • +9
    /sources/model/settings/MBluetooth.h
    • -2
    • +13
    /sources/view/settings/VBluetooth.cpp
11:51 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
11:50 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
11:28 am

vduong  (deleted user)

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

11:26 am

vduong  (deleted user)

her. => here.

her. => here.

11:26 am

vduong  (deleted user)

RESOLVED

RESOLVED