Logo Diality.png

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

Fixed the indentation

Fixed the indentation

I don't see ending bracket for this if. Does this even build?

I don't see ending bracket for this if. Does this even build?

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Seems like as part of modern C++ the equal operator is no longer needed. I need to investigate more to completely remove it.

Seems like as part of modern C++ the equal operator is no longer needed.
I need to investigate more to completely remove it.

This function is a slot to debug the behavior of the power dialog for now The entire qml file may later be removed. We had some conversations to combine the power message into confirmation and remo...

This function is a slot to debug the behavior of the power dialog for now
The entire qml file may later be removed.
We had some conversations to combine the power message into confirmation and remove the power qml, models, and so on.

The body of this function looks all commented out. Is this function necessary?

The body of this function looks all commented out. Is this function necessary?

Why commented out?

Why commented out?

Align function bodies.

Align function bodies.

Align "=".

Align "=".

UI-DEN-14294_UI BN S84
UI-DEN-14294_UI BN S84
DEN-14391 , DEN-14393 : Qt 5.15.10 [QML run-time issues]

- Fixed all the QML warning and errors

- Enabled the Clang-Tidy, Clazy and cppcheck and fixed some.

- Removed unused images

- made the Denali POST logo transparent.

  1. … 56 more files in changeset.
RESOLVED

RESOLVED

Leo, Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will r...

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

seems like when I replied the emails were not working Just as a reminder.

seems like when I replied the emails were not working
Just as a reminder.

Thanks for the comment. static class member variable can not be initialized in header. Please take a look at the applicationcontroller.cpp@21. It has been initialized with nullptr. Note : To see ...

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

initialize with nullptr for consistency

initialize with nullptr for consistency

UI-DEN-626_UI Power Off Screen
UI-DEN-626_UI Power Off Screen
DEN-629 : Implementation

- Implementing components

- Added Copyright

- Restructured the code.

  1. … 53 more files in changeset.