PBo connect_72.png

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED.

RESOLVED.

RESOLVED

RESOLVED

Fixed. Thanks for your attention to the details.

Fixed.
Thanks for your attention to the details.

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

Added

Added

Needs function header?

Needs function header?

RESOLVED

RESOLVED

that is fine because...

that is fine because...

it is a test for the code review demo

it is a test for the code review demo

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

The code was old and not up to our standard. It was in the middle of a huge improvement and test. It has been completely removed from the screen and moved to the component to avoid redundant code c...

The code was old and not up to our standard.
It was in the middle of a huge improvement and test.
It has been completely removed from the screen and moved to the component to avoid redundant code copy/paste.

The code was old and not up to our standard. It was in the middle of a huge improvement and test. It has been completely removed from the screen and moved to the component to avoid redundant code c...

The code was old and not up to our standard.
It was in the middle of a huge improvement and test.
It has been completely removed from the screen and moved to the component to avoid redundant code copy/paste.

This is a debug code that will be enabled to trace the screen stack. if was only a return, changed to an if to make it conditional for later use.

This is a debug code that will be enabled to trace the screen stack.
if was only a return, changed to an if to make it conditional for later use.

Why commented out?

Why commented out?

Why commented out?

Why commented out?

Looks like the rest of this function is dead code. Why are we returning here?

Looks like the rest of this function is dead code. Why are we returning here?

UI-DEN-10602_UI DEV Add PatientID PreTreatment
UI-DEN-10602_UI DEV Add PatientID PreTreatment
RESOLVED

RESOLVED

From what I can tell the dg command is separated from the hd command which is good. Please let me know when your code is ready to be merged to staging and I will handle it. Also for the next featur...

From what I can tell the dg command is separated from the hd command which is good.
Please let me know when your code is ready to be merged to staging and I will handle it.
Also for the next feature you're working on please branch off of the latest staging.

I don't have dg_simulator. It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.

I don't have dg_simulator.
It would be a merge task later to merge this code into the staging, I think it's out of the code review scope.

The dg simulator needs to be used for dg responses here still

The dg simulator needs to be used for dg responses here still