canbus.cpp

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI Staging Unreviewed Commits
UI Staging Unreviewed Commits
RESOLVED

RESOLVED

RESOLVED.

RESOLVED.

Leo, Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will r...

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

seems like when I replied the emails were not working Just as a reminder.

seems like when I replied the emails were not working
Just as a reminder.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Regarding to improve it and make it more general added a repeater so we can have from 1 to n (depending on the text size of menu items.)

Regarding to improve it and make it more general added a repeater so we can have from 1 to n (depending on the text size of menu items.)

It has been updated in the other code review here I just removed the residue.

It has been updated in the other code review here I just removed the residue.

For now it's 250000 and coordinated with FW. When settings and configuration module implemented this will be set able.

For now it's 250000 and coordinated with FW.
When settings and configuration module implemented this will be set able.

How was this made a more general component without any code being added?

How was this made a more general component without any code being added?

Have we coordinated with FW Team to make sure this is the fixed CAN Bus bit rate that is planned to be used?

Have we coordinated with FW Team to make sure this is the fixed CAN Bus bit rate that is planned to be used?

DEN-UI-608_CAN Integration on UI
DEN-UI-608_CAN Integration on UI
DEN-608 : CAN Integration on UI

- Redesigned the code to be thread safe

- Implemented signal slots to connect all the classes from can to GUI and vice versa.

  1. … 25 more files in changeset.
Thanks for the comment. static class member variable can not be initialized in header. Please take a look at the applicationcontroller.cpp@21. It has been initialized with nullptr. Note : To see ...

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

initialize with nullptr for consistency

initialize with nullptr for consistency

UI-DEN-626_UI Power Off Screen
UI-DEN-626_UI Power Off Screen