messagebuilder.cpp

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Resolve the merge conflicts of master into logging (#1 pass)

- This the first pass of the merging otherwise the code cannot be merged and committed.

- Next need to look at the code completely and see what has been merged and resolved automatically by git.

  1. … 71 more files in changeset.
3883: Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 9 more files in changeset.
DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 47 more files in changeset.
FW Support for HD/DG Debug Text & HDOpMode.

- Added a newly added channel to the list of listened channels eChlid_DG_UI = 0x070

- The MessageBuilder::getActionId implementation has been improved.

- New Messages has been added and enum/length defined as well.

- Message interpreter code has been improved to be easily modifiable.

- Changed the message ID enum ID_PowerOffBroadcast to ID_ShuttingDown.

- Added HDOperationMode to the setting screen.

- Made the floating point rounding optional by a #define and disabled the rounding for now.

- Inherit the MPowerOff Model from MAbstract as a new design.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 31 more files in changeset.
Updated the Copyright with the current year and replaced tabs with 4 spaces

  1. … 198 more files in changeset.
DEN-3874 : HW Support [Per Peman's Email]

- Unified All the Data messages to use the newly created parent model MAbstract.

- Cleaned up the logging class.

- Removed log_once macros.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 31 more files in changeset.
DEN-3874 : HW Support [Per Peman's Email]

- Another try to make the code more clean.

- Qml doesn't accept enums with first letter non-capital [id => ID_]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 31 more files in changeset.
DEN-3874 : HW Support [Per Peman's Email]

- Just to keep the code. Needs clean up.

- Don't forget Logs (DG, HD is different)

- So many more.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 141 more files in changeset.
DEN-3880 : Implementation

- Added Alarm Triggered Model

- Added Alarm Cleared Model

- Added Treatment State Model

- "UI," as Event Source to the Initialized and Some Other Event Messages for better logging

- Updated Ack messages and made them nicer for logging.

- Added DGCheckIn as a message to be logged.

- Stored Unit texts as a read only property in Variables qml file which had multiple definition multiple places.

- Changed the toString of models to use comma instead of parenthesis to be easily used in Excel as a CSV file format.

- Found a bug in TreatmentAdjustmentUltrafiltrationConfirm Screen slot which had volume defined as int that actually is a float value and causes the float to be truncated also the volume should be traslated int the VTreatmentAdjustmentUltrafiltratinConfirm to mL from Liter. Although HD wasn't using that value and was not complaining about it.

- Changed the current pew-set Volume value in the TreatmentAdjustmentUltrafiltrationEdit screen to be the current max value which is actually going to be changed by user.

- Changed to use the reference Volume to be used as the current collected volume in the Ultrafiltration section of the main treatment screen and the other Ultrafiltration adjustment screen that using it (Start. Paused, Edit).

- Added toString to the request models to be used for logging.

- Refactored the Message Interpreter response methods to be unique like the other improved latest methods (get<Method>s removed) [Reordered, Document cleanup, and so].

- Updated the manual in the MModel header for creating a model in regards to refactoring above.

- Updated Response Models in regards to the refactoring above.

- Made each byte space separator in Flags class in Types class for cleaner logging (will be used empty string in Alarm Status for logging).

- Changed the logging folder to be log folder (not event, error) and changed the log file extension for events/data to be .log and for errors to be .err.

- log file format modified to be CSV.

- Removed a not used fromByteArrayState method of mtreatmentadjustmentultrafiltrationconfirmresponse , mtreatmentadjustmentultrafiltrationeditresponse.

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 62 more files in changeset.
DEN-3164 : Code Review 0

- Corrected the copyright comment Doxygen tags.

- Corrected the copyright template Doxygen tags.

- Added check for fall through in switch statements to project.

- Added method comments in tst_messaging, unit test class.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 83 more files in changeset.
DEN-2236_UI100%CoverageoftheApplicationSoftware

level 1

Coverage : 99.594% (1473/1479)

Manual : 15.416% (228/1479)

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 38 more files in changeset.
Another CAN Messaging format for testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

  1. … 5 more files in changeset.
DEN-1714 : Implementation

- Added missing documentation

- Disabled the Acknow message debugging.

  1. … 5 more files in changeset.
DEN-1714 : Implementation

  1. … 7 more files in changeset.
DEN-1714 : Implementation

  1. … 30 more files in changeset.
Merge branch 'master' into DEN-1396_LogHandler

  1. … 36 more files in changeset.
DEN-1714 : Implementation

  1. … 18 more files in changeset.
DEN-1437 : Implementation

- Changed 2019-2019 in copyright to 2019-2020.

  1. … 59 more files in changeset.
Updated the Copyright with the current year and replaced tabs with 4 spaces

  1. … 13 more files in changeset.
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Added threading to other classes (Application / Gui controller, ...) and restructured the threading to meed the Qt limitation.

- Documented the code

- Ran cppCheck again

- Cleaned the includes and using namespace (They have left after so many changes and some were useless.)

- Added _init flag for init methods so not to be able to call them twice.

- Added another init method with the thread parameter to be able to pass the thread of the class and also be able to use the class without any thread for unit tests.

- Created a Threads namespace to gather all the threads in one place.

- Update the unit tests as well. [to make it work with the new structure/threading.]

  1. … 35 more files in changeset.
DEN-1617 : Implementation - Alarm Logging and Acknowledgment

- Alarm Logging has been added

- Some other changes has been done to the code and messaging.

- Acknowledgment is not done [ Had an agreement with Sean for design but needs more time and we need to do it all together.]

  1. … 36 more files in changeset.
DEN-1396 : UI Log Handler

MISC :

- Updated the Singleton defines to delete the instance.

- Added/moved the floatCompare in the types.cpp and created the file to do so.

LOGGING :

- Implemented logging

- Added LOG_EVENT / LOG_DATUM / LOG_ERROR in code instead of qDebug() as sample of the log event .

- Added export to USB feature.

- Added "Export Button"

  1. … 25 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Fixed Comment Spacing [Code Review]

DEN-1090 : UI Message Handler / Error Handler

- Updated the constants by enums [Code Review]

  1. … 3 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Trying a solution to have separate unit tests for each feature.

- Changed the unittests class to tst_canbus since this is the unit test for implemented canbus messages and interaction.

- removed .pro.user from gitignore since denali.pro.user contains configurations for local unit tests setup and need to be cloned for the new ones.

- Fixed issues which has been found during the unit tests.

  1. … 15 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Documented the code

- Added gcc flag to use all the warning as errors and don't let the application compile.

- Modified the build frame structure to return bool true as of successful build message and moved the frame list into the function parameter list.

This way by using __attribute_warn_unused_result__ we can force the code who uses this method to check for the return value of successful build.

- Same has been done for some other methods.

  1. … 14 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Fixed application close which wasn't closing Can Device connection.

- Changed to date to 2019 in copyright section.

- In MessageInterpreter, named getBloodFlowData method parameters to the meaningful data names.

- Moved fromVariant method to Format utility class.

- Added Code documentation and description.

  1. … 61 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Moved toHexString to a place more general so can be used everywhere.

- added command line switches to enable the can messages debugging easier.

- Added an Unhandled console out message.

- Added two other alarm message to the registered list but will console out the Unhandled message.

  1. … 9 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Added CRC to the messages [added to the sent message and checked for the received message]

- Added ability to to enable/disable crc and keepAlive from project during build

- Added a feature to write the can messages in color formatted to the console in Can interface and Message Handler for easier debugging. Which can also be disabled by code.

- Added Animation to the TouchRect Touch to better understand if it has been touch.

- Added a demo/sample data text to display the corrent Blood Flow values on the StartTreatment Screen.

  1. … 18 more files in changeset.
DEN-1090 : UI Message Handler / Error Handler

- Modified enum to be enum class for clarification of the code.

- Added Message Interpreter

- Updated Message Builder to check CRC as a placeholder.

- Fixed Message Builder for messages with exactly 255 data length.

- Updated Message Builder methods scope for clarification of the code.

- Updated Message (Model) isComplete method.

- Updated Message Dispatcher to accept only command which has been defined for channel.

- Updated Message Dispatcher to remove the message from model when it has been transmitted.

  1. … 18 more files in changeset.