application / sources

canbus

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 17 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Sep 2021
2:50 pm

Behrouz NematiPour

DEN-9639: Code Review 0

- Addressed code reviews

- Reoved LOG_DEBUG_UI since the DEBUG log is all about UI and adding a UI to it was useless.

- Removed the time stamp from the POST start/stop log since the log itself has timestamp.

- Added more documentation to the ApplicationPOST class.

- Renamed the FileSystem to ShaSum check in the ApplicationPOST.

- Updated the WiFi POST check funciton.

- Updated the initial Screen to pause the animation when the UI navigates out of that screen when we are in test (usual case should not happen since we fail or pass the POST and either stops the animation.)

- Updated the AlarmMapping to reflect the FILESYSTEM error change to SHASUM error.

Options
    • -1
    • +1
    ./FrameInterface.cpp
    • -1
    • +1
    ./MessageAcknowModel.cpp
    • -1
    • +1
    ./MessageDispatcher.cpp
    • -2
    • +2
    ./MessageInterpreter.cpp
  5. … 16 more files in changeset.
10:07 am

Sean Nash

Remove blank line.

Remove blank line.

9:52 am

Sean Nash

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use). So this comment appears to be inconsistent with the header file.

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use).
So this comment appears to be inconsistent with the header file.

9:50 am

Sean Nash

"... and then, and them," - looks like something is wrong with this comment.

"... and then, and them," - looks like something is wrong with this comment.

Tuesday 21 Sep 2021
6:26 pm

Sean Nash

RESOLVED.

RESOLVED.

6:26 pm

Sean Nash

RESOLVED.

RESOLVED.

5:55 pm

Behrouz NematiPour

In UI we have multiple types of TODOs. DEBUG, FIXME, WARNING, NOTE, TODO

In UI we have multiple types of TODOs.
DEBUG, FIXME, WARNING, NOTE, TODO

5:53 pm

Behrouz NematiPour

This was not a bug, It was a change request from Sarina to remove the Rinseback Aditional 5 min counter. I kept it in case we may need it later.

This was not a bug,
It was a change request from Sarina to remove the Rinseback Aditional 5 min counter.
I kept it in case we may need it later.

5:49 pm

Sean Nash

Does this mean commenting out these 2 lines fixed a bug? If so, why not just delete them?

Does this mean commenting out these 2 lines fixed a bug? If so, why not just delete them?

5:48 pm

Sean Nash

Temporary? Maybe add a // TODO or is // DEBUG something you'll know to search for later?

Temporary? Maybe add a // TODO or is // DEBUG something you'll know to search for later?

11:38 am

Behrouz NematiPour

updated.

updated.

11:38 am

Behrouz NematiPour

updated.

updated.

11:38 am

Behrouz NematiPour

updated.

updated.

11:38 am

Behrouz NematiPour

updated.

updated.

11:19 am

Behrouz NematiPour

Monday 20 Sep 2021
10:31 pm

pmontazemi  (deleted user)

We either start with Capital letter everywhere or we don't.

We either start with Capital letter everywhere or we don't.

10:30 pm

pmontazemi  (deleted user)

We either start with Capital Letter everywhere or we don't.

We either start with Capital Letter everywhere or we don't.

10:29 pm

pmontazemi  (deleted user)

Remove extra spaces after vData.

Remove extra spaces after vData.

10:22 pm

pmontazemi  (deleted user)

it is (formal) instead of it's (informal)

it is (formal) instead of it's (informal)

9:46 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:45 pm

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:05 pm

Behrouz NematiPour

Fixed.

Fixed.

9:03 pm

Behrouz NematiPour

Code Review Comments

- QApplication typo

- Added a UI version of the Log Macros.

Options
    • -1
    • +1
    ./CanInterface.cpp
    • -2
    • +2
    ./FrameInterface.cpp
    • -2
    • +2
    ./MessageAcknowModel.cpp
    • -2
    • +2
    ./MessageDispatcher.cpp
    • -4
    • +3
    ./MessageInterpreter.cpp
  6. … 9 more files in changeset.
8:47 pm

Behrouz NematiPour

1) This sleep helps the Bluetooth driver to load properly. 2) After many, many tests figured the Bluetooth device needs a power cycle after it is loaded and find out if giving it a 5-second delay b...

1) This sleep helps the Bluetooth driver to load properly.
2) After many, many tests figured the Bluetooth device needs a power cycle after it is loaded and find out if giving it a 5-second delay before setting the "hci" device to up, then it works fine and doesn't need the power cycle anymore. I timed the boot up and it's still under 30 seconds.
3) Yes it shouldn't break the loading of the other prototypes, since they may never even need it.

3:06 pm

pmontazemi  (deleted user)

QApplication is misspelled

QApplication is misspelled

3:06 pm

pmontazemi  (deleted user)

1) What is this sleep for? 2) How did you come up with its value? (I assume this is in seconds?) 3) Is this value consistent among all 4 prototypes and the development boards that we have?

1) What is this sleep for?
2) How did you come up with its value? (I assume this is in seconds?)
3) Is this value consistent among all 4 prototypes and the development boards that we have?

Thursday 16 Sep 2021
2:17 pm

Behrouz NematiPour

UI-DEN-9626_DEV Bluetooth Cuff Integration
UI-DEN-9626_DEV Bluetooth Cuff Integration
Monday 06 Sep 2021
10:08 pm

Behrouz NematiPour

DEN-9659: Implementation [POST]

- Created a separate file for the Bluetooth screen since it became bigger.

- Moved the WiFi and Bluetooth start in the Application controller and handled by POST events.

- Added a 5 second sleep for the Bluetooth Device to get ready in run.sh

- Added WiFi POST in run.sh

- Moved lambda functions for POST into slots.

- Added signals in the ApplicationPOST for passed items to be used in the ApplciationController to start WiFi and Bluetooth interfaces.

- Added isValid to the BluetoothInterface to make sure the Bluetooth Adapter is ready for the Interface to setup (Is set by ApplicationController with the information Provided by ApplicationPOST).

- Improved the Bluetooth interface implementation

- Added Rinseback safety volume parameter

- Modified the SAFE_CALL's methods to be public slots.

- Removed the SerialNumber listener from VBluetooth.

- Improved the VBluetooth code and added the connection to the BluetoothController.

Options
    • -1
    • +1
    ./MessageGlobals.h
  2. … 20 more files in changeset.
Wednesday 01 Sep 2021
8:07 pm

Behrouz NematiPour

Monday 30 Aug 2021
11:44 am

Sean Nash and pmontazemi  (deleted user)