Activity application/sources/gui

4:27 pm

Behrouz NematiPour

More
1f89cfb
changed 1 file
master, @Environement_Swith and 212 more UI-DEN-10424-1

DEN-10161: Missing END TREATMENT option in Treatment-Recirculate-Stop screen

- The screen (Reconnect) belongs to the TREATMENT_RECIRC_STOPPED_STATE state of the TREATMENT_RECIRC_STATE in the TREATMENT_STATE message, didn't even have a "END TREATMENT" button, which has been added.

- The time_IsLeft logic has NOT been removed yet, since I don't recall why it has been used in the first place.

- -5
- +20
./qml/pages/endtreatment/EndTreatmentRecirculateStack.qml
- History
- Source
- Diff
./qml/.../EndTreatmentRecirculateStack.qml

8:25 pm

Behrouz NematiPour

More
UI-DEN-9626-1
Closed

4:11 pm

pmontazemi (deleted user)

More
UI-DEN-9626-1
finished reviewing

4:10 pm

pmontazemi (deleted user)

RESOLVED.

4:10 pm

pmontazemi (deleted user)

RESOLVED.

4:10 pm

pmontazemi (deleted user)

RESOLVED.

4:10 pm

pmontazemi (deleted user)

RESOLVED.

10:42 pm

Sean Nash

More
UI-DEN-9626-1
finished reviewing

10:38 pm

Sean Nash

RESOLVED.

10:32 pm

Sean Nash

RESOLVED.

10:32 pm

Sean Nash

RESOLVED.

4:32 pm

Behrouz NematiPour

More
76d4131
changed 7 files
master, @Environement_Swith and 213 more UI-DEN-9626-1

DEN-10399: UI: Alarms block Shutdown screen

DEN-9271: Dialysate Temperature implemented resolution does not meet PRS

- -0
- +5
./qml/AlarmItem.qml
- History
- Source
- Diff
./qml/AlarmItem.qml
- -0
- +6
./qml/PowerItem.qml
- History
- Source
- Diff
./qml/PowerItem.qml
- -1
- +1
./qml/components/Slider.qml
- History
- Source
- Diff
./qml/components/Slider.qml
- -2
- +4
./qml/main.qml
- History
- Source
- Diff
./qml/main.qml
… 3 more files in changeset.

2:53 pm

Behrouz NematiPour

More
Re: UI-DEN-9626-1
replied to Sean Nash

Thanks for the comment. I removed those two and updated the comments as well.

Thanks for the comment.
I removed those two and updated the comments as well.

2:52 pm

Behrouz NematiPour

More
Re: UI-DEN-9626-1
replied to Sean Nash

Updated the comments to clarify. In ' ..., and them,...' it meant logical AND &&. And added a lot more comments.

Updated the comments to clarify.
In ' ..., and them,...' it meant logical AND &&.
And added a lot more comments.

2:50 pm

Behrouz NematiPour

More
Re: UI-DEN-9626-1
replied to Sean Nash

Removed.

2:50 pm

Behrouz NematiPour

More
3e64d98
changed 20 files
master, @Environement_Swith and 213 more UI-DEN-9626-1

DEN-9639: Code Review 0

- Addressed code reviews

- Reoved LOG_DEBUG_UI since the DEBUG log is all about UI and adding a UI to it was useless.

- Removed the time stamp from the POST start/stop log since the log itself has timestamp.

- Added more documentation to the ApplicationPOST class.

- Renamed the FileSystem to ShaSum check in the ApplicationPOST.

- Updated the WiFi POST check funciton.

- Updated the initial Screen to pause the animation when the UI navigates out of that screen when we are in test (usual case should not happen since we fail or pass the POST and either stops the animation.)

- Updated the AlarmMapping to reflect the FILESYSTEM error change to SHASUM error.

- -1
- +1
./GuiController.cpp
- History
- Source
- Diff
./GuiController.cpp
- -1
- +2
./qml/components/WaitDone.qml
- History
- Source
- Diff
./qml/components/WaitDone.qml
- -0
- +1
./qml/pages/MainStack.qml
- History
- Source
- Diff
./qml/pages/MainStack.qml
… 17 more files in changeset.

10:07 am

Sean Nash

More
Re: UI-DEN-9626-1
commented on review

Remove blank line.

9:52 am

Sean Nash

More
Re: UI-DEN-9626-1
commented on review

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use). So this comment appears to be inconsistent with the header file.

In the header file, the Ethernet and sound tests are said to be not required (i.e. should not prevent system use).
So this comment appears to be inconsistent with the header file.

9:50 am