Activity application/sources/gui

1:01 pm

Vy <vduong@sunriselabs.com>

More
fd1fc57
changed 1 file
master, @Environement_Swith and 93 more UI-UCOMMITS-11

DEN-16366: Fixed - Changes to window size return Request_Reject_Reason_Param_Out_Of_Range on first try

Correct the values set to the treatment pressure on reset and entry into the pressure adjustment dialog

- -6
- +6
./qml/pages/treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
- History
- Source
- Diff
./qml/.../TreatmentAdjustmentPressuresLimits.qml

12:05 pm

Dara Navaei

More
UI-DEN-16335-6
started review

[ On Hold - P1B ] UI-DEN-16335_UI VD S105 DFF - Log Export Improvements

6:20 am

vduong (deleted user)

Added

6:19 am

vduong (deleted user)

Removed conversion

6:19 am

vduong (deleted user)

Added.

6:19 am

vduong (deleted user)

Done.

6:19 am

vduong (deleted user)

There is no CPP for this file. Unless you meant a different location

6:11 am

Vy <vduong@sunriselabs.com>

More
c1031c7
changed 5 files
master, @Environement_Swith and 93 more UI-DEN-16335-5

DEN-16256: Updated - UI.P1B : Display UF Rate

Added QML text to display the rate

Include the 11th parameter

- -0
- +1
./qml/globals/Fonts.qml
- History
- Source
- Diff
./qml/globals/Fonts.qml
- -0
- +14
./qml/pages/treatment/sections/TreatmentUltrafiltration.qml
- History
- Source
- Diff
./qml/pages/.../TreatmentUltrafiltration.qml
… 3 more files in changeset.

8:12 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

update the length check of the message in MessageGlobals.h const QHash<Gui::GuiActionType ,quint8> payloadLen { . . {Gui::GuiActionType::ID_DialysateOutletFlow , 10 * 4 }...

update the length check of the message in MessageGlobals.h

const QHash<Gui::GuiActionType ,quint8> payloadLen {
.
.
{Gui::GuiActionType::ID_DialysateOutletFlow                     ,  10 * 4       }, //10 parameters each 4bytes
.
.
}

7:50 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

param 11 is missing 01 F32-refUFVolMl 02 F32-measUFVolMl 03 F32-measRotSpdRPM 04 F32-measSpdRPM 05 F32-measMCSpdRPM ...

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate

7:49 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

param 11 is missing 01 F32-refUFVolMl 02 F32-measUFVolMl 03 F32-measRotSpdRPM 04 F32-measSpdRPM 05 F32-measMCSpdRPM ...

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate

7:39 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

I think we should use mL/min as is. and do not convert to Liter.

7:31 pm

Behrouz NematiPour

More
Re: UI-DEN-16335-5
commented on review

Update the cpp as well

11:35 am

vduong (deleted user)

More
UI-DEN-16335-3
started review

UI-DEN-16335_UI VD S105 Disable confirm device config - [READY]

10:53 am

vduong (deleted user)

More
UI-DEN-16335-3
Closed

10:05 am

Dara Navaei

More
UI-DEN-16335-5
started review

UI-DEN-16335_UI VD S105 - P1B - Display UF Rate - [READY]

9:50 am

msuleiman (deleted user)

More
UI-DEN-16335-3
finished reviewing

8:21 am

Vy <vduong@sunriselabs.com>

More
f3fa6fc
changed 8 files
master, @Environement_Swith and 93 more UI-DEN-16335-3

DEN-16235: Updated - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed more than once

Per Code Review Discussions:

- Remove the directory comparison function

- Remove the added variables from last commit (isExited, etc)

- Change logic for cryptSetupEnabled property setting

- -1
- +1
./qml/pages/settings/SettingsManufacturingSetup.qml
- History
- Source
- Diff
./qml/pages/.../SettingsManufacturingSetup.qml
… 7 more files in changeset.

4:38 pm

msuleiman (deleted user)

More
UI-DEN-13226-1
finished reviewing

4:32 pm

msuleiman (deleted user)

More
UI-DEN-13226-1
joined review

12:05 pm

Dara Navaei

More
UI-DEN-16335-3
started review

UI-DEN-16335_UI VD S105 Disable confirm device config - [READY]

10:17 am

Vy <vduong@sunriselabs.com>

More
4fc7cdc
changed 8 files
master, @Environement_Swith and 93 more UI-DEN-16335-3

DEN-16235: Fixed - UI Device Setup - Device Configuration screen "Confirm" button should not be allowed to be pressed more than once

Add logic to properly handle disabling the confirm button when the device configuration is complete

Add a command to compare two directories for sameness

Add correct displaying of the completion of the device configurations

- -1
- +1
./qml/pages/settings/SettingsManufacturingSetup.qml
- History
- Source
- Diff
./qml/pages/.../SettingsManufacturingSetup.qml
… 7 more files in changeset.

8:16 pm

Behrouz NematiPour

More
c055cdf
changed 1 file
master, @Environement_Swith and 93 more UI-DEN-16288-1

DEN-16132: Check Marks Do Not Appear during Consumables Self Test

- -3
- +3
./qml/pages/pretreatment/PreTreatmentPrimeStack.qml
- History
- Source
- Diff
./qml/pages/.../PreTreatmentPrimeStack.qml

8:09 pm

Behrouz NematiPour

More
b18b4c0
changed 3 files
master, @Environement_Swith and 93 more UI-DEN-16288-1

DEN-16132: Check Marks Do Not Appear during Consumables Self Test

- -4
- +4
./qml/pages/pretreatment/PreTreatmentConsumablesStack.qml
- History
- Source
- Diff
./qml/.../PreTreatmentConsumablesStack.qml
- -12
- +12
./qml/pages/pretreatment/PreTreatmentPrimeStack.qml
- History
- Source
- Diff
./qml/pages/.../PreTreatmentPrimeStack.qml
- -3
- +3
./qml/pages/settings/SettingsDeviceRegistration.qml
- History
- Source
- Diff
./qml/pages/.../SettingsDeviceRegistration.qml

4:54 pm

vduong (deleted user)

RESOLVED

11:28 am

vduong (deleted user)

More
Re: UI-DEN-16288-1
commented on review

I suggest doing --enable-update-mode (all lowercase) to be consistent with the other params

11:26 am

vduong (deleted user)

More
Re: UI-DEN-16288-1
commented on review

her. => here.

11:26 am

vduong (deleted user)

RESOLVED

11:25 am

vduong (deleted user)

RESOLVED

11:25 am

vduong (deleted user)

RESOLVED

gui

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Vy <vduong@sunriselabs.com>

Dara Navaei

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

Vy <vduong@sunriselabs.com>

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

vduong (deleted user)

vduong (deleted user)

Dara Navaei

msuleiman (deleted user)

Vy <vduong@sunriselabs.com>

msuleiman (deleted user)

msuleiman (deleted user)

Dara Navaei

Vy <vduong@sunriselabs.com>

Behrouz NematiPour

Behrouz NematiPour

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)

vduong (deleted user)