MPostTreatmentStatesData.cpp

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UI-DEN-12031_Leahi/Features/Den 12031 UI AM Models Nested Ifs
UI-DEN-12031_Leahi/Features/Den 12031 UI AM Models Nested Ifs
UI-DEN-SUNRISE
UI-DEN-SUNRISE
RESOLVED.

RESOLVED.

Thanks, Will update my comment.

Thanks,
Will update my comment.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Your comment has ???. Trying to help.

Your comment has ???. Trying to help.

Fixed too.

Fixed too.

Great catch, Thank a lot Sean for catching that. It is fixed.

Great catch,
Thank a lot Sean for catching that.
It is fixed.

Not clear what you want me to do here?

Not clear what you want me to do here?

In post-treatment, there are a few states to work through to ensure reservoirs get drained: /* Post-Treatment drain reservoirs state machine. */ typedef enum Drain_States { DRAIN_DG_DEPRIME_STATE ...

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
UI-DEN-14936_UI BN S93
RESOLVED

RESOLVED

Updated.

Updated.

Looks like this needs to be updated

Looks like this needs to be updated

RESOLVED.

RESOLVED.

That is the function signature and doesn't have to have any parameter defined if it is not being used and no argument is passing to it. This way we don't need to use the Q_UNUSED(vData); anymore fo...

That is the function signature and doesn't have to have any parameter defined if it is not being used and no argument is passing to it.
This way we don't need to use the Q_UNUSED(vData); anymore for parameters not being used.